cpet/openbsd-ports
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

when parsing icmp only check that we have enough data up to what is being really looked into (4 bytes). fixes short pings display; pval@ ok

Browse Source
This commit is contained in:
mickey 2004-05-08 17:19:40 +00:00
parent 44e3d691c8
commit 2b7dce195a
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
net/trafshow/patches/patch-display_c Normal file
View File

@ -0,0 +1,21 @@
--- display.c.bak.orig Mon Aug 24 00:51:48 1998
+++ display.c Tue Aug 28 17:35:19 2001
@@ -386,18 +386,18 @@
clrtoeol();
goto refresh_screen;
}
sport = ntohs(((struct udphdr *)cp)->uh_sport);
dport = ntohs(((struct udphdr *)cp)->uh_dport);
} else if (ip->ip_p == IPPROTO_ICMP) {
- if (cp + sizeof(struct icmp) > snapend ||
- iplen - hlen < sizeof(struct icmp)) {
+ if (cp + 4 > snapend ||
+ iplen - hlen < 4) {
mvprintw(LINES-1, err_pos, "\
truncated-icmp: wrong ip hdrlen");
clrtoeol();
goto refresh_screen;
}
sport = ((struct icmp *)cp)->icmp_type;
}
}