8866cc102d
It is not valid to define PORT_OPTIONS variable directly (this is done through OPTIONS_DEFINE and related variables) and definitely they can't be modified after inclusions of bsd.port.pre.mk or bsd.port.options.mk fragments. Since the port needed to be reworked anyway, I simplified it a lot. I removed a shell command (with 3 pipes!) completely. I saw several ways to create ${ALLDICTS} with basic makefile techniques, but in the end it wasn't even necessary. I eliminated the "ALL" option. It didn't make sense. If "ALL" was set, it would override the individual language options (leading to possible confusion) and the "ALL" option was set by default, and then it even checked PACKAGE_BUILDING to override the value to ALL again. I have to assume that it wasn't originally set up that way but changed over time. Now only the language options are there and they are all "ON" by default. It's simpler to disable languages than before (no need to deselect "ALL" option first). The <pre> and <post> inclusions were removed, they aren't necessary. The PLIST substitutions are made with standard OPTIONS_SUB technique. The work is verified by checking SELECTED_OPTIONS and DESELECTED_OPTIONS which now show the correct values and the dependencies registered to the built package now match the port. Approved by: infrastructure blanket (fix options) |
||
---|---|---|
.. | ||
distinfo | ||
Makefile | ||
Makefile.dict | ||
Makefile.options | ||
pkg-descr | ||
pkg-plist |