because it first tries to link this library statically, and when
that fails, it "forgets" to try linking it dynamically. The reason
is that it has a bunch of nested loops to try multiple variations
on the library name and keeps track of which library names it has
tried so that it doesn't retry the same library name. The problem
is that one of the loop variables also governs whether it should
try static or dynamic liking, and if static linking fails, the
library name gets added to the exclusion list, which prevents it
from trying dynamic linking. Fix by the value of the loop variable
$boost_rtopt_ to the key value into the list of library variations
to disambiguate the two cases so that linking both ways is tried.
Also move the location where $boost_failed_libs is set out by one
nesting level to prevent the same library name value from being added
to the list multiple times.
Get rid of .include <bsd.port.options.mk> and .if ${PORT_OPTIONS:MDOCS}
as suggested by mat@. Portlint whines about it but the Porters Handbook
says it is OK because the doc files are few and small.
Unmute ${INSTALL_DATA} as suggested by portlint.
PR: 195597
Differential Revision: https://reviews.freebsd.org/D2279
Reviewed by: kwm
Approved by: mat (mentor)
4b34a92461