1. Import a pull request I've just sent upstream that makes FindHelper.cmake
behave better and stop using pkg-config's output directly as include and
library paths. The consequence is that libraries like libarchive,
libsndfile, jack etc are now found with their full path and we can stop
setting LDFLAGS in Makefile.
2. Set USES=libarchive. Even though the port does not require any
functionality that is only present in libarchive from ports, explicitly
depending on a certain version makes things more consistent.
Additionally, before this patch there would be no dependency on
libarchive from ports but since the linker was previously called like
this:
c++ ... -o hydrogen -L/usr/local/lib -larchive -lsndfile ...
so the port would end up linking against libarchive from ports when it
was present (which is always, since devel/cmake depends on it). And with
this patch we have
c++ ... -o hydrogen -larchive /usr/local/lib/libsndfile.so ...
which does link against libarchive from base, but then fails `make
stage-qa', which expects all ports to link against ports libarchive.
PR: 202905
Approved by: FreeBSD@ShaneWare.Biz (maintainer)
53d279a72a