* Be less strict in the check for MASTER_SITE_SUBDIR use.
This change checks that the subdirectory used is actually different
than what is defined in MASTER_SITES_SUBDIRS. To make this easier to
do, support has been added to single-quote variables passed to the
get_makevar* functions. [1]
* Now only PY_FLAVOR is recommended as opposed to FLAVOR. [2]
* Remove an errant ':' when suggesting PY_FLAVOR. [3]
PR: 228227 [1]
Requested by: mat [2]
Reported by: koobs [3]
Fix a regression in the mae makepatch check.
Make sure only the patch header is checked, but make sure
to read in the entire patch file. This regression was
introduced in 2.18.0.
PR: 228203
Soften the py-* dependency error around flavors.
Now the message is a warning and a suggestion. This is pending more discussion,
but this seems like a good compromise for now.
PR: 225654
Requested by: antoine
* Fix the check for duplicate SHEBANG_LANG values [1]
* Check to make sure patch files end with newlines [2]
* Allow flavored *_DEPENDS in the DEPENDS section [3]
* Check that kde:4 OR kde:5 is defined with USE_KDE [4]
* Add a check to make sure pkg-descr is at least a certain number of lines [5]
* Fix a couple of typos [6] [7]
* Allow for any *_DEPENDS item in the DEPENDS section and fix a bug in the
dependency syntax checking [8]
* Add a check to make sure Python dependencies include a FLAVOR [9]
PR: 226709 [1]
226109 [2]
226581 [3]
227255 [5]
227729 [6]
227878 [7]
227556 [8]
225654 [9]
Submitted by: tcberner [4]
0mp [5][6][7]
Differential Revision: D13723 [4]
* Check for USE_PYQT when USES=pyqt:5 is defined [1]
* Avoid more bogus direct command use warnings. Also try and fix some line numbers [2]
* Check for over-verbose use of magic MASTER_SITES_SUBDIRS [3]
* Do not complain about missing Created by: [4]
* Avoid checking direct command usage in embedded comments [5]
PR: 225615 [1]
225612 [2]
225503 [3]
225781 [5]
Reported by: Jason Bacon <bacon4000@gmail.com> [4]
* Don't check for direct command use for ONLY_FOR_ARCHS_REASON
and NOT_FOR_ARCHS_REASON when a specific arch has been specified. [1]
* Preserve an original variable value to make sure the check for copying
dependecies is actually performed.
* Don't complain about incon installation if the port is a Qt5 port. [2]
* Check that PLIST_FILES entries do not contain %%FOO% notation. [3]
* Check that DOCS and EXAMPLES are defined as OPTIONS when using %%PORTDOCS%%
and %%PORTEXAMPLES%%. [4]
* Check that if USE_LDCONFIG is defined, then the port installs shared
objects. [5]
* Check that when USE_KDE is defined, then USES=kde:5 is also defined. [6]
* Ignore flavors when trying to find port directories. [7]
* Revert the fix for 221971 (USE_GITHUB). More debate is needed here.
PR: 223285 [1]
223498 [2]
223539 [3]
223541 [4]
223762 [5]
224140 [6]
224245 [7]
Submitted by: adridg [2]
mat [4]
224245 [7]
* Do not complain about USE_GITHUB before USES [1]
* Make sure each variable in a dependency is fully expanded [2]
* Clean up the earlier checks for BROKEN, etc. to prevent bogus warnings [3]
* 'USE=execinfo' is removed with ports r450351. So stop suggesting to use it [4]
PR: 221971 [1]
221605 [2]
222409 [3]
222653 [4]
Submitted by: amdmi3 [1]
jrm [2]
Yasuhiro KIMURA <yasu@utahime.org> [4]
* Don't check for absolute paths inside make variables [1]
* Check pkg-plist for use of OPTIONS [1]
* Fix an issue with line number offsets [2]
* Don't alert on double-dollar (VARIABLE) [3]
* Allow BROKEN, IGNORE, DEPRECATED to appear before the *_DEPENDS block [4]
* Check that manpages are not installed into share/man [5]
* Check for a space anywhere between a variable and its value [6]
PR: 221507 [1]
221291 [2]
221397 [3]
221377 [4]
221455 [5]
221219 [6]
Submitted by: Dmitri Goutnik <dg@syrec.org> [4]
* Trim comments after USE_GCC [1]
* Add a check for redundant SHEBANG_LANG values [2]
* Make sure both USES and USE_* are actually seen before checking
to see if one is included before the other [3]
PR: 221085 [1]
220500 [2]
Submitted by: gerald [1]
Reported by: dbaio [3]
* Remove the other check for conflicts that are too broad [1]
* Remove the check for portlint that is more than 30 days old [2]
* Check to see uf USE_* comes before USES [3]
PR: 220087 [2]
220340 [3]
Reminded by: dbaio [1]
* Remove a check for narrow conflicts now that we are in the post-pkg world [1]
* Genericize the USES_ sorting code and check to see if NOT_FOR_ARCHS
and ONLY_FOR_ARCHS are sorted. [2]
* Fix the check for JAVALIBDIR so that it falls before the variable expansion
code. [3]
PR: 219684 [1]
218823 [2]
219360 [3]
Submitted by: eugen [3]
* Check for use of OPT_XXX_OFF syntax to prevent false incorrect option
usage assertions. [1]
* Remove now-obsolete warning about using :LU operators with make(1). [2]
* Fix the regex to prevent direct command use from hittin on lines
like FOO_USES=... [3]
PR: 218260 [1]
218325 [2]
218672 [3]
Submitted by: jrm [2]
Reported by: rezny [2]
* Fold in the same removal of the obsolete HTTP-only warning
* Add support for checking for direct dependency on bison, fmake, and libexecinfo. [1]
PR: 216268 [1]
HTTPS-only is normal novadays, also may@ says that the warning was
there because before 8.4 libfetch did not support going through a
proxy for HTTPS
PR: 217995
Approved by: maintainer timeout (marcus, 2 weeks)
Differential Revision: D10015
* Allow https URLs for the WWW line in pkg-descr. Why are we only NOW doing
this? [1]
* Check TIMESTAMP to make sure it's in the present/past, but not more than 30
days in the past. [2]
PR: 212091 [2]
Submitted by: amdmi3 [1]
Differential Revision: D8462 [1]
* Drop the need for PORTSDIR in dependencies [1]
* Allow a trailing ':' in URLs [2]
* Check to make sure the value(s) of SUB_FILES is healthy [3]
* Expand variables on all sides of the dependency tuple [4]
(this last change is rather big, and thus bumping minor version)
PR: 208272 [1]
207843 [2]
207477 [3]
206061 [4]
Submitted by: amdmi3 [1]
* Attempt to properly detect gettext [1]
* Add support for @<pre|post>[un]exec plist directives [2]
* Add support for the new @sample plist directive changes [2]
* Modify the text when checking for used OPTIONS [3]
PR: 204370 [1]
204900 [2]
204575 [3]
${PERL5} points to a specific version of perl, say, perl5.22.1, it is
fine to use it in a ports Makefile to do Perly things, but ports using
it must use ${PERL}, that points to /usr/local/bin/perl so that if the
minor version is updated, the shebang keep working.
While there, make some ports use shebangfix, regen a few patches, and
bump PORTREVISION where a shebang went from PERL5 to PERL.
PR: 205367
With hat: portmgr
Sponsored by: Absolight
* Add support for @(...) notation [1]
* Remove the check for USES being sorted. Order is important. [2]
* Add support for making sure @owner and @group are properly reset [3]
PR: 202570 [1]
203908 [2]
202711 [3]
* Only report "make makepatch" once per patch file [1]
* Attempt to re-word the make makepatch warning to avoid unnecessary repo
churn [2]
* Attempt to test some other macros for sorting [3]
* Do not check empty dependencies for validity [4]
PR: 202050 [1]
201647 [2]
201409 [3]
202052 [4]
Submitted by: gerald [1]
* Add a check for BROKEN similar to IGNORE [1]
* Quiet the noise when used with Perl 5.22 [2]
* Fix a bug checking for USES sortedness [3]
* Correct a logic bug checking for USE_ANT [4]
PR: 200634 [2]
200792 [3]
200421 [4]
Submitted by: pi [2]
John Hein <z7dr6ut7gs@snkmail.com> [4]
Reported by: koobs [1]
* Correct a typo. This should have been SITE_ARCH_REL. [1]
* Pre-populate USES with an explicit grep of the Makefile. [2]
* Correct a typo to prevent direct command usage checking in pkg-* files. [3]
* Adjust the order of first-paragraph items so that proper checking is done. [4]
* Adjust the warning about installing docs by wrapping with
.if ${PORT_OPTIONS:MDOCS}. [5]
* Add a check for ${SETENV} instead of ${ENV}. [5]
PR: 199974 [2]
199693 [3]
199428 [4]
199417 [5]
Submitted by: adamw [4]
sunpoet [1]
* Check the patches to make sure they were generated using ``make patch'' [1]
* Do not throw a bunch of Perl errors if the makefile is bad [2]
PR: 197747
198887
* Exclude .git directories from error reporting [1]
* Add some additional Perl checks for STAGEDIR [2]
* Try not to flag on direct use of "install" if we're running a make command [3]
* Fix the checks for Perl given the new hierarchy [4]
PR: 195780 [1]
194759 [3]
196222 [4]
Submitted by: gerald [3]
Yasuhiro KIMURA <yasu@utahime.org> [1]
Requested by: mat [2]
Portlint's history goes back to itojun. I've researched his open source
projects and he either used two licenses:
BSD3CLAUSE: magicpoint, sch
His own license: portlint, snooper, various camera tools, etc
Debian asked him years ago about his license to see if it complies with
thier DFSG:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=88416
Example of his license:
Copyright(c) 1997 by Jun-ichiro Hagino <itojun@itojun.org>.
All rights reserved.
Freely redistributable. Absolutely no warranty.
OR
Absolutely no warranty. Pray before try. Freely redistributable.
Hope I'm not crossing any boundaries here, but in my effort to clean up
"BSD" licenses in the ports tree this one certainly is not and sadly we
can't just ask him.
Before, we had:
site_perl : lib/perl5/site_perl/5.18
site_perl/perl_arch : lib/perl5/site_perl/5.18/mach
perl_man3 : lib/perl5/5.18/man/man3
Now we have:
site_perl : lib/perl5/site_perl
site_arch : lib/perl5/site_perl/mach/5.18
perl_man3 : lib/perl5/site_perl/man/man3
Modules without any .so will be installed at the same place regardless of the
Perl version, minimizing the upgrade when the major Perl version is changed.
It uses a version dependent directory for modules with compiled bits.
As PERL_ARCH is no longer needed in plists, it has been removed from
PLIST_SUB.
The USE_PERL5=fixpacklist keyword is removed, the .packlist file is now
always removed, as is perllocal.pod.
The old site_perl and site_perl/arch directories have been kept in the
default Perl @INC for all Perl ports, and will be phased out as these old
Perl versions expire.
PR: 194969
Differential Revision: https://reviews.freebsd.org/D1019
Exp-run by: antoine
Reviewed by: perl@
Approved by: portmgr
* Remove @MASTERSITES_WHITELIST
* Remove some remnants of multi-OS support: always false conditions and
unused variables ($automan, $autoinfo, $manstrict, $mancompress,
$multiplist, $newxdef, $rcsidinplist, $ldconfigwithtrue)
* Remove check for USE_SIZE
* Remove check for 'Version Required' in header
* Remove pkgtools remnants: fix pkg_version invocations,
remove check for PKGINSTALLVER, remove check for old packages in $portsdir
* Update check for IGNOREFILES macro
* Remove comment about EXEC_DEPENDS
* Remove check for NO_CONFIGURE/NO_PATCH
* Remove '@dirrm for %%DOCSDIR%%' check
* Remove pkg-comment check
* Remove check for /usr/X11R6
* Remove check for gcc_val 3.x and 4.1 conditions
* STAGE is now required
* Remove MANLANG check
* Add NOPORTEXAMPLES/NOPORTDOCS deprecation warning
* Add @stopdaemon, @cwd deprecation warning
* Add PLIST_DIRSTRY deprecation warning
* Add check for make :L :U modifiers
* Add check for for MAN[1-9] macro
* Allow use of absolute path in plist
* Fix checks for EXTRACT_SUFX
* Fix USE_ANT and USES=gmake warning
* Convert WITH(OUT)_$1 to PORT_OPTIONS:M$1 in warning
* Convert USE_DOS2UNIX to USES=dos2unix in warning
* Convert USE_ZIP to USES=zip in EXTRACT_SUFX check
* Convert USE_PERL5 to USES=perl5 in warning
* Convert USE_ICONV to USES=iconv in warning
* Modify checkplist() to accept @fc/@shell/other new keywords
PR: 194285
Submitted by: ak
* Do not report on DEBUG as an OPTION. [1]
* Check for use of muted INSTALL_foo commands.
* Warn on use of @dirrm[try].
* Check to make sure rc.d scripts contain a '# PROVIDE:' line. [2]
* Check to see that the options provided to USES are sorted. [3]
* Fix an errant "direct use of command" warning. [4]
* Remove the check to see if StartupNotify is the empty string in
DESKTOP_ENTRIES. This is allowed per the spec and per the porter's
handbook. [5]
* Check for empty lines in plist. [6]
* Check for direct command use in SHEBANG_FILES. [7]
PR: 192525 [1]
193464 [2]
193792 [3]
193793 [4]
193456 [5]
193794 [6]
193795 [7]
* Make sure a port is placed in its proper category directory. [1]
* Don't check INSTALL_TARGET for direct command use. [2]
* Remove the single MASTER_SITE warning. [3]
* Check to make sure patch file names contain no more than 100 characters. [4]
PR: 191631 [2]
191079 [3]
Submitted by: wen heping <wenheping@gmail.com> [1]
gerald [2]
Requested by: demon [4]
Discussed on: ports@ [3]
* Add s3.amazonaws.com to the list of whitelist master sites. [1]
* Correct a typo. [2]
* Add support for the @sample directive. [3]
* Check for USE_AUTOTOOLS=libtool and suggest USES=libtool instead.
PR: 183864 [3]
Submitted by: skreuzer [1]
culot [2]
* Remove www.freebsd.org/~$user check from urlcheck()
* Remove 'in the module alias name' warning
* Remove 'binary -ko'
* Silence warnings in case if svn binary does not exist (try 2)
* Use more strict regexp for share/doc detection
* Add sdl-config to direct commands check
* Fix phase 2 of direct use of pathnames check
* Ignore comments in direct use of pathnames check
* Support nested knobs in plist for OPTIONS_SUB check
* Add check for @dirrm(try) libdata/pkgconfig in plist
* Remove USE_MESA, INSTALLS_SHLIB, APACHE_COMPAT, USE_XPM from deprecated
macro check
* Fix 'Consider adding support for a NLS knob to conditionally disable gettext'
warning in the case of use 'NLS_USES= gettext'
PR: 188389
Submitted by: ak
- Remove NetBSD support, its completely bitrotted
- Suggest to set DEVELOPER=yes in /etc/make.conf if committer flag specified in command line
- Fix WARN: Makefile: [11]: possible direct use of command "libtool" found...
- Small fixes:
* 'WWW: UR:' -> 'WWW: URL'
* @option_helpers -> remove leading '_' use _$m instead
* fix a few 'undefined variable' warnings
- Make MAN{X} checks NO_STAGE only (consolidate/simplify check)
- Make some checks in checkplist NO_STAGE only
- Convert PERL_CONFIGURE check to USE_PERL5=configure
- Make "use .if ${PORT_OPTIONS:MDOCS} to wrap installation of files into
$localbase/share/doc" warning NO_STAGE only
- Add special case for global options(DOCS/EXAMPLES/NLS/IPV6) in
OPTIONS_DEFINE, but not in PORT_OPTIONS:M$i
- Check for relative path (/../) in *DEPENDS
- Remove MASTER_SITES that don't resolve or returns 5xx
- Remove LINTSKIP check that was commented since 1997
PR: 186639
Submitted by: ak
