restoring that in the new code to add a safety belt that came in via
revision 477561. This is quite a bit simpler and shorter.
Reported by: adamw
PR: 226926
PORTREVISION (using the Ports Collection framework, not just looking at
one Makefile individually at a time) before and after the bump. If the
version after the bump isn't actually increased, flag that as an error.
As an example, before revision r464215 (cf. bug #226533) this script
would have wreaked wreak havoc on the multimedia/avidemux* ports.
This hardly can be blamed on bump-revision.sh, but with the additional
safety belt it does now detect such cases.
How to reproduce:
% cd $PORTSDIR
% svn up -r 464036 multimedia/
% Tools/scripts/bump-revision.sh multimedia/avidemux*
With this patch we print:
INFO: multimedia/avidemux PORTREVISION= 9 found, bumping it by 1.
INFO: multimedia/avidemux-cli PORTREVISION not found, adding PORTREVISION= 1
ERROR: multimedia/avidemux-cli PORTREVISION went backwards from 5 to 1!
INFO: multimedia/avidemux-plugins PORTREVISION not found, adding PORTREVISION= 1
ERROR: multimedia/avidemux-plugins PORTREVISION went backwards from 5 to 1!
INFO: multimedia/avidemux-qt4 PORTREVISION not found, adding PORTREVISION= 1
ERROR: multimedia/avidemux-qt4 PORTREVISION went backwards from 5 to 1!
The beauty of this approach is that it goes beyond a simple text search,
and leverages what the ports framework itself does.
PR: 226926, 226533
Approved by: maintainer timeout (20+ weeks)
Reviewed by: mandree, riggs
This is because half of the time, the previous line is the one that is
wrong, so you get redirected to line X, where X-1 has the error, and you
wonder because line X looks just fine.
Sponsored by: Absolight
SC2068: Double quote array expansions to avoid re-splitting elements.
SC2034: revs appears unused. Verify it or export it.
SC2039: In POSIX sh, XXX is undefined.
type -> command -v
echo -n -> printf
read -p -> printf + read
SC2162: read without -r will mangle backslashes.
SC2086: Double quote to prevent globbing and word splitting.
Sponsored by: Absolight
- Enable FLAVORS.
- Make make describe flavors aware.
- Add a qa check for unique package names amongst flavors.
- Make MOVEDlint understand flavors.
- Add a bit of sanity check to make sure FLAVORS stay lowercase.
- Various fixes.
Reviewed by: portmgr
Sponsored by: Absolight
Differential Revision: https://reviews.freebsd.org/D12577
ak@ asked that I remove the unused error array, and I went to have a
look at what it was actually used for back in the day. It seemed better
to re-enable the blame feature instead of removing it.
Sponsored by: Absolight
This now warns about these 2 ports as needing to be marked as resurrected:
archivers/brotli|archivers/py-brotli|2016-11-24|Brotli is a python module
devel/libbrotli|archivers/brotli|2017-07-12|meta project no longer required to build libs
www/rubygem-jquery-rails||2017-01-07|Has expired: Depends on deprecated www/rubygem-railties
www/rubygem-jquery-rails4|www/rubygem-jquery-rails|2017-03-27|Remove PKGNAMESUFFIX
bsd.default-versions.mk can rely on ARCH being defined.
- In bsd.port.mk move inclusion of bsd.default-versions.mk from the
pre-makefile section to the options section so the variables can be used
earlier. Also put the bit of code sitting between the options section and
the pre-makefile section into the options section.
- Remove last few cases where ports set WITH_OPENSSL_PORT. This variable is
handled in bsd.default-versions.mk and some ports were setting it after
including bsd.port.options.mk. After FreeBSD 9 EoL all but a few ports,
and then only when setting non-default options, work without setting that
variable.
PR: 215996
Exp-run by: antoine
Approved by: portmgr (antoine)
Summary:
Currently addport -a ends up running a command line like:
make PORTSDIR="/tmp/ap.BsOuZJBy" clean check-categories
where the temporary directory has only parts of the ports tree
(specifically bits under ${PORTSDIR}/Mk) checked out. This can't work
as 'make check-categories' needs to see the entire ports tree checked
out.
Instead, run the checks specified by '-a' and '-t' with the value of
$PORTSDIR from the environment.
Reviewers: crees
Reviewed By: crees
Subscribers: mat
Differential Revision: https://reviews.freebsd.org/D7525
the case $? needs to have the exit status of the grep, not the awk line,
so remove the awk line, it was not really helpful anyway.
Also, with slave ports, most of the time, they don't have
(PORT|DIST)VERSION, try to use CATEGORIES, PKGNAMEPREFIX or
PKGNAMESUFFIX.
PR: 211243
Submitted by: mat
Approved by: maintainer timeout
Sponsored by: Absolight
- allow PORTSDIR to be a symbolic link when looking for expired ports or
dependent ports
- allow for trailing slashes when specifying ports as cat/name. This prevents
the port being a false positive for itself when the Makefile mentions the
port name (e.g., in PLIST_FILES)
- fetch possibly open PRs via Bugzilla, GNATS is long gone. Remove the
version that used freefall. Thanks to crees for pretty-printing the results.
- forcibly delete the temporary checkout to prevent rm(1) from asking for
confirmation on each file in .svn
- add myself as author
Approved by: maintainer (crees)
Differential Revision: https://reviews.freebsd.org/D6396
While there replace USE_SQLITE=x by USES=sqlite:x.
PR: 208971
Submitted by: mat
Exp-run by: antoine
With hat: portmgr
Sponsored by: Absolight
Differential Revision: https://reviews.freebsd.org/D5951
If portmgr@ needs to commit against better advise, two years after this was
first discussed without any motion of the upstream.
Drop a few more maintainerships along the way.
The last change was flawed; for deleted ports it was writing out the
origin, but it should be writing out the appropriate ports cache
database directory.
The redundant-opt-file scripts assumes that if options are cached,
then the port that it was created by still exists. This, of course, is
a terrible assumption.
If the cached options refer to a port that has since been deleted or
otherwise no longer exists, just print the origin and continue. The
normal use case is that the origin will be piped to xargs rm -rf which
will purge the obsolete directory as desired.
