Currently, when running mfh with a flag like --help the user gets
a confusing error message from expr(1) like the following:
> expr: illegal option -- -
> expr: usage: expr [-e] expression
>
> revision "--help" should be a number
This is not helpful. Instead, make sure that any arguments specified by the
user are handled properly by expr(1). This results in a much cleaner error
message:
> revision "--help" should be a number
Reviewed by: mat
Approved by: portmgr (mat)
Differential Revision: https://reviews.freebsd.org/D25958
- remove unused clean() function, trap does it
- fix race around mktemp/setting up rm trap
- rename filelist to dirlist so it matches its purpose
- move defaults up front to the script
- misc. minor edits
PR: 246336
Approved by: portmgr (mat@)
Differential Revision: https://reviews.freebsd.org/D24789
- use env -S to split the shebang line (RhToad@#bsdports)
- launder -p PORTSDIR argument and chdir to it so it doesn't matter
which cwd bump_revision.pl is executed from
- if INDEX not found, hint the user that also his -p option might be off,
because the -i INDEX option defaults to a file relative to -p PORTSDIR.
The original wording was misleading and might have mistaken for
identical file names, but what is meant is that the sed run did not
introduce changes to the file's __content__. Reword accordingly.
- When using a non-default ports tree (-p PATH),
strip that from the requisite origins, too.
- Fix the counters when multiple ports are given on the command line,
i. e. we are bumping depends if more requisites are updated at once.
Key features:
- updated for SVN (the old version expected CVS)
- shallow mode to only bump direct dependencies (option -l)
PR: 192706
Submitted by: mandree@ (new maintainer)
we've been having after I was planning to EOL it last year and a nice
revamp of this script he has prepared.
Thank you for taking this over, and good luck, Matthias!
PR: 192706
Just execute it in the root of you ports with e.g.
Tools/scripts/search_lib_depends_and_bump.sh devel/libgit2
This will search over all existing ports, check if they need to be bumped.
After all ports are bumped it triggers a portlint for each modified port.
The portlint loop continues till all errors and warnings are fixed.
Feel free to break this loop using CTRL+C.
find_expired() is used with -F (report on all expired ports using the
format "date category/port: reason") and -a (remove all expired ports).
Some speedups:
- only calculate the deprecation reason for -F
- use nested loops instead of nested recursion for traversing all ports.
The nested recursion would also stop after finding the first port.
Approved by: maintainer (crees) (implicit, fixit)
Instead of grepping port Makefiles for EXPIRATION_DATE, evaluate this variable
using make. Also find ports by evaluating SUBDIR recursively instead of using
find on Makefile\*
Submitted by: crees (maintainer)
Approved by: crees (maintainer)
restoring that in the new code to add a safety belt that came in via
revision 477561. This is quite a bit simpler and shorter.
Reported by: adamw
PR: 226926
PORTREVISION (using the Ports Collection framework, not just looking at
one Makefile individually at a time) before and after the bump. If the
version after the bump isn't actually increased, flag that as an error.
As an example, before revision r464215 (cf. bug #226533) this script
would have wreaked wreak havoc on the multimedia/avidemux* ports.
This hardly can be blamed on bump-revision.sh, but with the additional
safety belt it does now detect such cases.
How to reproduce:
% cd $PORTSDIR
% svn up -r 464036 multimedia/
% Tools/scripts/bump-revision.sh multimedia/avidemux*
With this patch we print:
INFO: multimedia/avidemux PORTREVISION= 9 found, bumping it by 1.
INFO: multimedia/avidemux-cli PORTREVISION not found, adding PORTREVISION= 1
ERROR: multimedia/avidemux-cli PORTREVISION went backwards from 5 to 1!
INFO: multimedia/avidemux-plugins PORTREVISION not found, adding PORTREVISION= 1
ERROR: multimedia/avidemux-plugins PORTREVISION went backwards from 5 to 1!
INFO: multimedia/avidemux-qt4 PORTREVISION not found, adding PORTREVISION= 1
ERROR: multimedia/avidemux-qt4 PORTREVISION went backwards from 5 to 1!
The beauty of this approach is that it goes beyond a simple text search,
and leverages what the ports framework itself does.
PR: 226926, 226533
Approved by: maintainer timeout (20+ weeks)
Reviewed by: mandree, riggs
This is because half of the time, the previous line is the one that is
wrong, so you get redirected to line X, where X-1 has the error, and you
wonder because line X looks just fine.
Sponsored by: Absolight
SC2068: Double quote array expansions to avoid re-splitting elements.
SC2034: revs appears unused. Verify it or export it.
SC2039: In POSIX sh, XXX is undefined.
type -> command -v
echo -n -> printf
read -p -> printf + read
SC2162: read without -r will mangle backslashes.
SC2086: Double quote to prevent globbing and word splitting.
Sponsored by: Absolight
- Enable FLAVORS.
- Make make describe flavors aware.
- Add a qa check for unique package names amongst flavors.
- Make MOVEDlint understand flavors.
- Add a bit of sanity check to make sure FLAVORS stay lowercase.
- Various fixes.
Reviewed by: portmgr
Sponsored by: Absolight
Differential Revision: https://reviews.freebsd.org/D12577
