cpet/freebsd-ports
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

www/py-soupsieve: Add missing dependency

Browse Source 
soupsieve depends on backports.functools_lru_cache [1] on Python versions <
3, add the dependency accordingly.

While I'm here:

 - Add TEST_DEPENDS and test target to improve future QA

Note: soupsieve 'requires' [2] beautifulsoup4, but beautifulsoup4 depends
      on soupsieve via install_requires, causing a technical circular
      dependency, which is why soupsieve doesn't seem to explicitly
      install_requires on it ... anymore [3]. This seems bizzare.

[1] requirements/project.txt: backports.functools_lru_cache ; python_version < '3'
[2] https://github.com/facelessuser/soupsieve#installation
[3] 9a792216ea

QA: 624 passed, 2 skipped, 6 warnings in 35.70 seconds

PR:		240490
Reported by:	jbeich
Approved by:	portmgr (blanket: missing dependencies, ports compliance)
MFH:		2019Q3 (blanket(s): run-time bugfix)
This commit is contained in:
Kubilay Kocak 2019-09-11 11:04:07 +00:00
parent 4d9249ff60
commit f69808be48
Notes: svn2git 2021-03-31 03:12:20 +00:00 
svn path=/head/; revision=511814
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
www/py-soupsieve/Makefile
View File

@ -2,6 +2,7 @@
PORTNAME= soupsieve
PORTVERSION= 1.9
PORTREVISION= 1
CATEGORIES= www python
MASTER_SITES= CHEESESHOP
PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
@ -12,8 +13,23 @@ COMMENT= CSS4 selector implementation for BeautifulSoup
LICENSE= MIT
LICENSE_FILE= ${WRKSRC}/LICENSE.md
TEST_DEPENDS= ${PYTHON_PKGNAMEPREFIX}pytest>0:devel/py-pytest@${PY_FLAVOR} \
${PYTHON_PKGNAMEPREFIX}html5lib>0:www/py-html5lib@${PY_FLAVOR} \
${PYTHON_PKGNAMEPREFIX}lxml>0:devel/py-lxml@${PY_FLAVOR} \
${PYTHON_PKGNAMEPREFIX}beautifulsoup>4:www/py-beautifulsoup@${PY_FLAVOR}
USES= python
USE_PYTHON= autoplist concurrent distutils
NO_ARCH= yes
.include <bsd.port.mk>
.include <bsd.port.pre.mk>
.if ${PYTHON_VER} < 3
RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}backports.functools_lru_cache>0:devel/py-backports.functools_lru_cache@${PY_FLAVOR}
.endif
do-test:
cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -v -rs
.include <bsd.port.post.mk>