science/massxpert: Fix two logical errors (found by gcc5)

There were two boolean logic issues found by gcc5 when compiling
massxpert.  One was comparing boolean output to a negative integer
(is always false) and the other applied the "not" operator in the wrong
place.  Fix provided per request by maintainer.

PR:	197823
This commit is contained in:
John Marino 2015-03-22 00:06:34 +00:00
parent c97c789ce0
commit 94c5d47dac
Notes: svn2git 2021-03-31 03:12:20 +00:00
svn path=/head/; revision=381882
3 changed files with 24 additions and 2 deletions

View File

@ -3,12 +3,12 @@
PORTNAME= massxpert
PORTVERSION= 3.4.0
PORTREVISION= 2
PORTREVISION= 3
CATEGORIES= science
MASTER_SITES= http://download.tuxfamily.org/massxpert/source/
MAINTAINER= vg@FreeBSD.org
COMMENT= The massXpert software for (bio)chemists
COMMENT= massXpert software for (bio)chemists
LICENSE= GPLv3

View File

@ -0,0 +1,11 @@
--- lib/cleaveSpec.cpp.orig 2012-12-25 21:02:43 UTC
+++ lib/cleaveSpec.cpp
@@ -427,7 +427,7 @@ namespace massXpert
return false;
- if (parse() == -1)
+ if (parse() == false)
return false;
// If there are rules, we have to check them all.

View File

@ -0,0 +1,11 @@
--- plugins-src/seqToolsPlugin/seqToolsPluginDlg.cpp.orig 2012-12-25 21:02:43 UTC
+++ plugins-src/seqToolsPlugin/seqToolsPluginDlg.cpp
@@ -215,7 +215,7 @@ SeqToolsPluginDlg::loadDictionary ()
QStringList stringList = line.split (">", QString::SkipEmptyParts);
- if (!stringList.size () == 2)
+ if (stringList.size () != 2)
{
QMessageBox::warning (this,
tr ("Sequence Manipulation Tools Plugin"),