MFH: r503168 security/py-fail2ban: Fix rc script

The rc.d script evaluates fail2ban_pidfile before rc.conf is read.

This change moves those evaluations to the corect place allowing
users to override the values via /etc/rc.conf as expected.

PR:		236017
Reported by:	<epopen gmail com>, Dmitry Wagin <dmitry.wagin ya ru>
Submitted by:	<theis gmx at> (maintainer)

Approved by:	ports-secteam (blanket: bugfix)

security/py-fail2ban/Makefile

@@ -2,6 +2,7 @@
 
 PORTNAME=	fail2ban
 PORTVERSION=	0.10.4
+PORTREVISION=	1
 CATEGORIES=	security python
 PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
 

security/py-fail2ban/files/fail2ban.in

@@ -8,14 +8,10 @@
 # fail2ban_enable="YES"
 # fail2ban_flags="<set as needed>"
 
-fail2ban_enable=${fail2ban_enable-"NO"}
-fail2ban_pidfile=${fail2ban_pidfile-"/var/run/fail2ban/fail2ban.pid"}
-
 . /etc/rc.subr
 
 name="fail2ban"
 rcvar=fail2ban_enable
-pidfile="${fail2ban_pidfile}"
 
 command="%%PREFIX%%/bin/fail2ban-server"
 command_interpreter="%%PYTHON_CMD%%"
@@ -25,6 +21,14 @@ extra_commands="reload jailstatus"
 
 load_rc_config ${name}
 
+#
+# DO NOT CHANGE THESE DEFAULT VALUES HERE
+# SET THEM IN THE /etc/rc.conf FILE
+#
+
+fail2ban_enable=${fail2ban_enable-"NO"}
+pidfile=${fail2ban_pidfile-"/var/run/fail2ban/fail2ban.pid"}
+
 start_cmd="${client} ${fail2ban_flags} start"
 stop_cmd="${client} ${fail2ban_flags} stop"
 reload_cmd="${client} ${fail2ban_flags} reload"