cpet/freebsd-ports
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

- Add patch to fix security issue in magnatunebrowser

Browse Source 
More info here: http://bugs.kde.org/show_bug.cgi?id=138499
This commit is contained in:
Michael Landin 2007-02-18 11:20:25 +00:00
parent 6aabd0d3ea
commit 28b0f721f5
Notes: svn2git 2021-03-31 03:12:20 +00:00 
svn path=/head/; revision=185428
4 changed files with 60 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
audio/amarok-kde4/Makefile
View File

@ -6,7 +6,7 @@
PORTNAME= amarok
PORTVERSION= 1.4.5
PORTREVISION= 1
PORTREVISION= 2
CATEGORIES= audio kde
MASTER_SITES= ${MASTER_SITE_KDE}
MASTER_SITE_SUBDIR= stable/${PORTNAME}/${PORTVERSION}/src

29
audio/amarok-kde4/files/patch-amarok_src_magnatunebrowser_magnatunealbumdownloader.cpp Normal file
View File

@ -0,0 +1,29 @@
$FreeBSD$
--- amarok/src/magnatunebrowser/magnatunealbumdownloader.cpp.orig
+++ amarok/src/magnatunebrowser/magnatunealbumdownloader.cpp
@@ -89,19 +89,19 @@
//ok, now we have the .zip file downloaded. All we need is to unpack it to the desired location and add it to the collection.
- QString unzipString = "unzip \""+m_tempDir.name() + m_currentAlbumFileName + "\" -d \"" + m_currentAlbumUnpackLocation + "\" &";
+ QString unzipString = "unzip "+ KProcess::quote( m_tempDir.name() + m_currentAlbumFileName) + " -d " +KProcess::quote( m_currentAlbumUnpackLocation ) + " &";
debug() << "unpacking: " << unzipString << endl;
system( unzipString.ascii() );
-
+
if (m_currentAlbumId != -1 ) {
- //now I really want to add the album cover to the same folder where I just unzipped the album... The
+ //now I really want to add the album cover to the same folder where I just unzipped the album... The
//only way of getting the actual location where the album was unpacked is using the artist and album names
-
+
MagnatuneAlbum album = MagnatuneDatabaseHandler::instance()->getAlbumById( m_currentAlbumId );
MagnatuneArtist artist = MagnatuneDatabaseHandler::instance()->getArtistById( album.getArtistId() );

2
audio/amarok/Makefile
View File

@ -6,7 +6,7 @@
PORTNAME= amarok
PORTVERSION= 1.4.5
PORTREVISION= 1
PORTREVISION= 2
CATEGORIES= audio kde
MASTER_SITES= ${MASTER_SITE_KDE}
MASTER_SITE_SUBDIR= stable/${PORTNAME}/${PORTVERSION}/src

29
audio/amarok/files/patch-amarok_src_magnatunebrowser_magnatunealbumdownloader.cpp Normal file
View File

@ -0,0 +1,29 @@
$FreeBSD$
--- amarok/src/magnatunebrowser/magnatunealbumdownloader.cpp.orig
+++ amarok/src/magnatunebrowser/magnatunealbumdownloader.cpp
@@ -89,19 +89,19 @@
//ok, now we have the .zip file downloaded. All we need is to unpack it to the desired location and add it to the collection.
- QString unzipString = "unzip \""+m_tempDir.name() + m_currentAlbumFileName + "\" -d \"" + m_currentAlbumUnpackLocation + "\" &";
+ QString unzipString = "unzip "+ KProcess::quote( m_tempDir.name() + m_currentAlbumFileName) + " -d " +KProcess::quote( m_currentAlbumUnpackLocation ) + " &";
debug() << "unpacking: " << unzipString << endl;
system( unzipString.ascii() );
-
+
if (m_currentAlbumId != -1 ) {
- //now I really want to add the album cover to the same folder where I just unzipped the album... The
+ //now I really want to add the album cover to the same folder where I just unzipped the album... The
//only way of getting the actual location where the album was unpacked is using the artist and album names
-
+
MagnatuneAlbum album = MagnatuneDatabaseHandler::instance()->getAlbumById( m_currentAlbumId );
MagnatuneArtist artist = MagnatuneDatabaseHandler::instance()->getArtistById( album.getArtistId() );