cpet/freebsd-ports
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

editors/madedit: unbreak with clang 4.0

Browse Source 
src/MadOptionsDialog.cpp:1179:56: error: ordered comparison between pointer and zero
      ('const wxChar *' (aka 'const wchar_t *') and 'int')
        if(g_SelectedCommandItem->cmddata->menuid_name > 0)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
src/MadOptionsDialog.cpp:1277:42: error: ordered comparison between pointer and zero
      ('const wxChar *' (aka 'const wchar_t *') and 'int')
            if(tid->cmddata->menuid_name > 0)
               ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~

PR:		216076
Reported by:	antoine (via exp-run)
This commit is contained in:
Jan Beich 2017-02-01 05:25:42 +00:00
parent 5416909df8
commit 081cece7ff
Notes: svn2git 2021-03-31 03:12:20 +00:00 
svn path=/head/; revision=432971
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
editors/madedit/files/patch-src_MadOptionsDialog.cpp Normal file
View File

@ -0,0 +1,20 @@
--- src/MadOptionsDialog.cpp.orig 2017-02-01 03:37:19 UTC
+++ src/MadOptionsDialog.cpp
@@ -1176,7 +1176,7 @@ void MadOptionsDialog::WxTreeCtrl1SelCha
{
WxListBoxKeys->Set(g_SelectedCommandItem->keys);
wxString hint=wxT('[');
- if(g_SelectedCommandItem->cmddata->menuid_name > 0)
+ if(g_SelectedCommandItem->cmddata->menuid_name)
{
hint+= wxString(g_SelectedCommandItem->cmddata->menuid_name);
}
@@ -1274,7 +1274,7 @@ void MadOptionsDialog::UpdateKeyHint()
g_CommandItemOfNewKey=tid;
wxString cmd;
- if(tid->cmddata->menuid_name > 0)
+ if(tid->cmddata->menuid_name)
{
cmd+= wxString(tid->cmddata->menuid_name);
}