Nested ifs are a mess

This commit is contained in:
camoy 2024-08-15 20:39:45 -07:00
parent c483cbf687
commit e1471191d4

View File

@ -3,27 +3,12 @@ Function fDefaultGatewayCheck() {
Get-WmiObject -Class Win32_IP4RouteTable | where { $_.destination -eq '0.0.0.0' -and $_.mask -eq '0.0.0.0' } | Sort-Object nexthop, metric1, interfaceindex
$vSCNextHop = (Get-WmiObject -Class Win32_IP4RouteTable | where { $_.destination -eq '0.0.0.0' -and $_.mask -eq '0.0.0.0' } | Sort-Object metric1 | select nexthop | Format-Wide | Out-String).trim()
Test-Connection $vSCNextHop
$vSCNextHopResult = $?
}
fDefaultGatewayCheck
if ($? -eq $false)
{
Write-Host "SC-NET-ERR001: CANNOT PING DEFAULT GATEWAY"
Write-Host "Please check network connection"
Write-Host "If you would like to [F]orcefully continue, connect a keyboard and type F"
Write-Host "If you would like to run this test [A]gain, connect a keyboard and type A"
$vSCNextHopUserResponse = Read-Host "F / A?"
if ($vSCNextHopUserResponse -contains "A")
{
fDefaultGatewayCheck
}
else
{
fDNSResolutionCheck
}
}
else
{
Function fDNSResolutionCheck() {
Function fDNSResolutionCheck() {
Write-Host "---Testing DNS Resolution---"
Resolve-DnsName -Name "git.sdf.org"
$vSCDNSResolutionTestResult1 = $?
@ -40,7 +25,24 @@ fDefaultGatewayCheck
Resolve-DnsName -Name "7-zip.org"
$vSCDNSResolutionTestResult7 = $?
$vSCDNSResolutionTestResultArray = @($vSCDNSResolutionTestResult1,$vSCDNSResolutionTestResult2,$vSCDNSResolutionTestResult3,$vSCDNSResolutionTestResult4,$vSCDNSResolutionTestResult5,$vSCDNSResolutionTestResult6,$vSCDNSResolutionTestResult7)
if ($vSCDNSResolutionTestResultArray -contains $false)
}
fDNSResolutionCheck
if ($vSCNextHopResult -contains $false)
{
Write-Host "SC-NET-ERR001: CANNOT PING DEFAULT GATEWAY"
Write-Host "Please check network connection"
Write-Host "If you would like to [F]orcefully continue, connect a keyboard and type F"
Write-Host "If you would like to run this test [A]gain, connect a keyboard and type A"
$vSCNextHopUserResponse = Read-Host "F / A?"
if ($vSCNextHopUserResponse -contains "A")
{
fDefaultGatewayCheck
}
}
if ($vSCDNSResolutionTestResultArray -contains $false)
{
Write-Host "SC-NET-ERR002: CANNOT RESOLVE DNS"
Write-Host "Please check your DNS server. Sweetcade cannot continue with a broken DNS server."
@ -52,5 +54,3 @@ fDefaultGatewayCheck
{
Exit 0
}
}
}