aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-07-26 11:04:33 -04:00
Code

patch 8.2.2069: the quickfix window is not updated after setqflist()

Browse Source 
Problem:    The quickfix window is not updated after setqflist().
Solution:   Update the quickfix buffer. (Yegappan Lakshmanan, closes #7390,
            closes #7385)
This commit is contained in:
Bram Moolenaar 2020-11-29 14:20:27 +01:00
parent b46f57e87b
commit 287153c5d4
3 changed files with 64 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/quickfix.c
View File

@ -7349,7 +7349,7 @@ qf_setprop_items_from_lines(
if (action == 'r')
qf_free_items(&qi->qf_lists[qf_idx]);
if (qf_init_ext(qi, qf_idx, NULL, NULL, &di->di_tv, errorformat,
FALSE, (linenr_T)0, (linenr_T)0, NULL, NULL) > 0)
FALSE, (linenr_T)0, (linenr_T)0, NULL, NULL) >= 0)
retval = OK;
return retval;
@ -7474,8 +7474,10 @@ qf_set_properties(qf_info_T *qi, dict_T *what, int action, char_u *title)
if ((di = dict_find(what, (char_u *)"quickfixtextfunc", -1)) != NULL)
retval = qf_setprop_qftf(qi, qfl, di);
if (retval == OK)
if (newlist || retval == OK)
qf_list_changed(qfl);
if (newlist)
qf_update_buffer(qi, NULL);
return retval;
}

58
src/testdir/test_quickfix.vim
View File

@ -5253,4 +5253,62 @@ func Test_quickfix_window_fails_to_open()
call delete('XquickfixFails')
endfunc
" Test for updating the quickfix buffer whenever the assocaited quickfix list
" is changed.
func Xqfbuf_update(cchar)
call s:setup_commands(a:cchar)
Xexpr "F1:1:line1"
Xopen
call assert_equal(['F1|1| line1'], getline(1, '$'))
call assert_equal(1, g:Xgetlist({'changedtick' : 0}).changedtick)
" Test setqflist() using the 'lines' key in 'what'
" add a new entry
call g:Xsetlist([], 'a', {'lines' : ['F2:2: line2']})
call assert_equal(['F1|1| line1', 'F2|2| line2'], getline(1, '$'))
call assert_equal(2, g:Xgetlist({'changedtick' : 0}).changedtick)
" replace all the entries with a single entry
call g:Xsetlist([], 'r', {'lines' : ['F3:3: line3']})
call assert_equal(['F3|3| line3'], getline(1, '$'))
call assert_equal(3, g:Xgetlist({'changedtick' : 0}).changedtick)
" remove all the entries
call g:Xsetlist([], 'r', {'lines' : []})
call assert_equal([''], getline(1, '$'))
call assert_equal(4, g:Xgetlist({'changedtick' : 0}).changedtick)
" add a new list
call g:Xsetlist([], ' ', {'lines' : ['F4:4: line4']})
call assert_equal(['F4|4| line4'], getline(1, '$'))
call assert_equal(1, g:Xgetlist({'changedtick' : 0}).changedtick)
" Test setqflist() using the 'items' key in 'what'
" add a new entry
call g:Xsetlist([], 'a', {'items' : [{'filename' : 'F5', 'lnum' : 5, 'text' : 'line5'}]})
call assert_equal(['F4|4| line4', 'F5|5| line5'], getline(1, '$'))
call assert_equal(2, g:Xgetlist({'changedtick' : 0}).changedtick)
" replace all the entries with a single entry
call g:Xsetlist([], 'r', {'items' : [{'filename' : 'F6', 'lnum' : 6, 'text' : 'line6'}]})
call assert_equal(['F6|6| line6'], getline(1, '$'))
call assert_equal(3, g:Xgetlist({'changedtick' : 0}).changedtick)
" remove all the entries
call g:Xsetlist([], 'r', {'items' : []})
call assert_equal([''], getline(1, '$'))
call assert_equal(4, g:Xgetlist({'changedtick' : 0}).changedtick)
" add a new list
call g:Xsetlist([], ' ', {'items' : [{'filename' : 'F7', 'lnum' : 7, 'text' : 'line7'}]})
call assert_equal(['F7|7| line7'], getline(1, '$'))
call assert_equal(1, g:Xgetlist({'changedtick' : 0}).changedtick)
call g:Xsetlist([], ' ', {})
call assert_equal([''], getline(1, '$'))
call assert_equal(1, g:Xgetlist({'changedtick' : 0}).changedtick)
Xclose
endfunc
func Test_qfbuf_update()
call Xqfbuf_update('c')
call Xqfbuf_update('l')
endfunc
" vim: shiftwidth=2 sts=2 expandtab

2
src/version.c
View File

@ -750,6 +750,8 @@ static char *(features[]) =
static int included_patches[] =
{ /* Add new patch number below this line */
/**/
2069,
/**/
2068,
/**/