Become a more Fedora-style spec file

trader.spec

@@ -12,43 +12,62 @@
 # the GNU General Public License, version 3 or later.
 
 %define real_version 7.4-pre2
+%define fake_version 7.3.99.2
+%define is_prerelease yes
 
 Name:           trader
-#Version:        %{real_version}
-Version:        7.3.99.2
+
+%if %{is_prerelease} = yes
+Version:        %{fake_version}
+Source0:        ftp://ftp.zap.org.au/pub/trader/unix/prerelease/trader-%{real_version}.tar.gz
+%else
+Version:        %{real_version}
+Source0:        ftp://ftp.zap.org.au/pub/trader/unix/trader-%{version}.tar.bz2
+%endif
+
 Release:        1%{?dist}
 Summary:        Star Traders, a simple game of interstellar trading
-License:        GPL-3.0+
-Group:          Amusements/Games/Other
+License:        GPLv3+
+Group:          Amusements/Games
 URL:            http://www.zap.org.au/software/trader/
-#Source0:        ftp://ftp.zap.org.au/pub/trader/unix/trader-%{real_version}.tar.bz2
-Source0:        ftp://ftp.zap.org.au/pub/trader/unix/prerelease/trader-%{real_version}.tar.gz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-build
+BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-build
 BuildRequires:  ncurses-devel
 BuildRequires:  gperf
 BuildRequires:  gettext
 
+
 %description
 Star Traders is a simple game of interstellar trading, where the objective
 is to create companies, buy and sell shares, borrow and repay money, in
 order to become the wealthiest player (the winner).
 
+
 %prep
 %setup -q -n %{name}-%{real_version}
 
+
 %build
 %configure
-make %{?_smp_mflags} V=1
+make %{?_smp_mflags}
+
 
 %install
-%makeinstall
+rm -rf %{buildroot}
+make DESTDIR=%{buildroot} install
 %find_lang %{name}
 
+
 %clean
+rm -rf %{buildroot}
+
 
 %files -f %{name}.lang
+%defattr(-,root,root,-)
 %doc COPYING NEWS README
 %doc %{_mandir}/man6/trader.6*
 %{_bindir}/trader
 
+
 %changelog
+* Mon Apr 16 2012 John Zaitseff <J.Zaitseff@zap.org.au> - 7.3.99.2-1
+- Initial RPM package of Star Traders.