1
0
mirror of https://github.com/profanity-im/profanity.git synced 2024-11-03 19:37:16 -05:00
Go to file
Michael Vetter 7ad2e4761b xep-0308: Don't check whether receiving clients supports this feature
XEP-0308 Version 1.1.0 (2019-05-15) states "It is expected that clients will not send message corrections to clients that do not support them, as non-supporting clients will render these as duplicate (corrected) messages"

```
10:12:47 - jubalh: Do clients actually check whether other clients support xep0308 (LMC) before sending?
10:13:13 - pep.: not poezio, and I doubt anybody does. it's the "but carbons/MAM" argument
10:13:49 - jubalh: Profanity doesnt support this yet. So I always get the message twice. One time the message, and then the corrected ones. And I think that's right. But I understood xep0308 correctly it sais a
           client shouldnt sent a message with 'replace' if the client doesnt support it? I don't see why
10:14:50 - Ge0rG: jubalh: because you might also use Conversations and read the backlog from MAM on conversations
10:15:51 - jubalh: Ge0rG: sorry?
10:16:36 - Ge0rG: jubalh: when I'm sending you a message, I don't know which client you'll use to read it. So it doesn't make sense to limit the features I use
10:27:57 - jubalh: Yes. That's why I'm confused by thestatement in the XEP
10:28:13 - jubalh: "It is expected that clients will not send message corrections to clients that do not support them, as non-supporting clients will render these as duplicate (corrected) messages. "
10:28:37 - Holger: Yes, you're both saying the same thing.  And yes I agree, that part of the XEP is nonsense.  We have that "check whether the peer's client supports it" stuff in various XEPs that depend on
           recipient's features and it never makes sense as it doesn't cope with multi-device, MAM, groupchat.
10:28:53 - jubalh: First: You don't know if he is connected with several clients. Some supporting it and some not. Second: Why not just resend the new corrected message? Then he has both messages and no
           information is lost. If he only gets the first one information is lost
10:29:20 - jubalh: Okay
10:29:30 - jubalh: Then I won't implement it this way. Thanks guys!
10:29:34 - Holger: Well UX is a bit meh if the recipient doesn't support it (I'm an MCabber user and know what I'm talking about) but I see no better solution, yes.
```

So it makes more sense to just always send it. Non supporting clients will then get the message and the corrected message. So they get it "twice". Which is the right thing to do in my opinion.
2020-02-12 10:31:12 +01:00
.github Lift 50 issues ban :-) 2020-02-03 16:25:10 +01:00
apidocs Update copyright 2018-01-21 15:00:02 +00:00
docs Possibility to specify alternative config file 2019-08-02 15:55:47 +02:00
icons better, final icons 2016-03-09 12:55:57 +01:00
src xep-0308: Don't check whether receiving clients supports this feature 2020-02-12 10:31:12 +01:00
tests xep-0308: add cons_correction_setting stub to tests 2020-02-10 14:59:10 +01:00
themes xep-0308: make correction.char themeable 2020-02-10 14:58:22 +01:00
.gitignore Add zipfiles to gitignore 2020-02-03 16:25:50 +01:00
.travis.yml Add Travis CI tests for Arch, Debian and OSX/macOS 2019-06-06 13:58:26 +02:00
bootstrap.sh Add Travis CI tests for Arch, Debian and OSX/macOS 2019-06-06 13:58:26 +02:00
Brewfile.travis Add cmocka to brewfile 2019-07-18 09:07:57 +02:00
CHANGELOG Update changelog for 0.8.1 2020-02-07 21:46:16 +01:00
configure-debug Include python plugins by default in build 2016-07-24 01:34:02 +01:00
configure-plugins Added python plugins code 2016-02-24 00:31:55 +00:00
configure.ac Start next development cycle 2020-02-07 21:49:21 +01:00
CONTRIBUTING.md Add CONTRIBUTING.md 2019-07-23 09:25:17 +02:00
COPYING Added GPL 2012-02-20 20:07:38 +00:00
Dockerfile.arch Add Travis CI tests for Arch, Debian and OSX/macOS 2019-06-06 13:58:26 +02:00
Dockerfile.debian Add Travis CI tests for Arch, Debian and OSX/macOS 2019-06-06 13:58:26 +02:00
Dockerfile.tumbleweed Add Travis CI tests for Arch, Debian and OSX/macOS 2019-06-06 13:58:26 +02:00
LICENSE.txt Update copyright years 2019-04-24 01:08:38 +02:00
Makefile.am xep-0084: add test stub file 2019-12-18 15:44:59 +01:00
prof.supp Dirty fix libgcrypt memleak 2019-07-11 14:25:42 +02:00
profanity.spec Release 0.8.1 2020-02-07 21:47:41 +01:00
profrc.example XEP-0392: config: add "color.nick" bool option 2019-12-03 21:10:39 +01:00
README.md Change README formattign 2019-12-18 16:06:42 +01:00
RELEASE_GUIDE.md Update RELEASE_GUIDE.md 2019-12-12 15:05:04 +01:00
theme_template xep-0308: make correction.char themeable 2020-02-10 14:58:22 +01:00
travis-build.sh travis: Update icons switch 2020-02-08 09:28:41 +01:00

Profanity Build Status

Profanity is a console based XMPP client inspired by Irssi.

If you like Profanity consider becoming a sponsor or donate some money.

What goes around comes around!

alt tag

See the User Guide for information on installing and using Profanity.

Homepage: https://profanity-im.github.io/

Mailing List: https://groups.google.com/forum/#!forum/profanitydev

MUC: profanity@rooms.dismail.de

Plugins repository: https://github.com/profanity-im/profanity-plugins