mirror of
https://github.com/profanity-im/profanity.git
synced 2024-06-23 21:45:30 +00:00
62e98dee74
Thanks to @alarixnia fot the patch and bugreport.
```
Forwarding a bug reported using the NetBSD bug tracker ("Profanity crashes at login"): http://gnats.netbsd.org/57050
The code in question here handles messages by people not in the user's contact list, and what is probably happening is that the XMPP server is sending such a message before profanity has set up its window layout.
Setting roster.unsubscribed=false indeed makes profanity start without crashing, and the attached patch bails out early in the problematic code path if layout->subwin is NULL (Adrian verified for me that either of the two makes profanity work for him again). But I am not familiar enough with the profanity code to say if this has any issues.
Profanity compiled with ncurses doesn't crash because ncurses's wattron() has a guard against the user passing null pointers, but the X/Open curses library standard doesn't have this guarantee and there's no guard in the NetBSD curses implementation.
```
Fix https://github.com/profanity-im/profanity/issues/1769
|
||
|---|---|---|
| .. | ||
| buffer.c | ||
| buffer.h | ||
| chatwin.c | ||
| confwin.c | ||
| console.c | ||
| core.c | ||
| inputwin.c | ||
| inputwin.h | ||
| mucwin.c | ||
| notifier.c | ||
| occupantswin.c | ||
| privwin.c | ||
| rosterwin.c | ||
| screen.c | ||
| screen.h | ||
| statusbar.c | ||
| statusbar.h | ||
| titlebar.c | ||
| titlebar.h | ||
| tray.c | ||
| tray.h | ||
| ui.h | ||
| vcardwin.c | ||
| win_types.h | ||
| window_list.c | ||
| window_list.h | ||
| window.c | ||
| window.h | ||
| xmlwin.c | ||