Michael Vetter 07900e9617 Revert "Fix potential double free of ratchet identity key" ... This reverts commit 3b099e9403. This resulted in: ``` ==5285== Invalid read of size 16 ==5285== at 0x4FA80FC: ec_public_key_serialize (in /usr/lib64/libsignal-protocol-c.so.2.3.3) ==5285== by 0x4E5E76: omemo_identity_key (omemo.c:419) ==5285== by 0x4EBB7E: omemo_bundle_publish (omemo.c:129) ==5285== by 0x4E5BD9: omemo_publish_crypto_materials (omemo.c:335) ==5285== by 0x460407: sv_ev_connection_features_received (server_events.c:202) ==5285== by 0x43AA87: connection_features_received (connection.c:779) ==5285== by 0x4418C9: _disco_info_response_id_handler_onconnect (iq.c:2423) ==5285== by 0x43B9F1: _iq_handler (iq.c:241) ==5285== by 0x5163848: ??? (in /usr/lib64/libstrophe.so.0.13.1) ==5285== by 0x516A224: ??? (in /usr/lib64/libstrophe.so.0.13.1) ==5285== by 0x5E4FE43: ??? (in /usr/lib64/libxml2.so.2.12.8) ==5285== by 0x5E54927: xmlParseChunk (in /usr/lib64/libxml2.so.2.12.8) ==5285== by 0x5163450: xmpp_run_once (in /usr/lib64/libstrophe.so.0.13.1) ==5285== by 0x439797: connection_check_events (connection.c:162) ==5285== by 0x43894E: session_process_events (session.c:256) ==5285== by 0x4319FF: prof_run (profanity.c:128) ==5285== by 0x4EDAE6: main (main.c:174) ==5285== Address 0xa1cb1e0 is 16 bytes inside a block of size 72 free'd ==5285== at 0x484875B: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==5285== by 0x4395D0: _xfree (connection.c:110) ==5285== by 0x516A1A7: xmpp_stanza_release (in /usr/lib64/libstrophe.so.0.13.1) ==5285== by 0x516A16C: xmpp_stanza_release (in /usr/lib64/libstrophe.so.0.13.1) ==5285== by 0x516A16C: xmpp_stanza_release (in /usr/lib64/libstrophe.so.0.13.1) ==5285== by 0x516A230: ??? (in /usr/lib64/libstrophe.so.0.13.1) ==5285== by 0x5E4FE43: ??? (in /usr/lib64/libxml2.so.2.12.8) ==5285== by 0x5E54927: xmlParseChunk (in /usr/lib64/libxml2.so.2.12.8) ==5285== by 0x5163450: xmpp_run_once (in /usr/lib64/libstrophe.so.0.13.1) ==5285== by 0x439797: connection_check_events (connection.c:162) ==5285== by 0x43894E: session_process_events (session.c:256) ==5285== by 0x4319FF: prof_run (profanity.c:128) ==5285== by 0x4EDAE6: main (main.c:174) ==5285== Block was alloc'd at ==5285== at 0x4845794: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==5285== by 0x43958A: _xmalloc (connection.c:102) ==5285== by 0x516A0D1: xmpp_stanza_new (in /usr/lib64/libstrophe.so.0.13.1) ==5285== by 0x516BF34: ??? (in /usr/lib64/libstrophe.so.0.13.1) ==5285== by 0x5F10A17: ??? (in /usr/lib64/libxml2.so.2.12.8) ==5285== by 0x5E5481F: xmlParseChunk (in /usr/lib64/libxml2.so.2.12.8) ==5285== by 0x5163450: xmpp_run_once (in /usr/lib64/libstrophe.so.0.13.1) ==5285== by 0x439797: connection_check_events (connection.c:162) ==5285== by 0x43894E: session_process_events (session.c:256) ==5285== by 0x4319FF: prof_run (profanity.c:128) ==5285== by 0x4EDAE6: main (main.c:174) ``` Tested via sending OMEMO messages via 1:1 and in MUC.		2024-06-20 12:41:20 +02:00
..
crypto.c	Include config.h in omemo files	2021-03-26 19:54:04 +01:00
crypto.h	auto-format	2022-02-01 15:01:28 +01:00
omemo.c	Revert "Fix potential double free of ratchet identity key"	2024-06-20 12:41:20 +02:00
omemo.h	Rework OMEMO handling on disconnect	2023-12-12 18:26:21 +01:00
store.c	Rework OMEMO handling on disconnect	2023-12-12 18:26:21 +01:00
store.h	fix memory leaks in OMEMO	2023-01-18 20:11:13 +01:00