1
0
Fork 0
profanity/src/command
ike08 23fa4750ff Fix unable to download item twice
## Summary

Partial fix for https://github.com/profanity-im/profanity/issues/1939  

> When doing the same in an unencrypted (no e2ee) chat there is no Downloading… message at all but the file is downloaded.  

Download a file twice with `/url save`, the second download will not print download progress to the window.  

The cause is `HTTPDownload`'s `silent` variable is not initialized; so, `silent` points to a second-hand stack memory address with old data. `silent` references data, so the `if` statement will fail in **src/tools/http_download.c:206** and download progress will not print to the window.  

The fix is to initialize `silent` in both encrypted and unencrypted file download scenarios.  

## Testing

Valgrind: Yes  

- `/url save` without OMEMO  
  **SUCCESS**: Try three times with the same URL and download status will display every time.  

- `/url save` with OMEMO  
  **SUCCESS**: Try three times with the same URL and download status will display every time.  

- `/plugins install https://raw.githubusercontent.com/profanity-im/profanity-plugins/master/stable/sounds.py`  
  **SUCCESS**: Try once and download progress is hidden.
2024-02-28 07:23:59 -07:00
..
cmd_ac.c Update copyright to 2024 2024-01-22 16:03:48 +01:00
cmd_ac.h slightly improve `command_defs[]` 2023-01-18 20:02:46 +01:00
cmd_defs.c Update copyright to 2024 2024-01-22 16:03:48 +01:00
cmd_defs.h Update copyright to 2024 2024-01-22 16:03:48 +01:00
cmd_funcs.c Fix unable to download item twice 2024-02-28 07:23:59 -07:00
cmd_funcs.h Update copyright to 2024 2024-01-22 16:03:48 +01:00