1
0
mirror of https://github.com/profanity-im/profanity.git synced 2024-11-03 19:37:16 -05:00
Commit Graph

2663 Commits

Author SHA1 Message Date
James Booth
a564b0241f Added test for jid validation on /bookmark add 2014-08-18 21:25:52 +01:00
Jan Hacker
e87eb4c40e "/bookmark add foo" crash - fix
A user providing an invalid JID when creating a new bookmark (like 'foo')
would reproducibly crash/segfault profanity, as it insists on checking
string length behind the @ of the JID. However, it could be NULL
if the user accidentally omitted it.
The patch avoids the crash by NULL-checking and prevents
getting there in the first place by checking the argument to "add".
Backtrace of unpatched profanity with above command:

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x0000000000000000
0x00007fff85699732 in strlen ()
(gdb) bt
 #0  0x00007fff85699732 in strlen ()
 #1  0x00000001000965d2 in xmpp_strdup ()
 #2  0x0000000100095d6d in xmpp_stanza_set_attribute ()
 #3  0x0000000100011c5c in _send_bookmarks ()
 #4  0x00000001000115a8 in _bookmark_add ()
 #5  0x000000010003320d in cmd_bookmark ()
 #6  0x000000010002a0f2 in cmd_execute ()
 #7  0x0000000100003a1d in process_input ()
 #8  0x00000001000037c7 in prof_run ()
 #9  0x0000000100045032 in main ()
(gdb)
2014-08-17 22:22:12 +02:00
James Booth
7f0fd06d0b Removed libstrophe dependencies as no longer statically linking 2014-08-13 20:47:56 +01:00
Dariusz Dwornikowski
225312802e Spelling errors fixed and hyphenation used as minus sign fixed 2014-08-11 18:54:20 +02:00
James Booth
651d5aaaf0 Fix notification support check for cygwin 2014-08-10 01:20:42 +01:00
James Booth
5d86e57cf9 Set to 0.4.4 development 2014-08-09 23:47:23 +01:00
James Booth
bd1539b1a6 Set status to release 2014-08-09 23:12:21 +01:00
James Booth
3c5d5e2ec0 Added call to ldconfig for opensuse install 2014-08-09 23:06:19 +01:00
James Booth
99fc7c5ed4 Make prefix and argument to libstrophe install 2014-08-09 21:16:01 +01:00
James Booth
edac38784d Removed AC_FUNC_MALLOC 2014-08-09 21:04:36 +01:00
James Booth
04127393b2 Added --prefix=/usr to all libstrophe installs 2014-08-09 19:58:04 +01:00
James Booth
4a37572c8c Added libtool to dependencies in install-all.sh 2014-08-09 19:35:12 +01:00
James Booth
192656e5b8 Updates to install-all.sh
Use main apt-get git repo
Use main libstrophe git repo
Configure libstrophe with --prefix==/usr on cygwin
Use 0.8.6 tag of libstrophe
2014-08-09 19:12:37 +01:00
James Booth
8fc4249228 Enable splash logo by default 2014-08-09 19:00:59 +01:00
James Booth
ac68cc77f8 Allow escaping commands using double slash "//" 2014-08-06 22:46:36 +01:00
James Booth
e38ebe8a85 Check for unknown commands and show message in console
fixes #390
2014-08-04 22:21:53 +01:00
James Booth
cd9b1449b5 Escape open bracket at start of OSX notification messages
fixes #391
2014-08-04 22:01:03 +01:00
James Booth
f18bfc3396 Escape backtick in mac terminal notifications 2014-08-04 21:41:17 +01:00
James Booth
1809064d29 Added scripts and profrc.example to dist target 2014-08-04 21:08:56 +01:00
James Booth
d8cab42a2a Merge branch 'master' into winbuffers 2014-07-29 15:52:14 +01:00
James Booth
816351d371 Set auto reconnect to 30 seconds by default
fixes #386
2014-07-29 15:40:51 +01:00
James Booth
73a56de470 Changed comma colour in room roster 2014-07-23 01:06:57 +01:00
James Booth
3eaebeb002 Merge branch 'master' into winbuffers 2014-07-22 23:37:21 +01:00
James Booth
9123675c9c Show message when no group or empty roster on /who 2014-07-22 23:31:14 +01:00
James Booth
fd1d540889 Added _who_roster function 2014-07-22 23:27:36 +01:00
James Booth
6a1975f65b Added _who_room function 2014-07-22 23:22:50 +01:00
James Booth
1aee7ce4bf Show message when no contacts with presence for /who 2014-07-22 23:17:42 +01:00
James Booth
79c857fb2a Fixed bug with chat room history times being coloured 2014-07-22 22:16:17 +01:00
James Booth
56457de997 Fixed colouring in room roster 2014-07-21 13:32:46 +01:00
James Booth
1273d850a4 Use win_save_println in core.c 2014-07-21 00:18:37 +01:00
James Booth
db9028d9c3 Added win_save_println 2014-07-21 00:11:38 +01:00
James Booth
f4fa0bc2dd Added win_save_newline 2014-07-20 23:57:31 +01:00
James Booth
490e252fb4 Removed win_print from window.h 2014-07-20 23:39:17 +01:00
James Booth
bb0fe16b4d Made win_print static 2014-07-20 23:35:48 +01:00
James Booth
5ce08adff6 Added BUFF_SIZE back again 2014-07-20 21:53:50 +01:00
James Booth
b125fa0feb Return address of buffer entry 2014-07-19 17:14:04 +01:00
James Booth
191b910d6e Erase stdscr before resizing 2014-07-19 00:39:49 +01:00
James Booth
bf62d8bd65 Use PAD_SIZE for buffer max size 2014-07-18 23:52:00 +01:00
James Booth
78b0388b6c Merge branch 'statusbar' into winbuffers 2014-07-18 23:19:25 +01:00
James Booth
60afe66042 Moved status_bar_resize 2014-07-18 23:17:42 +01:00
James Booth
1e6b70943a Use GSList for buffer entries 2014-07-18 23:07:08 +01:00
James Booth
2a435cd3de Removed horizontal paging 2014-07-18 22:28:49 +01:00
James Booth
32527eb766 Merge branch 'master' into winbuffers 2014-07-17 00:30:18 +01:00
James Booth
8a113ad688 Updated themes with roommention setting 2014-07-17 00:28:39 +01:00
James Booth
5019b8c7f7 Merge branch 'master' into winbuffers 2014-07-17 00:12:50 +01:00
James Booth
996817d67f Changed version to 0.4.3dev 2014-07-17 00:08:57 +01:00
James Booth
d2d15ca76b Removed newlines from splash logo version output 2014-07-16 23:23:11 +01:00
James Booth
a4edc12d80 Removed flag != 0's 2014-07-16 22:56:58 +01:00
James Booth
20c11adddc Used constants for print flags 2014-07-16 22:41:02 +01:00
James Booth
860591872f Removed unused function 2014-07-16 22:34:02 +01:00