aniani/profanity
1
0
Fork 0
mirror of https://github.com/profanity-im/profanity.git synced 2024-12-04 14:46:46 -05:00
Code
5,646 Commits 32 Branches 59 Tags 24 MiB
94a9de8773
Commit Graph

5646 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Michael Vetter
f186eb94da Remove not neede free 
It's in the def == NULL case. So will always be noop.
 2019-10-25 14:06:03 +02:00
Michael Vetter
6a88af6bc6 Remove /leave command 
We have `/close` which does the same and more.

Regards https://github.com/profanity-im/profanity/issues/1116
 2019-10-22 15:33:54 +02:00
Michael Vetter
47d8d210ab Make forest theme more readable 2019-10-22 15:10:55 +02:00
Michael Vetter
8764e59650 Adjust stub for connection_get_profanity_identifier 2019-10-22 14:24:07 +02:00
Michael Vetter
22bf281399 Make prof_identifier const 2019-10-22 12:47:32 +02:00
Michael Vetter
6b75848f96 Display ownership of connection_get_profanity_identifier 2019-10-22 12:04:16 +02:00
Michael Vetter
f023eb8d72 Dont allow new issues 2019-10-22 11:13:41 +02:00
Michael Vetter
ba18752405 Use UUID in origin-id and id 
Let's use UUID to have a more random string then just 10 alphanumeric
values.
 2019-10-22 11:10:37 +02:00
Martin
b16426f66d Change default text colors to default (#1213) 
Change default themes text color

Using "default" instead of white makes the default better readable
when using a black/dark font on white/light background.

May fix #535
 2019-10-22 08:13:39 +02:00
Michael Vetter
2292f15633 Make sure date vars are initialized 2019-10-21 16:19:35 +02:00
Michael Vetter
40d9dcae87 Properly display chatwin history 
So far if one had enabled `/history` and did `/msg somenick` the history
was loaded from file and displayed like this:

```
04-04-17 15:23 - 3/4/2017:
01-01-00 10:30 - me: ....
01-01-00 10:31 - somebody: ....
01-01-00 10:32 - somebody: ....
```

So the first line contained the actual date. But the date used in each
line was always 01-01-2000. This date was for some reason hardcoded.

This commit now actually uses that date to build the proper GDateTime
instead of just printing it.

Fix https://github.com/profanity-im/profanity/issues/922
 2019-10-21 15:26:40 +02:00
Michael Vetter
ef19b45e64 Remove old comment 
It's not up to date.
Some time ago we changed from individual handlers to general ones.
 2019-10-21 10:28:29 +02:00
Michael Vetter
c4a52b13e8
Merge pull request #1209 from jubalh/feature/xep-0359 
XEP-0359
 2019-10-21 09:56:15 +02:00
Michael Vetter
963ab841b4 Set prof_ident to NULL after free 
This caused the bug mentioned in the PR comment:

```
It seems with the changes done here we get a crash in: src/xmpp/message.c message_handlers_init() when looking up handlers: ProfMessageHandler *handler = g_hash_table_lookup(pubsub_event_handlers, curr->data);.

Steps to reproduce:

    open Profanity and connect
    /autoping set 10
    /autoping timeout 10
    stop WiFi/connection
    wait for Lost connection
    restart wifi
    /connect
```
 2019-10-21 09:50:13 +02:00
Michael Vetter
8a5932b251 Rename _calculate_identifier to _compute_identifier 2019-10-20 00:01:19 +02:00
Michael Vetter
db4b55eee0 Rename random_bytes to profanity_instance_id 2019-10-19 23:27:19 +02:00
Michael Vetter
31014b5e51 Fix which message we want to log 2019-10-19 23:24:33 +02:00
Michael Vetter
2a4d1b8410 Free hmac and msgid 2019-10-19 08:18:37 +02:00
Michael Vetter
f190d2c5f2 Free prof_identifier in case of reconnect 
Bedore we assign it new.
 2019-10-19 07:40:59 +02:00
Michael Vetter
c3912df05b Move ProfMessage and message_is_sent_by_us to xmpp 
Not meant for internal usage only.
 2019-10-19 06:36:47 +02:00
Michael Vetter
4d7a496ae2 Change origin-id/id algo 
Hash twice.
Use HMAC SHA256 from glib.
 2019-10-18 16:12:26 +02:00
Michael Vetter
72bdae1014 Add message_is_sent_by_us stub 2019-10-18 14:53:06 +02:00
Michael Vetter
06f300a42c Move message sent by us logic in own function 2019-10-18 14:50:25 +02:00
Michael Vetter
3bd5c9f535 Remove accidentally added file 2019-10-18 12:24:34 +02:00
Michael Vetter
dfead6415f sv_ev_room_message: log in all cases if not our client 
Forgot to check what happens if the length is <= 10.
 2019-10-18 11:59:39 +02:00
Michael Vetter
f7474cd72c sv_ev_room_message: check if message->id is not NULL 2019-10-18 11:43:30 +02:00
Michael Vetter
5c6f5ba0f7 Add connection_get_profanity_identifier stub 
And move defintion to xmpp.h
 2019-10-18 11:23:30 +02:00
Michael Vetter
33083662d1 Add XEP-0359 to capabilities 
We implement </origin-id> from [XEP-0359](https://xmpp.org/extensions/xep-0359.html).
We already had this implemented for OMEMO. And now use it to check
whether MUC messages were sent from us
(https://github.com/profanity-im/profanity/issues/1201).

We don't implement </stanza-id> yet, but probably need to do so for MAM.

Anyways let's flag this as implementing the XEP.

Fix https://github.com/profanity-im/profanity/issues/1207
 2019-10-18 10:46:06 +02:00
Michael Vetter
430b2eaa0d Log incoming MUC messages if origin-id sais they dont come from us 
Regards https://github.com/profanity-im/profanity/issues/1201
 2019-10-18 10:40:24 +02:00
Michael Vetter
53640f6e97 Remove prefix from stanza id 
We sent `prof_prefix_uuid` as id. Where the prefix was also optional.
We don't need this at all.
 2019-10-17 15:40:40 +02:00
Michael Vetter
827af999b7 Change algo for connection_create_stanza_id() 2019-10-17 15:32:46 +02:00
Michael Vetter
8f5d1751b2 Change connection_create_stanza_id() 
To return identifier and uuid together.
We can remove the prefix later on.
 2019-10-17 09:23:11 +02:00
Michael Vetter
708bc83870 Calculate identifier upon connect 
This will be needed so that we can later detect if messages (origin-in)
was sent by us.

Regards https://github.com/profanity-im/profanity/issues/1207
 2019-10-16 15:53:28 +02:00
Michael Vetter
ee0541a262 Rename identification file 2019-10-16 10:54:05 +02:00
Michael Vetter
46f0304f89 Use random string for random-bytes identifier 
And rename `instance` to `identifier`.

Regards https://github.com/profanity-im/profanity/issues/1207
 2019-10-16 10:45:41 +02:00
Michael Vetter
f9eb302a59 Move code from jid_random_resource() into own function 
Move the code that creates a random string into it's own function
+get_random_string().
 2019-10-16 10:39:35 +02:00
Michael Vetter
1e09a055ca Create random-bytes file 
So far only with dummy value.
We will need an identifier that we can hash together with a message ID
and put in as the origin-id.
So when we receive message we can unsplit it and see if it was sent from
this client.

Regards https://github.com/profanity-im/profanity/issues/1207
 2019-10-16 10:17:34 +02:00
Michael Vetter
452a9f645e
Merge pull request #1206 from profanity-im/issue1203 
plugins/python: fix double _XOPEN_SOURCE definition
 2019-10-15 15:28:36 +02:00
Dmitry Podgorny
69bba3ea4e plugins/python: fix double _XOPEN_SOURCE definition 
ncursesw defines _XOPEN_SOURCE macro via command-line. In particular, it
is defined in ncursesw.pc and extracted via pkg-config. From other side,
Python defines the same macro unconditionally in pyconfig.h. Python-3.x
defines the macro with value different than ncursesw does. In turn, this
causes a warning that the macro is redefined. And warnings are treated
as errors.

Since both entities define the mecro unconditionally, we can't simply
reorder headers as Python developers suggest. So, undefine the macro
just before the <Python.h> to fix this silly issue.
 2019-10-15 12:30:38 +00:00
Michael Vetter
d0c3d3fd6b Null-set account struct 
Surpresses the valgrind warning about uninit. values.
 2019-10-14 11:35:18 +02:00
Dmitry Podgorny
0499c4e0ee Fix memory leak in unittests 2019-10-14 00:23:02 +03:00
Dmitry Podgorny
6d11cd2db3 Fix memory leak in cmd_join() 
room is either argv[0] or allocated by GString. We have to free memory
in the 2nd case. Replace argv[0] with g_strdup(argv[0]) in order to
make unconditional g_free().
 2019-10-14 00:19:08 +03:00
Michael Vetter
ffd74229fa
Merge pull request #1205 from mdosch/master 
Add cmd.wins.unread
 2019-10-12 20:19:18 +02:00
Martin Dosch
df25e9c3d9 Add cmd.wins.unread 2019-10-12 13:42:08 +02:00
Michael Vetter
5c53e02d86 Add option to hilight unread rooms in /wins command 
In the theme we can now set `cmd.wins.unread` to hvae a special color
for the lines of the `/wins` output that have unread messages.

Fix https://github.com/profanity-im/profanity/issues/895
 2019-10-12 13:03:14 +02:00
Michael Vetter
559c143587 travis: show log in case make check failed 2019-10-10 19:10:55 +02:00
Michael Vetter
8e5dafdea5 Fix invalid reads in unit tests 2019-10-10 19:02:23 +02:00
Michael Vetter
2559ad5370 Revert "Free lits in test_cmd_roster unittest" 
This reverts commit 5b19ed28ce.

This caused a segfault.
 2019-10-10 18:08:24 +02:00
Michael Vetter
87b66d0816 Make cmd_account safer 2019-10-10 18:06:28 +02:00
Michael Vetter
d3dd95963e Sort includes in python_api.c 2019-10-07 15:53:17 +02:00