Michael Vetter
2caae3ed99
Merge pull request #1807 from alexandre1985/fix/typos
...
Fix typos and add codespell configuration
2023-04-03 17:13:00 +02:00
Daniel Santos
c7f05c9ebf
Fix typos and update codespell configuration
...
* Fix typos.
* Add words that are not typos to codespell's ignore words list and
ignore regex.
* Make codespell ignore URIs.
* Make `make doublecheck` throw no error.
Signed-off-by: Daniel Santos <dacs.git@brilhante.top>
2023-04-03 13:25:25 +01:00
MarcoPolo-PasTonMolo
24ba431ed7
Add autocomplete for the /reconnect command
...
After typing `/reconnect ` and pressing tab nothing appeared where in
reality, it should have been autocompleted to `/reconnect now`
2023-04-02 22:06:17 +03:00
MarcoPolo-PasTonMolo
ce688f6737
Fix empty window after reconnect
...
Sometimes after a reconnect the current window would get cleared. This
was a deliberate change to fix the profanity window looking all garbled
up after providing the passphrase for a gpg key using pinentry-curses.
Fixes https://github.com/profanity-im/profanity/issues/1556
2023-04-02 21:53:12 +03:00
Michael Vetter
f2c83fa8ce
Merge pull request #1801 from alexandre1985/editor-with-arguments
...
Editor executable support flags
2023-03-31 16:01:22 +02:00
Daniel Santos
12fda4226b
Add editor executable to CMD_SYN
...
* Add missing text of how to set editor in CMD_SYN
Signed-off-by: Daniel Santos <dacs.git@brilhante.top>
2023-03-31 13:55:58 +01:00
Michael Vetter
a0d5c07a4c
Fix headings in contributing.md
2023-03-31 14:14:52 +02:00
Michael Vetter
2e1d5d03dc
Merge pull request #1802 from H3rnand3zzz/pgp-fix
...
Security fix of OTR, PGP and other
2023-03-31 13:21:16 +02:00
John Hernandez
407905cfc5
Fix OTR
...
Fix OTR: carbon in stanza breaks OTR and prevents it from starting and working properly.
2023-03-31 12:30:51 +02:00
John Hernandez
99c9f150f6
Fix PGP
...
Fix of PGP and potentially other encryption methods by calling correct function that would initiate them in case if someone writes.
2023-03-31 12:30:51 +02:00
Daniel Santos
007f623ad8
Editor executable support flags
...
* Make editor executable into a string to be able to support
(multiple) flags.
* Change /help executable to suit this new feature
Signed-off-by: Daniel Santos <dacs.git@brilhante.top>
2023-03-30 21:44:26 +01:00
Michael Vetter
2093fe417f
Merge pull request #1800 from profanity-im/switch
...
Improve some UI functions
2023-03-23 18:47:09 +01:00
Michael Vetter
732cbbfefc
Add WIN_VCARD to win_get_tab_identifier()
...
Thanks to 12b997c5f3
we already found a
place where we should add this missing window type.
AFAIK there can be only one vcard window.
2023-03-23 10:33:54 +01:00
Michael Vetter
ac440e72d7
Adapt to new g_string_free() usage
...
Somehow this must have been overlooked when doing
e59c401c84
.
2023-03-23 10:33:50 +01:00
Michael Vetter
12b997c5f3
ui: make it easier to find non covered window types
...
Rewrite `win_get_title()` to using switch without a default case. So the compiler warns us
(`enumeration value ‘WIN_XXX’ not handled in switch`)
in case we add a new window type (WIN_CHAT, WIN_PRIV etc) and forget to
adapt this function.
Add assert() in the end to make compiler happy when he realizes there
the function might have no return value (`control reaches end of
non-void function`). This should ever be reached.
Replace the default value of `win_to_string()`, `win_get_tab_identifier()` as
well, and replace it with an assert.
See discussion started at https://github.com/profanity-im/profanity/pull/1799#discussion_r1142444684
2023-03-23 10:20:04 +01:00
Michael Vetter
b393363bd5
Merge pull request #1799 from profanity-im/glib276gsf
...
Adapt to g_string_free glib 2.75.3 change
2023-03-22 15:53:41 +01:00
Michael Vetter
e59c401c84
Adapt to g_string_free glib 2.75.3 change
...
glib 2.75.3 changes warning behaviour of `g_string_free()`.
See:
* https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3219
* https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3226
Use this opportunity to replace the use of GString with
`g_strdup_printf()` where possible.
Otherwise correctly take the return value of `g_string_free()`
which is nicer anyways.
2023-03-21 10:53:10 +01:00
Michael Vetter
e5e8ff221a
Merge pull request #1796 from profanity-im/minor-improvements
...
Minor improvements
2023-03-13 09:18:18 +01:00
Steffen Jaeckel
2936b09a63
change OMEMO QR code 0
bits to 'space'
...
This makes the generated QR code a lot better recognizable in my case.
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-03-12 17:39:57 +01:00
Steffen Jaeckel
091987db94
fix #1797
...
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-03-12 17:37:21 +01:00
Steffen Jaeckel
7167760bdd
fix #1761 by changing the implementation from recursive
...
... to an iterative approach
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-03-11 15:05:03 +01:00
Steffen Jaeckel
2925e85cd6
add test-case for #1761
...
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-03-11 15:05:03 +01:00
Steffen Jaeckel
e99c4b7128
simplify some code
...
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-03-11 15:05:03 +01:00
Steffen Jaeckel
92eed34fb3
remove compat code
...
We already depend on libstrophe >= 0.12, so this code can go.
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-03-11 15:05:03 +01:00
Michael Vetter
f618b9cc16
Correct ML URL in SPONSORS.md
2023-03-10 11:20:59 +01:00
Michael Vetter
96c1c44a9d
Merge pull request #1795 from IsaacM88/master
...
Fix duplicate download IDs when using "/url save"
2023-03-10 07:50:30 +01:00
IsaacM88
d043d53948
Fix duplicate download IDs.
...
Fixes https://github.com/profanity-im/profanity/issues/1794
Explanation
The problem is the download's identifier. Downloads are given an ID so they can be referenced later when their progress changes. Currently, the download's ID is the download's URL. When you download the same file twice, you have two downloads with the same ID. Download progress updates are shown on the first of both downloads with the same ID.
Solution
Change the download's ID from its URL to a random number. A random ID is generated when get_random_string() is called from cmd_funcs.c. Several other functions are updated to cope with the new ID format.
2023-03-09 15:02:26 -07:00
Michael Vetter
792be5519e
Update sponsors
...
Thanks again guys!
2023-03-01 15:35:14 +01:00
Michael Vetter
e1d45f05d3
Update to new mailing list
...
Maintained by https://github.com/StefanKropp
2023-03-01 15:25:41 +01:00
Michael Vetter
4887d21a11
cmd: Update MAM help
2023-02-15 15:40:51 +01:00
Michael Vetter
0c24271a63
Merge pull request #1789 from MarcoPolo-PasTonMolo/fix/autocompletion_after_MAM
...
Fix quote and url autocompletion for MAM and history
2023-02-15 15:18:59 +01:00
Michael Vetter
89b0744628
Merge pull request #1791 from MarcoPolo-PasTonMolo/fix/MAM_not_loading_recent_messages
...
Fix MAM not loading some recent messages
2023-02-15 15:18:08 +01:00
MarcoPolo-PasTonMolo
b64411a3f9
Fix MAM not loading some recent messages
...
Reverse a small change from commit e886ba0
that caused this issue.
Fixes https://github.com/profanity-im/profanity/issues/1790
2023-02-14 00:25:11 +02:00
MarcoPolo-PasTonMolo
6d266984a4
Fix quote and url autocompletion for MAM and history
...
After adding MAM quote and url autocompletion wouldn't pick up messages
from MAM or history(from DB) or would have them in the wrong order. This
commit fixes that.
Fixes https://github.com/profanity-im/profanity/issues/1770
2023-02-13 23:40:58 +02:00
Michael Vetter
1105571584
Merge pull request #1788 from profanity-im/minor-improvements
...
Minor improvements
2023-01-30 09:07:17 +01:00
Michael Vetter
88911c031e
Merge pull request #1786 from thexhr/devel
...
Don't pass NULL pointers to vprintf
2023-01-30 09:06:52 +01:00
Steffen Jaeckel
b602d619f6
prevent setting invalid combination of libstrophe flags
...
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-27 17:04:48 +01:00
the xhr
e1072c8640
Remove space to match clang coding style
2023-01-26 17:43:04 +01:00
the xhr
714add207b
Add macro for possible NULL prints and use it on known sports
...
The macro is effective on OpenBSD and basically a no op on other platforms.
Use it for one existing and the other known debug statements.
2023-01-26 17:42:52 +01:00
the xhr
6ceafac6aa
Check if string is NULL and print placeholder instead
...
OpenBSD's kernel warns about NULL printfs. Fix this with a standard check.
2023-01-26 17:39:46 +01:00
Steffen Jaeckel
901ef21727
simplify some code
...
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-26 11:50:02 +01:00
Steffen Jaeckel
f406384c34
fix libstrophe timer-callback usage
...
The timer will be auto-removed if the callback returns `0`. The way it was
done before breaks some internals of libstrophe.
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-26 11:49:29 +01:00
Michael Vetter
494512c25c
Merge pull request #1780 from profanity-im/minor-improvements
...
Minor improvements
2023-01-19 11:05:42 +01:00
Steffen Jaeckel
99ffaf0a00
introduce auto_gcharv
...
This also fixes memory leaks in `_omemo_autocomplete()`.
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-19 10:40:25 +01:00
Steffen Jaeckel
b535921484
introduce auto_jid
and refcounting in Jid
...
This also fixes a memory leak from within `_handle_groupchat()` in [0].
[0] src/xmpp/message.c
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-19 10:40:25 +01:00
Steffen Jaeckel
1a85448bf2
improve const correctness
...
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-18 20:11:13 +01:00
Steffen Jaeckel
e886ba0c6f
fix more memory leaks
...
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-18 20:11:13 +01:00
Steffen Jaeckel
698aefa005
fix memory leaks in OMEMO
...
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-18 20:11:13 +01:00
Steffen Jaeckel
302d0dd576
let account_new()
take ownership of passed values
...
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-18 20:02:46 +01:00
Steffen Jaeckel
a0aa26b6fa
add now
option to /reconnect
command
...
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-18 20:02:46 +01:00