James Booth
f9737251a6
Added license exemption for OpenSSL to source headers
2014-08-24 20:57:39 +01:00
Jan Hacker
e87eb4c40e
"/bookmark add foo" crash - fix
...
A user providing an invalid JID when creating a new bookmark (like 'foo')
would reproducibly crash/segfault profanity, as it insists on checking
string length behind the @ of the JID. However, it could be NULL
if the user accidentally omitted it.
The patch avoids the crash by NULL-checking and prevents
getting there in the first place by checking the argument to "add".
Backtrace of unpatched profanity with above command:
Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x0000000000000000
0x00007fff85699732 in strlen ()
(gdb) bt
#0 0x00007fff85699732 in strlen ()
#1 0x00000001000965d2 in xmpp_strdup ()
#2 0x0000000100095d6d in xmpp_stanza_set_attribute ()
#3 0x0000000100011c5c in _send_bookmarks ()
#4 0x00000001000115a8 in _bookmark_add ()
#5 0x000000010003320d in cmd_bookmark ()
#6 0x000000010002a0f2 in cmd_execute ()
#7 0x0000000100003a1d in process_input ()
#8 0x00000001000037c7 in prof_run ()
#9 0x0000000100045032 in main ()
(gdb)
2014-08-17 22:22:12 +02:00
James Booth
954661e59e
Added quote param to autocomplete_complete
2014-07-09 20:23:47 +01:00
James Booth
1c62d7fda8
Renamed generate_unique_id -> create_unique_id
2014-06-15 21:49:34 +01:00
James Booth
d181f500ea
Fixed usages of get_unique_id to free result
2014-06-15 20:56:24 +01:00
James Booth
b85fd5e78c
Use account muc_nick when no nick for bookmark
2014-05-23 00:55:30 +01:00
James Booth
d2662a6f17
Refactored bookmarks to use option parser, allow bookmarking rooms with passwords
2014-05-10 00:50:43 +01:00
James Booth
2c15aba92a
Chat room windows now created only after successful join
2014-04-21 00:37:04 +01:00
James Booth
bc6f8ceb3a
Fixed handling of room subject
2014-04-13 03:11:46 +01:00
James Booth
f332b6681e
Fixed "/bookmark remove" for disabling autojoin
...
Issue #194
2014-04-13 02:27:37 +01:00
James Booth
f62cf772a7
Refactored bookmark_remove
...
Issue #194
2014-04-13 02:05:12 +01:00
James Booth
73c146c65a
Implemented "/bookmark remove" for private storage
...
Issue #194
2014-04-13 01:39:54 +01:00
James Booth
f7daaf0953
Clean up after removing bookmark
...
Issue #194
2014-04-13 01:11:21 +01:00
James Booth
5bb3fab17c
Implemented "/bookmark add" for private storage
...
Issue #194
2014-04-13 01:01:53 +01:00
James Booth
aa2a87d162
Tidied ui dependencies
2014-04-06 21:35:17 +01:00
James Booth
26726b207a
Updated copyright
2014-03-09 01:18:19 +00:00
James Booth
b177250f47
Refactored muc_room_is_active to only take room, rather than full jid
2014-03-08 21:20:26 +00:00
James Booth
dd1ee18c72
Added test for /join with nick option
2014-03-08 21:10:23 +00:00
Kristofer M White
8a54c5895d
Adding password handling for joining chatrooms
2014-02-27 05:31:10 +00:00
James Booth
3e02921859
Removed id from bookmarks add
2014-02-03 19:35:26 +00:00
James Booth
9394091f04
Implemented add bookmark for XEP-0223
...
Issue #194
2014-02-02 02:39:36 +00:00
James Booth
95c48a0f47
Test message when removing autojoin for non existent bookmark
2014-02-02 01:05:52 +00:00
James Booth
9d957e5f93
Show message on /bookmark remove when bookmark does not exist
2014-02-02 00:59:32 +00:00
James Booth
92b85bb7f1
Added message when bookmark updated
2014-02-02 00:49:02 +00:00
James Booth
aada6d5cd6
Don't show error for initial bookmarks request
2014-01-25 17:18:30 +00:00
James Booth
c001f0e7cb
Bind bookmark functions in main.c
2013-12-22 23:13:34 +00:00
James Booth
81909ef000
Dynamically bind xmpp module api
2013-12-18 20:16:55 +00:00
Dmitry Podgorny
545a23e92f
removed strdup in autocomplete calls
2013-08-26 03:29:50 +03:00
James Booth
7906bd6a9d
Bookmarks: Move stanza pointer on in loop, check for autojoin "true"
2013-07-15 00:52:47 +01:00
Dmitry Podgorny
b9d29e9aa5
draft of bookmarks implementation
...
'/bookmark add' and '/bookmark remove' ain't finished
2013-07-14 23:58:02 +03:00
Dmitry Podgorny
6e23584575
improved autojoin logic
...
Delete id handler after timeout (5sec) if response isn't received
Auto join maximum 5 conferences
2013-07-14 17:08:49 +03:00
Dmitry Podgorny
034cf730cc
use get_unique_id for bookmarks
2013-07-14 13:49:50 +03:00
Dmitry Podgorny
2837c4054f
initial support of autojoin for MUC
2013-06-30 18:59:38 +03:00
