James Booth
15fe590eda
Removed bookmarks todo
2014-08-31 23:11:30 +01:00
Dariusz Dwornikowski
1dcc028a71
Small spelling fixes in code and comments
2014-08-27 13:26:11 +02:00
James Booth
f9737251a6
Added license exemption for OpenSSL to source headers
2014-08-24 20:57:39 +01:00
Jan Hacker
e87eb4c40e
"/bookmark add foo" crash - fix
...
A user providing an invalid JID when creating a new bookmark (like 'foo')
would reproducibly crash/segfault profanity, as it insists on checking
string length behind the @ of the JID. However, it could be NULL
if the user accidentally omitted it.
The patch avoids the crash by NULL-checking and prevents
getting there in the first place by checking the argument to "add".
Backtrace of unpatched profanity with above command:
Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x0000000000000000
0x00007fff85699732 in strlen ()
(gdb) bt
#0 0x00007fff85699732 in strlen ()
#1 0x00000001000965d2 in xmpp_strdup ()
#2 0x0000000100095d6d in xmpp_stanza_set_attribute ()
#3 0x0000000100011c5c in _send_bookmarks ()
#4 0x00000001000115a8 in _bookmark_add ()
#5 0x000000010003320d in cmd_bookmark ()
#6 0x000000010002a0f2 in cmd_execute ()
#7 0x0000000100003a1d in process_input ()
#8 0x00000001000037c7 in prof_run ()
#9 0x0000000100045032 in main ()
(gdb)
2014-08-17 22:22:12 +02:00
Dariusz Dwornikowski
225312802e
Spelling errors fixed and hyphenation used as minus sign fixed
2014-08-11 18:54:20 +02:00
James Booth
954661e59e
Added quote param to autocomplete_complete
2014-07-09 20:23:47 +01:00
James Booth
6483bc8d7c
Removed string allocation in stanza when joining room
2014-06-15 22:26:28 +01:00
James Booth
1c62d7fda8
Renamed generate_unique_id -> create_unique_id
2014-06-15 21:49:34 +01:00
James Booth
efc833a202
Free string after use in sending caps response
2014-06-15 21:39:54 +01:00
James Booth
c9274a38b2
Free jabber_conn.log
2014-06-15 21:19:53 +01:00
James Booth
d6d714e1ed
Free saved account details before replacing
2014-06-15 21:00:01 +01:00
James Booth
d181f500ea
Fixed usages of get_unique_id to free result
2014-06-15 20:56:24 +01:00
James Booth
ccf5cb846b
Added connection details to jabber_shutdown
2014-06-15 20:46:12 +01:00
James Booth
4d0566b5d1
Fixed memleak in _available_handler
2014-06-15 20:39:50 +01:00
James Booth
92837ec186
Renamed sha1 functions to avoid naming clashes
2014-06-15 19:08:18 +01:00
James Booth
b25b3f3180
Added notification setting for typing in current window
2014-05-24 21:13:33 +01:00
James Booth
b85fd5e78c
Use account muc_nick when no nick for bookmark
2014-05-23 00:55:30 +01:00
James Booth
d2662a6f17
Refactored bookmarks to use option parser, allow bookmarking rooms with passwords
2014-05-10 00:50:43 +01:00
James Booth
143c5a3493
Refactroed self presence checks, handle null stanzas
...
Issue #341
2014-05-06 22:07:44 +01:00
James Booth
ba8d1325ad
Added null check for presence error stanza namespace element
...
Issue #341
2014-05-05 22:01:27 +01:00
James Booth
524b1f2383
Changed to use gnutls instead of openssl for sha1 hashing
2014-05-01 22:18:04 +01:00
James Booth
d6e92f62dc
Fixed cppcheck warnings
2014-04-26 00:36:36 +01:00
James Booth
4384a1f468
Tidied jabber_process_events
2014-04-23 20:51:57 +01:00
James Booth
1a0f12b0e6
Merge remote-tracking branch 'lucian/master'
2014-04-22 23:53:15 +01:00
James Booth
2c15aba92a
Chat room windows now created only after successful join
2014-04-21 00:37:04 +01:00
James Booth
9a55d8ad19
Store password with room
2014-04-20 22:02:55 +01:00
lightb
1ceca89296
Added some otr policy functionality, if policy is set to "always"
...
if otr_is_secure fails, the message will not be sent.
Changed both cmd_msg and cmd_execute_default
2014-04-19 05:08:33 -04:00
James Booth
bf185d9907
Added simple stanza logging to main console
2014-04-15 01:08:41 +01:00
James Booth
bc6f8ceb3a
Fixed handling of room subject
2014-04-13 03:11:46 +01:00
James Booth
f332b6681e
Fixed "/bookmark remove" for disabling autojoin
...
Issue #194
2014-04-13 02:27:37 +01:00
James Booth
f62cf772a7
Refactored bookmark_remove
...
Issue #194
2014-04-13 02:05:12 +01:00
James Booth
73c146c65a
Implemented "/bookmark remove" for private storage
...
Issue #194
2014-04-13 01:39:54 +01:00
James Booth
f7daaf0953
Clean up after removing bookmark
...
Issue #194
2014-04-13 01:11:21 +01:00
James Booth
5bb3fab17c
Implemented "/bookmark add" for private storage
...
Issue #194
2014-04-13 01:01:53 +01:00
James Booth
aa2a87d162
Tidied ui dependencies
2014-04-06 21:35:17 +01:00
James Booth
8f7bdc3c2e
Switch back to storage for muc bookmarks
2014-03-29 23:15:51 +00:00
James Booth
7e27d96f16
Revert "Commented bookmarks code for 0.4.0 release"
...
This reverts commit 8306d4c244
2014-03-29 22:58:48 +00:00
James Booth
8306d4c244
Commented bookmarks code for 0.4.0 release
2014-03-16 18:20:31 +00:00
James Booth
26726b207a
Updated copyright
2014-03-09 01:18:19 +00:00
James Booth
b177250f47
Refactored muc_room_is_active to only take room, rather than full jid
2014-03-08 21:20:26 +00:00
James Booth
dd1ee18c72
Added test for /join with nick option
2014-03-08 21:10:23 +00:00
Dmitry Podgorny
0fbaa6f5ee
fixed build error when make run with -jN option
...
Race can occur when gitversion file isn't fully generated before
it is used.
2014-03-06 02:06:22 +02:00
Kristofer M White
ced6e7f411
Making whitespace consistently spaces, not tabs
2014-02-27 05:40:31 +00:00
Kristofer M White
8a54c5895d
Adding password handling for joining chatrooms
2014-02-27 05:31:10 +00:00
James Booth
3e02921859
Removed id from bookmarks add
2014-02-03 19:35:26 +00:00
James Booth
9394091f04
Implemented add bookmark for XEP-0223
...
Issue #194
2014-02-02 02:39:36 +00:00
James Booth
95c48a0f47
Test message when removing autojoin for non existent bookmark
2014-02-02 01:05:52 +00:00
James Booth
9d957e5f93
Show message on /bookmark remove when bookmark does not exist
2014-02-02 00:59:32 +00:00
James Booth
92b85bb7f1
Added message when bookmark updated
2014-02-02 00:49:02 +00:00
James Booth
12666b41e6
Refactored handle_presence_error, removed no longer used functions
2014-01-30 22:20:57 +00:00
