aniani/profanity
1
0
Fork 0
mirror of https://github.com/profanity-im/profanity.git synced 2024-12-04 14:46:46 -05:00
Code

python_api.c: enlarge c_arguments array to avoid OOB write

Browse Source 
Code below explicitly refers past `args_len`th element:

        c_arguments[args_len][0] = NULL;
        c_arguments[args_len][1] = NULL;

Let's always allocate space for `NULL`. Noticed by Steffen Jaeckel.
This commit is contained in:
Sergei Trofimovich 2021-11-26 07:51:49 +00:00
parent a77a57a6a4
commit f0a39a4b66
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/python_api.c
View File

@ -158,7 +158,7 @@ python_api_register_command(PyObject* self, PyObject* args)
c_synopsis[len] = NULL; c_synopsis[len] = NULL;
Py_ssize_t args_len = PyList_Size(arguments); Py_ssize_t args_len = PyList_Size(arguments);
char* c_arguments[args_len == 0 ? 0 : args_len + 1][2]; char* c_arguments[args_len + 1][2];
for (i = 0; i < args_len; i++) { for (i = 0; i < args_len; i++) {
PyObject* item = PyList_GetItem(arguments, i); PyObject* item = PyList_GetItem(arguments, i);
Py_ssize_t len2 = PyList_Size(item); Py_ssize_t len2 = PyList_Size(item);