aniani/profanity
1
0
Fork 0
mirror of https://github.com/profanity-im/profanity.git synced 2024-09-22 19:45:54 -04:00
Code

Fix segfault in block command

Browse Source 
Another case of double free() due to new destructor.

Fixes https://github.com/profanity-im/profanity/issues/1156
This commit is contained in:
Michael Vetter 2019-07-19 12:38:33 +02:00
parent 1bb05569b6
commit d3828cf24e
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/xmpp/blocking.c
View File

@ -235,18 +235,15 @@ _block_add_result_handler(xmpp_stanza_t *const stanza, void *const userdata)
const char *type = xmpp_stanza_get_type(stanza);
if (!type) {
log_info("Block response received for %s with no type attribute.", jid);
free(jid);
return 0;
}
if (g_strcmp0(type, "result") != 0) {
log_info("Block response received for %s with unrecognised type attribute.", jid);
free(jid);
return 0;
}
cons_show("User %s successfully blocked.", jid);
free(jid);
return 0;
}
@ -259,18 +256,15 @@ _block_remove_result_handler(xmpp_stanza_t *const stanza, void *const userdata)
const char *type = xmpp_stanza_get_type(stanza);
if (!type) {
log_info("Unblock response received for %s with no type attribute.", jid);
free(jid);
return 0;
}
if (g_strcmp0(type, "result") != 0) {
log_info("Unblock response received for %s with unrecognised type attribute.", jid);
free(jid);
return 0;
}
cons_show("User %s successfully unblocked.", jid);
free(jid);
return 0;
}