aniani/profanity
1
0
Fork 0
mirror of https://github.com/profanity-im/profanity.git synced 2024-12-04 14:46:46 -05:00
Code

Fix use-after-free which is introduced in cons_alert()

Browse Source 
Commit f12161f fixes memory leak, but introduces use-after-free issue.
Allocate new memory for win_name with g_strdup() since it is freed with
g_free() later.
This commit is contained in:
Dmitry Podgorny 2020-10-09 13:39:52 +03:00
parent a80b5603a4
commit 64df8630d4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/ui/console.c
View File

@ -2408,7 +2408,7 @@ cons_alert(ProfWin* alert_origin_window)
GList* item = g_list_find_custom(alert_list, win_name, (GCompareFunc)g_strcmp0); GList* item = g_list_find_custom(alert_list, win_name, (GCompareFunc)g_strcmp0);
if (!item) { if (!item) {
alert_list = g_list_append(alert_list, win_name); alert_list = g_list_append(alert_list, g_strdup(win_name));
} }
free(win_name); free(win_name);