aniani/profanity
1
0
Fork 0
mirror of https://github.com/profanity-im/profanity.git synced 2024-12-04 14:46:46 -05:00
Code

Removed TODOs

Browse Source
This commit is contained in:
James Booth 2014-12-20 18:48:35 +00:00
parent 6800bf1cad
commit 39aae7f548
5 changed files with 0 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/command/commands.c
View File

@ -1130,11 +1130,9 @@ cmd_msg(gchar **args, struct cmd_help_t help)
g_string_append(full_jid, usr); g_string_append(full_jid, usr);
if (msg != NULL) { if (msg != NULL) {
// TODO use message send private
message_send_private(full_jid->str, msg); message_send_private(full_jid->str, msg);
ui_outgoing_private_msg("me", full_jid->str, msg); ui_outgoing_private_msg("me", full_jid->str, msg);
} else { } else {
// TODO use new private win
ui_new_private_win(full_jid->str); ui_new_private_win(full_jid->str);
} }
@ -1146,7 +1144,6 @@ cmd_msg(gchar **args, struct cmd_help_t help)
return TRUE; return TRUE;
// TODO handle different window types (OTR only for chat etc)
} else { } else {
char *usr_jid = roster_barejid_from_name(usr); char *usr_jid = roster_barejid_from_name(usr);
if (usr_jid == NULL) { if (usr_jid == NULL) {
@ -2943,7 +2940,6 @@ cmd_alias(gchar **args, struct cmd_help_t help)
} }
} }
// TODO reuse cmd_msg
gboolean gboolean
cmd_tiny(gchar **args, struct cmd_help_t help) cmd_tiny(gchar **args, struct cmd_help_t help)
{ {

5
src/ui/core.c
View File

@ -936,7 +936,6 @@ _ui_next_win(void)
} }
} }
// TODO move OTR UI to new module
static void static void
_ui_gone_secure(const char * const barejid, gboolean trusted) _ui_gone_secure(const char * const barejid, gboolean trusted)
{ {
@ -1183,8 +1182,6 @@ _ui_prune_wins(void)
GSList *curr = wins; GSList *curr = wins;
while (curr != NULL) { while (curr != NULL) {
ProfWin *window = curr->data; ProfWin *window = curr->data;
// TODO move to ui_close_win
if (window->type == WIN_CHAT) { if (window->type == WIN_CHAT) {
if (conn_status == JABBER_CONNECTED) { if (conn_status == JABBER_CONNECTED) {
if (prefs_get_boolean(PREF_STATES)) { if (prefs_get_boolean(PREF_STATES)) {
@ -1200,7 +1197,6 @@ _ui_prune_wins(void)
} }
} }
// TODO make one function
int num = wins_get_num(window); int num = wins_get_num(window);
ui_close_win(num); ui_close_win(num);
@ -1990,7 +1986,6 @@ _ui_leave_room(const char * const roomjid)
} }
} }
// TODO move to muc ui module
static void static void
_ui_room_destroyed(const char * const roomjid, const char * const reason, const char * const new_jid, _ui_room_destroyed(const char * const roomjid, const char * const reason, const char * const new_jid,
const char * const password) const char * const password)

2
src/ui/ui.h
View File

@ -76,7 +76,6 @@ void (*ui_gone_secure)(const char * const barejid, gboolean trusted);
void (*ui_gone_insecure)(const char * const barejid); void (*ui_gone_insecure)(const char * const barejid);
void (*ui_trust)(const char * const barejid); void (*ui_trust)(const char * const barejid);
void (*ui_untrust)(const char * const barejid); void (*ui_untrust)(const char * const barejid);
// TODO rename other recipients to barejid etc
void (*ui_smp_recipient_initiated)(const char * const barejid); void (*ui_smp_recipient_initiated)(const char * const barejid);
void (*ui_smp_recipient_initiated_q)(const char * const barejid, const char *question); void (*ui_smp_recipient_initiated_q)(const char * const barejid, const char *question);
@ -139,7 +138,6 @@ void (*ui_outgoing_private_msg)(const char * const from, const char * const full
void (*ui_room_join)(const char * const roomjid, gboolean focus); void (*ui_room_join)(const char * const roomjid, gboolean focus);
void (*ui_switch_to_room)(const char * const roomjid); void (*ui_switch_to_room)(const char * const roomjid);
// TODO change all room -> roomjid
void (*ui_room_role_change)(const char * const roomjid, const char * const role, const char * const actor, void (*ui_room_role_change)(const char * const roomjid, const char * const role, const char * const actor,
const char * const reason); const char * const reason);
void (*ui_room_affiliation_change)(const char * const roomjid, const char * const affiliation, const char * const actor, void (*ui_room_affiliation_change)(const char * const roomjid, const char * const affiliation, const char * const actor,

20
src/ui/windows.c
View File

@ -345,26 +345,6 @@ wins_get_previous(void)
} }
} }
// TODO REMOVE
//ProfWin *
//wins_get_by_recipient(const char * const recipient)
//{
// GList *values = g_hash_table_get_values(windows);
// GList *curr = values;
//
// while (curr != NULL) {
// ProfWin *window = curr->data;
// if (g_strcmp0(window->from, recipient) == 0) {
// g_list_free(values);
// return window;
// }
// curr = g_list_next(curr);
// }
//
// g_list_free(values);
// return NULL;
//}
int int
wins_get_num(ProfWin *window) wins_get_num(ProfWin *window)
{ {

3
src/ui/windows.h
View File

@ -49,9 +49,6 @@ ProfMucWin * wins_get_muc(const char * const roomjid);
ProfMucConfWin * wins_get_muc_conf(const char * const title); ProfMucConfWin * wins_get_muc_conf(const char * const title);
ProfPrivateWin *wins_get_private(const char * const fulljid); ProfPrivateWin *wins_get_private(const char * const fulljid);
// TODO remove
//ProfWin * wins_get_by_recipient(const char * const recipient);
ProfWin * wins_get_current(void); ProfWin * wins_get_current(void);
ProfChatWin * wins_get_current_chat(void); ProfChatWin * wins_get_current_chat(void);
ProfMucWin * wins_get_current_muc(void); ProfMucWin * wins_get_current_muc(void);