aniani/profanity
1
0
Fork 0
mirror of https://github.com/profanity-im/profanity.git synced 2024-12-04 14:46:46 -05:00
Code

Refactor _cmd_set_boolean_preference

Browse Source 
Only compute string if necessary.
This commit is contained in:
Michael Vetter 2019-12-19 19:25:58 +01:00
parent 808850c6f5
commit 1f809e5210
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/command/cmd_funcs.c
View File

@ -8105,26 +8105,27 @@ static void
_cmd_set_boolean_preference(gchar *arg, const char *const command, _cmd_set_boolean_preference(gchar *arg, const char *const command,
const char *const display, preference_t pref) const char *const display, preference_t pref)
{ {
GString *enabled = g_string_new(display);
g_string_append(enabled, " enabled.");
GString *disabled = g_string_new(display);
g_string_append(disabled, " disabled.");
if (arg == NULL) { if (arg == NULL) {
cons_bad_cmd_usage(command); cons_bad_cmd_usage(command);
} else if (strcmp(arg, "on") == 0) { } else if (strcmp(arg, "on") == 0) {
GString *enabled = g_string_new(display);
g_string_append(enabled, " enabled.");
cons_show(enabled->str); cons_show(enabled->str);
prefs_set_boolean(pref, TRUE); prefs_set_boolean(pref, TRUE);
g_string_free(enabled, TRUE);
} else if (strcmp(arg, "off") == 0) { } else if (strcmp(arg, "off") == 0) {
GString *disabled = g_string_new(display);
g_string_append(disabled, " disabled.");
cons_show(disabled->str); cons_show(disabled->str);
prefs_set_boolean(pref, FALSE); prefs_set_boolean(pref, FALSE);
g_string_free(disabled, TRUE);
} else { } else {
cons_bad_cmd_usage(command); cons_bad_cmd_usage(command);
} }
g_string_free(enabled, TRUE);
g_string_free(disabled, TRUE);
} }
gboolean gboolean