Joseph Bisch
0840eaec7b
Make split functions return an array with NULL instead of NULL
...
This avoids undefined behavior in functions that call these split
functions and expect an array back instead of just a NULL pointer.
2017-10-20 15:22:32 +02:00
Nei
f4c8018cfb
Merge branch 'fix-gl-13' into 'security'
...
Fix use after free when channel is destroyed inbetween being synced
See merge request irssi/irssi!19
2017-10-20 15:22:32 +02:00
Joseph Bisch
beb2beba3b
Revert "Don't proceed with cmd_msg if there was an error splitting msg"
...
This reverts commit bd83852d646de28f2e0fe01efe7c9236aa4074d4.
2017-10-20 15:22:32 +02:00
Nei
e37d9b2497
Merge branch 'fix-gl-12' into 'security'
...
fix out of bounds read in compress_colors
See merge request irssi/irssi!18
2017-10-20 15:22:32 +02:00
Joseph Bisch
73d7b9d775
Don't proceed with cmd_msg if there was an error splitting msg
...
There may be cases (such as if target or server->nick is very long)
where the split_message function returns NULL, indicating an error. To
avoid a potential segfault, we now check to see if splitmsgs is NULL.
2017-10-20 15:22:32 +02:00
ailin-nemui
9f0dc4766c
fix dcc issue
2017-10-20 15:14:10 +02:00
LemonBoy
45dfe2ba38
Prevent a OOB read when parsing IRCNet ! channels
...
Make sure the string has enough data.
Fixes #16
2017-10-19 11:17:56 +02:00
LemonBoy
28d0b8c746
Merge pull request #771 from paultownsend/issue-120
...
Add alternate_nick as a network-specific property
2017-10-18 12:00:56 +02:00
Paul Townsend
7b94015f8f
Changes based on comments in pull #771 .
2017-10-14 17:42:45 +01:00
Will Storey
233be9f580
Mark net_ip_compare() deprecated
2017-10-13 18:30:57 -07:00
Will Storey
da59fd7c2d
Revert "Delete unused function net_ip_compare()"
...
This reverts commit cb5f3cba1f
.
2017-10-13 18:28:26 -07:00
ailin-nemui
7b97edf9d1
Merge pull request #769 from horgh/horgh/error-check-server-connect
...
Set host to an empty string on error
2017-10-13 17:14:47 +02:00
Edward Tomasz Napierała
b2865d6bcc
Merge pull request #772 from trasz/capsicum
...
Merge a bunch of Capsicum-related tweaks.
2017-10-13 10:33:43 +01:00
Edward Tomasz Napierala
711b2d7df7
Document that one needs to change the awaylog_file path for "/away"
...
to work with Capsicum.
2017-10-11 23:53:41 +01:00
Edward Tomasz Napierala
9895e7b28a
Silence down a warning that would appear on "/away" in Capability mode.
2017-10-11 23:52:36 +01:00
Edward Tomasz Napierala
5c0b4aeb05
Sort Capsicum headers.
2017-10-11 23:31:26 +01:00
Edward Tomasz Napierala
1e66cbd62e
Improve Capsicum stdio limits to fix terminal state on exit.
2017-10-11 23:13:06 +01:00
Paul Townsend
87955b69cb
Add alternate_nick as a network-specific property.
2017-10-11 21:33:14 +01:00
Edward Tomasz Napierala
17b195021d
Bump default capsicum_port_max to 9999.
...
This is needed for servers like ssl.efnet.org, which, per default
config, listen on 9999.
2017-10-11 14:34:38 +01:00
Will Storey
174adee9dd
Always initialize the host string
...
This also removes a wordy comment
2017-10-10 18:21:05 -07:00
Will Storey
b8b90c76d4
Delete unused function net_connect()
2017-10-09 13:20:44 -07:00
Will Storey
3b3939b146
Delete commented out CYGWIN define
2017-10-09 13:14:59 -07:00
Will Storey
cb5f3cba1f
Delete unused function net_ip_compare()
2017-10-09 13:14:34 -07:00
Will Storey
4ccff71f67
Set host to an empty string on error
...
While investigating #317 , I noticed that it was possible we would access
an uninitialized buffer due to failing to check the return value of
net_ip2host(). This is done in several places. To make such uses safe,
set the host buffer to an empty string on error. It is possible callers
could be improved by handling the error in each spot, but this gives us
some safety.
2017-10-09 12:50:04 -07:00
Joseph Bisch
2edd816e7d
Fix segfault in query_remove_all
...
It is possible for rec to be NULL in query_remove_all, resulting in a
segfault. So return without doing anything if rec is NULL.
2017-10-08 22:02:44 -04:00
ailin-nemui
49ace3251b
fix uaf in chanquery module
...
the chanquery needs to be removed in any case if a channel rec is
destroyed, regardless of any state
Fixes GL#13
2017-10-08 19:48:11 +02:00
ailin-nemui
016fd34436
Merge pull request #763 from rbisewski/master
...
Improvements to statusbar documentation and help text.
2017-10-08 18:50:19 +02:00
ailin-nemui
00c80cb6fc
fix out of bounds read in compress_colors
...
Reported by Hanno Böck.
Fixes GL#12
2017-10-07 20:48:53 +02:00
Edward Tomasz Napierala
40ae8f5fa6
Limit capsicum rights to stdio.
...
This requires FreeBSD fix (https://reviews.freebsd.org/D12622 )
to work properly.
2017-10-07 03:28:02 +01:00
ailin-nemui
5da0b73a12
up abi
2017-10-06 15:31:59 +02:00
ailin-nemui
deac66f33c
add a key binding to erase history entries
...
it is possible to delete the current history entry using the
erase_history_entry key binding
2017-10-06 15:31:52 +02:00
ailin-nemui
16d68a86ca
add two XSFuncs to manipulate command history entries
...
it is possible to use Irssi::UI::Window::get_history_entries to save the
history entries, load_history_entries to load entries into the command
history and delete_history_entries to remove history entries (for example
to remove history selectively)
2017-10-06 15:02:15 +02:00
ailin-nemui
1fd285dccf
refactor history to use history_entries list
...
this allows access to the global history even when a using /window history
named or /set window_history on, and you want to recall something from one
of the other windows' histories.
usage (default): ctrl+up/down
2017-10-06 14:58:47 +02:00
Robert Bisewski
4b42eca7c5
minor word correction
2017-10-06 07:58:27 -05:00
Robert Bisewski
84bfea52af
adjusting text content as per the pull-request discussion
2017-10-06 07:54:54 -05:00
Robert Bisewski
0883ff8d32
reverting changes to startup HOWTO
2017-10-06 07:13:30 -05:00
Robert Bisewski
e1e632d31e
correcting and expanding content of statusbar help text
2017-10-05 22:47:15 -05:00
ailin-nemui
92dbb1895b
Merge pull request #754 from ailin-nemui/fix-752
...
add new function to set the position in bytes
2017-10-05 11:31:44 +02:00
ailin-nemui
1f7de4c3bd
up abi
2017-10-05 11:31:33 +02:00
Robert Bisewski
32f33e7bb3
improving HOWTO document
2017-10-03 22:49:21 -05:00
ailin-nemui
8dfeca57ed
hidden lines
2017-09-21 14:20:31 +02:00
ailin-nemui
0468c5d912
add new function to set the position in bytes
...
fixes #752
2017-09-15 13:47:01 +02:00
ailin-nemui
fc8c15fcd7
Merge pull request #755 from trasz/capsicum
...
Get rid of the zombies in Capsicum capability mode.
2017-09-15 13:40:17 +02:00
ailin-nemui
ca1172b4d0
Merge pull request #751 from LemonBoy/ssl-refcnt
...
Increment the X509_STORE refcount during the connection
2017-09-13 10:32:38 +02:00
Edward Tomasz Napierala
624ef4a696
Get rid of the zombies in Capsicum capability mode.
...
Signed-off-by: Edward Tomasz Napierala <trasz@FreeBSD.org>
2017-09-12 14:19:17 +01:00
LemonBoy
36d8b974fc
Restore compatibility with old OpenSSL versions
...
Let's implement X509_STORE_up_ref on our own.
2017-09-11 17:19:20 +02:00
LemonBoy
96d5a4669d
Increment the X509_STORE refcount during the connection
...
OpenSSL doesn't increment the reference count when the store is assigned
to a SSL_CTX.
2017-09-11 16:32:36 +02:00
ailin-nemui
24ad80177b
Merge pull request #735 from trasz/capsicum
...
Add Capsicum support
2017-09-10 19:43:59 +02:00
Edward Tomasz Napierala
b529e1a9df
Fix /back in Capsicum capability mode.
...
Signed-off-by: Edward Tomasz Napierala <trasz@FreeBSD.org>
2017-09-08 13:14:24 +01:00
ailin-nemui
be70fa5eb7
Merge pull request #741 from LemonBoy/complete
...
Complete filenames ending with a slash
2017-09-05 10:17:22 +02:00