Ailin Nemui
18a1a0ba7c
fix multiple identical active caps
2021-01-06 10:41:57 +01:00
ailin-nemui
b8be290640
Update src/irc/core/lag.c
...
Co-Authored-By: dx <dx@dxzone.com.ar>
2020-01-08 10:15:47 +01:00
ailin-nemui
1cdb4bc311
remove GTimeVal following glib 2.61.2 deprecation
2019-12-06 10:56:25 +01:00
dequis
664c38afba
Fix some glib deprecation warnings
...
Most of these have been deprecated since forever (2.2), but they didn't
raise warnings. Now they do, and the warnings are not the most verbose
warnings you could ask for, but, they point in the right direction.
This doesn't handle the GTimeVal deprecation warnings. Those seem
trickier since they cover API, will look into those right after this.
2019-10-31 23:49:40 +01:00
ailin-nemui
03eb8d032a
fix the fix
2019-10-01 11:09:25 +02:00
Joseph Bisch
ed65499d76
Add missing g_string_free param
2019-09-26 21:51:36 -04:00
Joseph Bisch
f6cca3de4e
Properly free sasl_buffer GString
2019-09-24 21:35:40 -04:00
ailin-nemui
8a1a96c12c
Merge pull request #1120 from ailin-nemui/invalid-cap-free
...
free params
2019-09-16 11:42:48 +02:00
ailin-nemui
f875d252d2
fix crash in join due to incorrect free
2019-09-04 14:57:56 +02:00
ailin-nemui
6d58052c4a
enable self-message support
2019-09-04 14:27:06 +02:00
ailin-nemui
948e7bb317
free params
2019-08-30 22:14:26 +02:00
ailin-nemui
5a4e7ab659
fix use after free receiving caps
...
fixes GL#34
2019-08-27 23:34:03 +02:00
ailin-nemui
3f0afa91f3
Merge pull request #1092 from ailin-nemui/outgoing-tags
...
sending of tag messages and customisable maximum irc message length
2019-08-26 22:01:53 +02:00
ailin-nemui
54781a34ee
Merge pull request #1101 from ailin-nemui/auto
...
fix autotools build
2019-08-19 15:35:33 +02:00
ailin-nemui
d5329bc811
fix crashes when nick is missing
2019-08-16 21:37:53 +02:00
ailin-nemui
255d850c4d
fix crash in setname
2019-08-16 21:19:40 +02:00
ailin-nemui
b6f1bf8fcd
fix autotools build
2019-08-15 21:44:33 +02:00
ailin-nemui
44d480ca99
use account-notify capability
2019-08-15 17:30:38 +02:00
ailin-nemui
4dbbbf47a4
add chghost capability support
2019-08-15 17:26:20 +02:00
ailin-nemui
61d215acdd
support cap away-notify
2019-08-15 16:43:17 +02:00
ailin-nemui
6c37099407
more variables
2019-08-15 16:39:26 +02:00
ailin-nemui
200020da93
use better number parsing
2019-08-15 16:33:50 +02:00
ailin-nemui
da9adec47f
sending of tag messages and customisable maximum irc message length
2019-08-15 16:33:50 +02:00
ailin-nemui
d418989f0c
Merge pull request #1090 from ailin-nemui/incoming-tags
...
incoming irc message tags support
2019-08-15 16:32:01 +02:00
ailin-nemui
2576064982
add missing signal_remove
2019-08-15 10:57:54 +02:00
ailin-nemui
eb3a44a713
clarifying comment
2019-08-15 10:56:15 +02:00
ailin-nemui
24154ced0d
irc message tags support
2019-08-15 10:56:15 +02:00
ailin-nemui
e62e55c0ab
show invites of other users when provided
2019-08-14 23:55:40 +02:00
ailin-nemui
47518b4b75
request the setname capability
2019-08-14 23:40:39 +02:00
ailin-nemui
6e32c1f638
Merge pull request #1097 from ailin-nemui/cap-extended-joins
...
use extended-join capability
2019-08-14 21:08:11 +02:00
ailin-nemui
0a12bf682d
Merge pull request #1095 from ailin-nemui/cap-queue
...
fix cap queue order
2019-08-14 17:58:52 +02:00
ailin-nemui
4ae1dbbd00
fix cap queue order
2019-08-14 16:34:18 +02:00
ailin-nemui
25270e0465
use extended-join capability
2019-08-13 18:23:34 +02:00
ailin-nemui
27546354ca
increase disconnect buffer and get rid of some magic 510 values
2019-08-13 18:17:35 +02:00
ailin-nemui
d512647b3f
use symbolic defines for capability strings
2019-08-13 17:36:20 +02:00
ailin-nemui
e0ff13f6c1
enable irc cap ls 302
2019-08-13 17:26:51 +02:00
Zero King
dde5fff4a5
Fix memory leaks
2019-07-27 18:34:03 +00:00
ailin-nemui
6277ccf67f
manually maintain irc loader
2019-07-18 18:04:42 +02:00
Ailin Nemui
00a7efc69f
modularise irc component
2019-07-17 13:37:19 +02:00
Ailin Nemui
db16a0a853
meson build support
2019-07-10 09:25:26 +02:00
ailin-nemui
5a67b983dc
copy sasl username and password values
2019-06-17 15:22:27 +02:00
ailin-nemui
4a3a064d55
fix reconnect of multiplexed proxy
2019-05-07 13:37:31 +02:00
ailin-nemui
37f7c7f374
update include guard names
2019-05-01 22:22:22 +02:00
ailin-nemui
7e6e1f2e10
Use full paths to includes
2019-05-01 22:08:45 +02:00
Will Storey
c25d24220f
Remove unused functions
2019-02-18 11:53:46 -08:00
Jaroslav Škarvada
4f26ad74f5
Fixed problem found by Coverity Scan
...
Fixes #981
Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
2018-12-04 21:07:06 +01:00
Calvin Buckley
482a3a5bdd
Remove unneeded comment
2018-11-26 09:56:04 -04:00
Calvin Buckley
a634b34ba4
Rename cap_* funcs to irc_cap_*
...
Some systems often "namespace" cap_ for themselves, and so irssi's
usage can conflict with their own. Bump ABI for this.
2018-11-25 14:50:47 +00:00
Calvin Buckley
4380f3820e
Fix compilation of irc/core on AIX and IBM i
...
There's a function in the standard library of these OSes that conflict
with this function. Prefix it with `irc_`.
2018-11-19 13:58:51 +00:00
ailin-nemui
6ca13dd5cd
Merge pull request #905 from horgh/horgh/topic-regression
...
Add tests for topic events
2018-10-17 12:31:52 +02:00
ailin-nemui
8b1afbd355
revert core changes
2018-10-06 20:05:54 +02:00
ailin-nemui
c80946bcf5
Disconnect SASL properly in case the sasl module got unloaded from server
...
stops from getting on the network when sasl is unavailable
fixes #629
2018-09-04 15:50:58 +02:00
ailin-nemui
afb3daaf65
Merge pull request #919 from ailin-nemui/uafs
...
Use-after-frees
2018-09-04 09:35:47 +02:00
Will Storey
b11932d24f
Make channel event functions static again
2018-08-27 21:04:23 -07:00
Will Storey
2ccb312b8b
Expose functions for testing
2018-08-27 20:51:18 -07:00
Will Storey
04db359a6d
Handle topic info numeric separately from topic & topic numeric
...
As we called the same function for the topic info numeric, we ended up
losing the topic as that numeric does not include it. We now call a
different function to handle this case more carefully. Fixes #903 .
2018-08-27 20:51:18 -07:00
Will Storey
bbca1a5a0f
Revert "Revert "Flag topic as unset if it is zero length""
...
This reverts commit 817179a760
.
2018-08-27 20:50:17 -07:00
dequis
ade2f87fe5
Fix use after free introduced by the use after free patch
2018-08-24 02:19:42 -03:00
coypu@sdf.org
610ab2dafa
Use-after-frees
...
Hi folks!
I tried clang-static-analyzer on irssi 1.1.1, it seems like it
finds some things. Here's a diff, but there might be more that you would
want to check, or choose to work differently.
(in special-vars.c, ret is commands->data sometime)
I hope it's not too much trouble if reported as a confidential bug.
Thanks.
2018-08-23 14:13:48 +02:00
dequis
24f1ed7edb
irc-cap: Don't show warning on CAP LIST response
2018-08-23 03:22:30 -03:00
ailin-nemui
817179a760
Revert "Flag topic as unset if it is zero length"
2018-08-13 14:43:25 +02:00
dequis
b114b11e36
channel_change_topic: change one strlen == 0 to *str == '\0'
2018-07-30 23:45:56 -03:00
Will Storey
15840ac27b
If we receive a 0 length topic, record it as unset
...
Fixes #888 .
Previously we showed that there was a topic set when using /topic, just
an empty one. This was different than how we show such topics when
initially joining a channel. Now we say that the topic is unset in both
cases.
2018-07-24 18:45:22 -07:00
Will Storey
0e187cf9cf
Fix typo in comment
2018-07-24 18:29:31 -07:00
dequis
af5ee997e7
Add "server cap req" signal, emitted before requesting caps
2018-04-08 01:24:48 -03:00
ailin-nemui
7d99ff05cd
Merge pull request #803 from ailin-nemui/bug-796-test
...
Postpone server cleanup until after unref
2018-03-20 10:30:01 +01:00
ailin-nemui
c01f6df957
Merge pull request #844 from CatboxParadox/perms
...
dcc get shouldn't fail when file attrs can't be changed
2018-02-13 11:10:21 +01:00
Nei
b0d9cb33cd
Merge branch 'security' into 'master'
...
Security
See merge request irssi/irssi!34
2018-02-13 09:51:22 +00:00
Staron, Martin
3cbcb4fe85
dcc get shouldn't fail when file attrs can't be changed
2018-02-13 08:15:39 +01:00
ailin-nemui
16912e1a91
restore compat with glib <2.40
2018-02-08 14:41:08 +01:00
ailin-nemui
84f03e0146
do not reuse sasl timeout
2018-02-02 11:43:23 +01:00
LemonBoy
260733475c
Accept CAPs with an empty value (KEY=)
2018-01-24 10:55:20 +01:00
LemonBoy
474ee8ee70
Address some minor stylish nits
2018-01-24 10:45:54 +01:00
LemonBoy
fed791ed91
Fix a problem with multiline responses
...
Do not clear the whole table every time a response is received.
2018-01-07 12:36:21 +01:00
LemonBoy
4b9fcbc15a
Nicer error message when a duplicate CAP in LS
2018-01-07 12:36:21 +01:00
LemonBoy
f3a5355648
Match LS instead of checking the first letter only
2018-01-07 12:36:21 +01:00
LemonBoy
6c45ab0493
Command names may be in lower-case
...
Do not take the string case into account when comparing the command
name.
2018-01-07 12:36:20 +01:00
LemonBoy
c00132ac4c
Simplify the code
...
Early exit, simpler code.
2018-01-07 12:36:20 +01:00
LemonBoy
9160ddaffd
Keep processing the CAPs on error
...
If an invalid CAP is found we keep going by parsing the next one.
2018-01-07 12:36:20 +01:00
LemonBoy
cd107deb46
Prevent a memory leak
...
When a CAP DEL is received the key/val pair is not stored in the
hashtable at all so just free them when we're done.
2018-01-07 12:36:20 +01:00
LemonBoy
74409aa850
Miscellaneous fixes
...
Stylistic stuff, please ignore.
2018-01-07 12:36:20 +01:00
LemonBoy
f683e81880
Prevent a NULL pointer deference
...
Always create the cap_supported table when a CAP event is received.
2018-01-07 12:36:20 +01:00
LemonBoy
432368bdc6
Use strcmp instead of g_strcmp0
...
There's no need to use the latter.
2018-01-07 12:36:19 +01:00
LemonBoy
cfc8c9f8e2
Properly dispose the GSList chains
...
We forgot to free the link and the data, oops.
2018-01-07 12:36:19 +01:00
LemonBoy
f4d811ddf5
Handle CAP {ADD,DEL} from cap-notify
...
This is the last piece of the puzzle.
2018-01-07 12:36:19 +01:00
LemonBoy
8c87766132
Parse multiline responses to CAP LS
...
The parsing logic isn't too elegant because of the optional parameter
used for signaling if a response has a continuation one.
2018-01-07 12:36:19 +01:00
LemonBoy
57827ca743
Don't free the hash table if there's none
...
Glib doesn't like that and shows a harmless warning.
2018-01-07 12:36:18 +01:00
LemonBoy
d21706e1cc
Factor out the parsing function
...
This is also needed for CAP NEW and CAP DEL.
2018-01-07 12:36:18 +01:00
LemonBoy
98836f8b7e
Parse the K/V form in CAP LS
...
This is a prerequisite for the IRC v3.2 compliance.
2018-01-07 12:36:18 +01:00
ailin-nemui
e7cce90ec0
Merge pull request #804 from ailin-nemui/patch-1
...
handle an already used nick different from the one we send
2018-01-07 11:23:42 +01:00
ailin-nemui
3c7185c5ad
Update irc-nicklist.c
...
move altnick check before the nick correction code
2018-01-05 00:38:54 +01:00
ailin-nemui
c9b3d87eb7
Postpone server cleanup until after unref
...
Add a new signal, server destroyed, that is supposed to run the clean up
tasks of server disconnected. This is so that some structures will stay
around longer.
2018-01-04 23:04:12 +01:00
ailin-nemui
54d453623d
do not record topic change time when sender is blank
2018-01-03 12:45:43 +01:00
ailin-nemui
48e909dde7
Merge pull request #766 from horgh/horgh/mode-parsing
...
Fix MODE parameter parsing
2017-12-11 23:48:23 +01:00
Will Storey
b0637ad6ea
Update NULL comparison style and be C89 compatible
2017-12-02 10:09:52 -08:00
ailin-nemui
b332d448f7
fix comments
2017-11-30 11:15:47 +01:00
Will Storey
1a49787ef2
Revert initializing pointers to NULL
...
To maintain C89 compatibility
2017-11-27 19:37:11 -08:00
ailin-nemui
02c677f467
use enum
2017-11-10 22:02:36 +01:00
ailin-nemui
b0fa4dd46d
show initial nick and name on first start
2017-11-01 15:51:20 +01:00
Will Storey
8843d4f77d
Strip : from <trailing> parameters
...
This is to fix #601 . The function used to extract the mode string
assumed that ":" would only occur in a particular spot. This lead to the
possibility that ":" could be treated as part of things like nicknames
or mode arguments, where it should have been stripped as part of
protocol escaping.
2017-10-24 19:51:01 -07:00