aniani/irssi
1
0
Fork 0
mirror of https://github.com/irssi/irssi.git synced 2024-11-03 04:27:19 -05:00
Code
6,215 Commits 7 Branches 77 Tags 12 MiB
b5ddc55fe6
Commit Graph

1050 Commits

Author SHA1 Message Date
Calvin Buckley
482a3a5bdd
Remove unneeded comment 2018-11-26 09:56:04 -04:00
Calvin Buckley
a634b34ba4 Rename cap_* funcs to irc_cap_* 
Some systems often "namespace" cap_ for themselves, and so irssi's
usage can conflict with their own. Bump ABI for this.
 2018-11-25 14:50:47 +00:00
Calvin Buckley
4380f3820e Fix compilation of irc/core on AIX and IBM i 
There's a function in the standard library of these OSes that conflict
with this function. Prefix it with `irc_`.
 2018-11-19 13:58:51 +00:00
ailin-nemui
6ca13dd5cd
Merge pull request #905 from horgh/horgh/topic-regression 
Add tests for topic events
 2018-10-17 12:31:52 +02:00
ailin-nemui
8b1afbd355 revert core changes 2018-10-06 20:05:54 +02:00
ailin-nemui
c80946bcf5 Disconnect SASL properly in case the sasl module got unloaded from server 
stops from getting on the network when sasl is unavailable

fixes #629
 2018-09-04 15:50:58 +02:00
ailin-nemui
afb3daaf65
Merge pull request #919 from ailin-nemui/uafs 
Use-after-frees
 2018-09-04 09:35:47 +02:00
Will Storey
b11932d24f Make channel event functions static again 2018-08-27 21:04:23 -07:00
Will Storey
2ccb312b8b Expose functions for testing 2018-08-27 20:51:18 -07:00
Will Storey
04db359a6d Handle topic info numeric separately from topic & topic numeric 
As we called the same function for the topic info numeric, we ended up
losing the topic as that numeric does not include it. We now call a
different function to handle this case more carefully. Fixes #903.
 2018-08-27 20:51:18 -07:00
Will Storey
bbca1a5a0f Revert "Revert "Flag topic as unset if it is zero length"" 
This reverts commit 817179a760.
 2018-08-27 20:50:17 -07:00
dequis
ade2f87fe5 Fix use after free introduced by the use after free patch 2018-08-24 02:19:42 -03:00
coypu@sdf.org
610ab2dafa Use-after-frees 
Hi folks!

I tried clang-static-analyzer on irssi 1.1.1, it seems like it
finds some things. Here's a diff, but there might be more that you would
want to check, or choose to work differently.

(in special-vars.c, ret is commands->data sometime)

I hope it's not too much trouble if reported as a confidential bug.
Thanks.
 2018-08-23 14:13:48 +02:00
dequis
24f1ed7edb irc-cap: Don't show warning on CAP LIST response 2018-08-23 03:22:30 -03:00
ailin-nemui
817179a760
Revert "Flag topic as unset if it is zero length" 2018-08-13 14:43:25 +02:00
dequis
b114b11e36 channel_change_topic: change one strlen == 0 to *str == '\0' 2018-07-30 23:45:56 -03:00
Will Storey
15840ac27b If we receive a 0 length topic, record it as unset 
Fixes #888.

Previously we showed that there was a topic set when using /topic, just
an empty one. This was different than how we show such topics when
initially joining a channel. Now we say that the topic is unset in both
cases.
 2018-07-24 18:45:22 -07:00
Will Storey
0e187cf9cf Fix typo in comment 2018-07-24 18:29:31 -07:00
dequis
af5ee997e7 Add "server cap req" signal, emitted before requesting caps 2018-04-08 01:24:48 -03:00
ailin-nemui
7d99ff05cd
Merge pull request #803 from ailin-nemui/bug-796-test 
Postpone server cleanup until after unref
 2018-03-20 10:30:01 +01:00
ailin-nemui
c01f6df957
Merge pull request #844 from CatboxParadox/perms 
dcc get shouldn't fail when file attrs can't be changed
 2018-02-13 11:10:21 +01:00
Nei
b0d9cb33cd Merge branch 'security' into 'master' 
Security

See merge request irssi/irssi!34
 2018-02-13 09:51:22 +00:00
Staron, Martin
3cbcb4fe85 dcc get shouldn't fail when file attrs can't be changed 2018-02-13 08:15:39 +01:00
ailin-nemui
16912e1a91 restore compat with glib <2.40 2018-02-08 14:41:08 +01:00
ailin-nemui
84f03e0146 do not reuse sasl timeout 2018-02-02 11:43:23 +01:00
LemonBoy
260733475c Accept CAPs with an empty value (KEY=) 2018-01-24 10:55:20 +01:00
LemonBoy
474ee8ee70 Address some minor stylish nits 2018-01-24 10:45:54 +01:00
LemonBoy
fed791ed91 Fix a problem with multiline responses 
Do not clear the whole table every time a response is received.
 2018-01-07 12:36:21 +01:00
LemonBoy
4b9fcbc15a Nicer error message when a duplicate CAP in LS 2018-01-07 12:36:21 +01:00
LemonBoy
f3a5355648 Match LS instead of checking the first letter only 2018-01-07 12:36:21 +01:00
LemonBoy
6c45ab0493 Command names may be in lower-case 
Do not take the string case into account when comparing the command
name.
 2018-01-07 12:36:20 +01:00
LemonBoy
c00132ac4c Simplify the code 
Early exit, simpler code.
 2018-01-07 12:36:20 +01:00
LemonBoy
9160ddaffd Keep processing the CAPs on error 
If an invalid CAP is found we keep going by parsing the next one.
 2018-01-07 12:36:20 +01:00
LemonBoy
cd107deb46 Prevent a memory leak 
When a CAP DEL is received the key/val pair is not stored in the
hashtable at all so just free them when we're done.
 2018-01-07 12:36:20 +01:00
LemonBoy
74409aa850 Miscellaneous fixes 
Stylistic stuff, please ignore.
 2018-01-07 12:36:20 +01:00
LemonBoy
f683e81880 Prevent a NULL pointer deference 
Always create the cap_supported table when a CAP event is received.
 2018-01-07 12:36:20 +01:00
LemonBoy
432368bdc6 Use strcmp instead of g_strcmp0 
There's no need to use the latter.
 2018-01-07 12:36:19 +01:00
LemonBoy
cfc8c9f8e2 Properly dispose the GSList chains 
We forgot to free the link and the data, oops.
 2018-01-07 12:36:19 +01:00
LemonBoy
f4d811ddf5 Handle CAP {ADD,DEL} from cap-notify 
This is the last piece of the puzzle.
 2018-01-07 12:36:19 +01:00
LemonBoy
8c87766132 Parse multiline responses to CAP LS 
The parsing logic isn't too elegant because of the optional parameter
used for signaling if a response has a continuation one.
 2018-01-07 12:36:19 +01:00
LemonBoy
57827ca743 Don't free the hash table if there's none 
Glib doesn't like that and shows a harmless warning.
 2018-01-07 12:36:18 +01:00
LemonBoy
d21706e1cc Factor out the parsing function 
This is also needed for CAP NEW and CAP DEL.
 2018-01-07 12:36:18 +01:00
LemonBoy
98836f8b7e Parse the K/V form in CAP LS 
This is a prerequisite for the IRC v3.2 compliance.
 2018-01-07 12:36:18 +01:00
ailin-nemui
e7cce90ec0
Merge pull request #804 from ailin-nemui/patch-1 
handle an already used nick different from the one we send
 2018-01-07 11:23:42 +01:00
ailin-nemui
3c7185c5ad
Update irc-nicklist.c 
move altnick check before the nick correction code
 2018-01-05 00:38:54 +01:00
ailin-nemui
c9b3d87eb7 Postpone server cleanup until after unref 
Add a new signal, server destroyed, that is supposed to run the clean up
tasks of server disconnected. This is so that some structures will stay
around longer.
 2018-01-04 23:04:12 +01:00
ailin-nemui
54d453623d do not record topic change time when sender is blank 2018-01-03 12:45:43 +01:00
ailin-nemui
48e909dde7
Merge pull request #766 from horgh/horgh/mode-parsing 
Fix MODE parameter parsing
 2017-12-11 23:48:23 +01:00
Will Storey
b0637ad6ea Update NULL comparison style and be C89 compatible 2017-12-02 10:09:52 -08:00
ailin-nemui
b332d448f7 fix comments 2017-11-30 11:15:47 +01:00
Will Storey
1a49787ef2 Revert initializing pointers to NULL 
To maintain C89 compatibility
 2017-11-27 19:37:11 -08:00
ailin-nemui
02c677f467 use enum 2017-11-10 22:02:36 +01:00
ailin-nemui
b0fa4dd46d show initial nick and name on first start 2017-11-01 15:51:20 +01:00
Will Storey
8843d4f77d Strip : from <trailing> parameters 
This is to fix #601. The function used to extract the mode string
assumed that ":" would only occur in a particular spot. This lead to the
possibility that ":" could be treated as part of things like nicknames
or mode arguments, where it should have been stripped as part of
protocol escaping.
 2017-10-24 19:51:01 -07:00
Nei
495bdd11cf Merge branch 'fix-16' into 'security' 
Prevent a OOB read when parsing IRCNet ! channels

See merge request irssi/irssi!22
 2017-10-20 13:23:28 +00:00
Nei
c46bed1e17 Merge branch 'fix-gl-15' into 'security' 
Don't proceed with cmd_msg if there was an error splitting msg

See merge request irssi/irssi!21
 2017-10-20 15:22:32 +02:00
Nei
3c2ae68073 Merge branch 'fix-dcc' into 'security' 
fix dcc

See merge request irssi/irssi!20
 2017-10-20 15:22:32 +02:00
Joseph Bisch
0840eaec7b Make split functions return an array with NULL instead of NULL 
This avoids undefined behavior in functions that call these split
functions and expect an array back instead of just a NULL pointer.
 2017-10-20 15:22:32 +02:00
Nei
f4c8018cfb Merge branch 'fix-gl-13' into 'security' 
Fix use after free when channel is destroyed inbetween being synced

See merge request irssi/irssi!19
 2017-10-20 15:22:32 +02:00
ailin-nemui
9f0dc4766c fix dcc issue 2017-10-20 15:14:10 +02:00
LemonBoy
45dfe2ba38 Prevent a OOB read when parsing IRCNet ! channels 
Make sure the string has enough data.
Fixes #16
 2017-10-19 11:17:56 +02:00
Paul Townsend
7b94015f8f Changes based on comments in pull #771. 2017-10-14 17:42:45 +01:00
Paul Townsend
87955b69cb Add alternate_nick as a network-specific property. 2017-10-11 21:33:14 +01:00
Joseph Bisch
2edd816e7d
Fix segfault in query_remove_all 
It is possible for rec to be NULL in query_remove_all, resulting in a
segfault. So return without doing anything if rec is NULL.
 2017-10-08 22:02:44 -04:00
ailin-nemui
49ace3251b fix uaf in chanquery module 
the chanquery needs to be removed in any case if a channel rec is
destroyed, regardless of any state

Fixes GL#13
 2017-10-08 19:48:11 +02:00
LemonBoy
d971c02920 Allow the user to clear the sasl-related fields 
There was no easy way for the user to disable the SASL authentication or
to clear the username/password once the network was created.
Closes #718
 2017-07-25 22:53:33 +02:00
Nei
200eb5922e Merge branch 'fix-gl9' into 'security' 
Fix dcc_request where addr is NULL

See merge request !13
 2017-05-30 19:39:06 +00:00
Joseph Bisch
528f51bfbe
Fix dcc_request where addr is NULL 2017-05-29 14:53:26 -04:00
Joseph Bisch
30a92754bb
Fix oob read of one byte in get_file_params_count{,_resume} 
We can use continue to handle cases such as:
"ab<space><space>c"
 2017-05-29 14:43:24 -04:00
ailin-nemui
7bd1b80687 fix dcc get 
fixes #656
 2017-03-07 23:27:08 +01:00
ailin-nemui
62fd3ac180 Revert "Quote the filename when dcc requests are auto accepted." 2017-03-06 11:27:55 +01:00
ailin-nemui
29f27cfb39 Merge pull request #658 from LemonBoy/dcc-autoaccept 
Quote the filename when dcc requests are auto accepted.
 2017-03-04 21:43:21 +01:00
LemonBoy
027acffb42 Handle file names with quotes. 
Let's repurpose escape_string and make it more flexible by letting us
choose the characters to escape.
 2017-02-22 11:49:09 +01:00
LemonBoy
db85ab7c90 Quote the filename when dcc requests are auto accepted. 
PR #453 forces the user to quote the filenames given to /DCC commands
when they contain spaces but the autoget functionality didn't get
updated so the filename was always passed without quotes.

Closes #656.
 2017-02-21 15:17:37 +01:00
dequis
15736ba5ab notify-ison: Don't send ison before the connection is done 2017-02-11 00:07:03 -03:00
LemonBoy
19c5178996 Prevent a memory leak during the processing of the SASL response. 
We also get rid of an allocation in the process of doing so.
 2017-01-24 22:19:50 +01:00
dx
b15c27cc63 Revert "Don't reset wait_cmd during connection registration (fixes early ISON)" 2017-01-10 03:09:36 -03:00
LemonBoy
38ea52d09f Merge pull request #608 from tijko/master 
Follow g_strsplit with call to g_strfreev
 2017-01-08 21:55:39 +01:00
Tim Konick
5917bc6f75 Follow g_strsplit with call to g_strfreev 2017-01-07 14:31:35 -08:00
dequis
1831a8e1a7 Don't reset wait_cmd during connection registration (fixes early ISON) 2017-01-06 12:49:56 -03:00
Nei
7a112e0217 Merge branch 'master' into 'security' 
Sync to master

See merge request !6
 2017-01-03 13:30:39 +01:00
Nei
124bcd4804 Merge branch '4-use-after-free-when-receiving-numeric-432-invalid-nick' into 'security' 
avoid server_disconnect

See merge request !4
 2017-01-02 17:01:29 +00:00
ailin-nemui
91f48c6f0e Merge pull request #586 from LemonBoy/fix-580 
Process the nick changes in queries before the PRIVMSG is handled.
 2017-01-02 14:44:07 +01:00
ailin-nemui
508d2e0860 bail out if nick is NULL in irc_query_find 
Closes #1
 2016-12-19 21:41:47 +01:00
ailin-nemui
77aab79057 avoid server_disconnect 
Closes #4
 2016-12-19 21:16:37 +01:00
LemonBoy
0d6add02cf Process the nick changes in queries before the PRIVMSG is handled. 
Otherwise we end up with the message in the status window since the
frontend knows jack shit about the casemapping option when it tries to
find the associated window for the query.
 2016-12-15 19:36:44 +01:00
LemonBoy
91c9e871c7 Add an option to stop the connection when SASL fails. 2016-12-12 21:41:06 +01:00
ailin-nemui
dcffa98d46 add a static buffer for dcc received data 
increased buffersize might make irssi freeze less / #159
 2016-11-23 17:02:29 +01:00
Alexander Færøy
2be7289085
Rename SSL to TLS. 
This patch changes the internal name of SSL to TLS. We also add -tls_*
options to /CONNECT and /SERVER, but make sure that the -ssl_* versions
of the commands continue to work like before.
 2016-10-22 20:36:50 +02:00
LemonBoy
3667fd9fd1 Make the cap_complete field unsigned. 
Fixes a problem where the field would end up as a negative number when
exposed to the perl scripts.
And move it near the other bit-packed fields so we take advantage of the
packing.
 2016-09-30 19:30:43 +02:00
ailin-nemui
8d4d313cc9 Merge pull request #506 from kruton/sasl-400-byte-chunk 
SASL: handle fragmentation
 2016-09-26 16:43:33 +02:00
Kenny Root
60d9ec621f SASL: handle fragmentation 
The IRCv3 SASL extension says that AUTHENTICATION payloads of exactly
400 bytes in length indicate that the message is fragmented and will
continue in a subsequent message. Handle the reassembly and splitting of
these messages so that we are compliant with the specification.
 2016-08-29 22:56:30 -07:00
dequis
3429c1a0a0 Set the default STATUSMSG to @ instead of @+ if it's missing 
This fixes two issues:

- IRCNet doesn't have STATUSMSG, but it supports +channels, and
  including + in the default value meant processing those incorrectly

- The "bahamut hack", for old servers that support but don't advertise
  STATUSMSG, didn't work since ischannel_func doesn't use the default.

The choice of @ intentionally leaves out support for other STATUSMSG
(for example, AzzurraNet's bahamut 1.4 fork seemed to support + and % in
any order, contradicting the comment in the code).

I think this is a decent tradeoff, given how those servers are uncommon
and relying on +# or %# is even less common than @#.

Fixes #531
 2016-08-24 19:56:23 -03:00
ailin-nemui
fd371cc345 Merge pull request #422 from LemonBoy/misc-cleanup 
Clean up misc.c
 2016-06-14 12:35:30 +02:00
LemonBoy
439e21f127 Use ; as separator instead of , 2016-06-13 14:07:04 +02:00
LemonBoy
86c5e56ef4 Make rejoin_channels_mode of type CHOICE 2016-06-12 16:26:18 +02:00
LemonBoy
cc70e8c581 Clean up some GTimeVal juggling 2016-06-05 16:48:27 +02:00
LemonBoy
7a3c6fe86c Replace strarray_length with g_strv_length 2016-06-05 16:24:55 +02:00
LemonBoy
72712a0c62 Replace strocpy with g_strlcpy 
The only difference was that the former returned 1 if the buffer was
overflown, but the return value was never checked.
 2016-06-05 16:24:55 +02:00
LemonBoy
f1d0c8ff99 Correct the name of the emitted signal. 
There's a typo in 'sasl_fail', the signal that's emitted should be
'server sasl failure' and not 'server sasl fail'.
 2016-06-01 22:29:13 +02:00