aniani/irssi
1
0
Fork 0
mirror of https://github.com/irssi/irssi.git synced 2025-01-03 14:56:47 -05:00
Code
6,294 Commits 7 Branches 77 Tags 12 MiB
a731525012
Commit Graph

1654 Commits

Author SHA1 Message Date
Manish Goregaokar
12d08f79bb Insert colons after completing nicks preceded by a list of other autocompleted nicks 
When pinging two people, typing `nick1<tab> nick2<tab> message` for
autocompletion will get you `nick1: nick2 message`, which is kinda
confusing.

We only insert the colon after the first autocompleted nick,
because if a nick is used in the middle of the sentence it's mentioning
the person but not targeting the message at them.

However, this breaks down when we try to ping a list of people. There
should be a colon in front of each separating the names from the
message. only having a colon at the end of the nick list works too,
but it seems like the IRC convention is to just use multiple colons.

This patch makes it so that autocompleting a nick after a list of
existing autocompleted nicks at the beginning of the message
will include a colon.
 2018-01-20 10:25:06 +05:30
ailin-nemui
fa8508404f revert netsplit print optimisation 
this reverts part of #465

unfortunately we need to further refine the initial patch

 - when filtering by channel, the whole split is cleaned up nevertheless
 - something similar happens for the netjoins
 - furthermore, we cannot wait only for PUBLIC msgs, j/p/q are equivalently relevant for temporal integrity
 2018-01-10 20:12:04 +01:00
ailin-nemui
a6663c58d4
Merge pull request #697 from ailin-nemui/rsplit 
sideways split support for Irssi
 2018-01-08 12:20:20 +01:00
ailin-nemui
f83ba5a5bb
Merge pull request #779 from vague666/activity_hide_target_only_channels_v2 
Allow selection of what kind of activity targets to ignore v2
 2018-01-08 12:19:46 +01:00
ailin-nemui
d85f867261
Merge pull request #805 from ailin-nemui/exec-empty 
fix /exec -o for blank lines
 2018-01-07 11:24:00 +01:00
dequis
f9c8365999 fe-common-core: fix redeclaration of server_tag_len 2018-01-07 01:45:12 -03:00
ailin-nemui
121a4971e6
Update fe-common-core.c 
fix mixed decls
 2018-01-06 20:17:51 +01:00
ailin-nemui
4d5982f07d
Update fe-common-core.c 2018-01-06 20:02:31 +01:00
ailin-nemui
4e71a1f485 sideways split support for Irssi 
warning:

* may be buggy

This commit adds support for sideways splits into Irssi. To that regard,
there are a number of new commands available

the "R" commands:
	/window new rsplit - make a new sideways split
	/window rshow - show an existing window to the right
	/window rgrow/rshrink/rsize/rbalance
	 - manipulate the size of your sideways split windows

the "D" commands:
	/window dup/ddown/dleft/dright
	 - navigate the windows directionally, as an alternative to
	   /window up/down that you can bind to some key
	/window move dleft/dright - the same for moving

Enjoy!
 2018-01-06 00:26:48 +01:00
ailin-nemui
451019d05d make format_real_length left-collecting 2018-01-06 00:26:48 +01:00
ailin-nemui
b111f038dd fix /exec -o for blank lines 
since it is not allowed to send nothing, instead of spamming the status window
with error, send " " instead

Fixes FS#902
 2018-01-05 23:19:06 +01:00
ailin-nemui
c9b3d87eb7 Postpone server cleanup until after unref 
Add a new signal, server destroyed, that is supposed to run the clean up
tasks of server disconnected. This is so that some structures will stay
around longer.
 2018-01-04 23:04:12 +01:00
ailin-nemui
2361d4b1e5 rewrite completion code and check for direct match of separator 2018-01-03 15:35:18 +01:00
Nei
e405330e04 Merge branch 'uaf-modify' into 'master' 
Prevent a UAF error during the execution of some commands

See merge request irssi/irssi!24
 2018-01-03 10:35:58 +00:00
ailin-nemui
2b918fd9b8 move decls before code 2017-11-30 11:17:05 +01:00
ailin-nemui
5637a8df43
Merge pull request #790 from ailin-nemui/mirc-colour 
reset colour at comma, like mIRC
 2017-11-26 15:18:43 +01:00
ailin-nemui
3792bc9ba9
Merge pull request #762 from ailin-nemui/global-history 
allow access to global command history when using a specifc history
 2017-11-26 00:28:58 +01:00
ailin-nemui
47400d405a
Update formats.c 
remove now useless check for ,
 2017-11-20 14:17:15 +01:00
ailin-nemui
3acc72f842 reset colour at comma, like mIRC 
Fixes #742 and #740
 2017-11-15 16:35:25 +01:00
ailin-nemui
4e8c1548e0
Merge pull request #786 from ailin-nemui/show-inital-nick 
show initial nick and name on first start
 2017-11-15 16:28:22 +01:00
LemonBoy
7605f67f95 Prevent a UAF error during the execution of some commands 
Some arguments were free'd first and then printed, leading to gibberish
being output to screen or a crash.

Found by Joseph Bisch.
Closes: !GL17
 2017-11-11 12:37:51 +01:00
LemonBoy
66b2c9bc91 Keep a copy of the strings coming from the config 
The "HILIGHT_REC" structure used to keep a pointer to the "servertag"
string, owned by the "CONFIG_NODE", causing a double-free.
 2017-11-03 16:37:04 +01:00
Jari Matilainen
60c31219a2 Allow selection of what kind of activity targets to ignore 
Initialize tagtarget on declaration

move code around for better flow, extra checks for uninitialized values

remove unnecessary item->type checks

don't strdup sign

add braces around if statements, use strcmp0 with single characters and remove g_str_has_prefix

refactoring

changed g_ascii_strcasecmp to g_strcmp0

Add networktag/ shorthand

fixed memory leaks

changed from #@= to ::channels, ::queries and ::dccqueries

check for empty string and continue; if found

fixed bug with empty string check

Clean up code
 2017-11-02 15:33:15 +01:00
ailin-nemui
b0fa4dd46d show initial nick and name on first start 2017-11-01 15:51:20 +01:00
Nei
e37d9b2497 Merge branch 'fix-gl-12' into 'security' 
fix out of bounds read in compress_colors

See merge request irssi/irssi!18
 2017-10-20 15:22:32 +02:00
Paul Townsend
87955b69cb Add alternate_nick as a network-specific property. 2017-10-11 21:33:14 +01:00
ailin-nemui
00c80cb6fc fix out of bounds read in compress_colors 
Reported by Hanno Böck.

Fixes GL#12
 2017-10-07 20:48:53 +02:00
ailin-nemui
deac66f33c add a key binding to erase history entries 
it is possible to delete the current history entry using the
erase_history_entry key binding
 2017-10-06 15:31:52 +02:00
ailin-nemui
16d68a86ca add two XSFuncs to manipulate command history entries 
it is possible to use Irssi::UI::Window::get_history_entries to save the
history entries, load_history_entries to load entries into the command
history and delete_history_entries to remove history entries (for example
to remove history selectively)
 2017-10-06 15:02:15 +02:00
ailin-nemui
1fd285dccf refactor history to use history_entries list 
this allows access to the global history even when a using /window history
named or /set window_history on, and you want to recall something from one
of the other windows' histories.

usage (default): ctrl+up/down
 2017-10-06 14:58:47 +02:00
ailin-nemui
24ad80177b Merge pull request #735 from trasz/capsicum 
Add Capsicum support
 2017-09-10 19:43:59 +02:00
Edward Tomasz Napierala
b529e1a9df Fix /back in Capsicum capability mode. 
Signed-off-by: Edward Tomasz Napierala <trasz@FreeBSD.org>
 2017-09-08 13:14:24 +01:00
LemonBoy
7086eae650 Complete filenames ending with a slash 2017-08-29 21:03:42 +02:00
Edward Tomasz Napierala
4bcbb41113 Fix indentation; no functional changes. 
(Take two.)

Signed-off-by: Edward Tomasz Napierala <trasz@FreeBSD.org>
 2017-08-09 14:36:06 +01:00
Edward Tomasz Napierala
0c49a84ffb Add back some ifdefs. 
Signed-off-by: Edward Tomasz Napierala <trasz@FreeBSD.org>
 2017-08-09 11:06:36 +01:00
Edward Tomasz Napierala
aeaa420ad3 Clean up includes a bit. 
Signed-off-by: Edward Tomasz Napierala <trasz@FreeBSD.org>
 2017-08-01 01:15:25 +01:00
Edward Tomasz Napierala
5551b4fe95 Update copyrights. 
Signed-off-by: Edward Tomasz Napierala <trasz@FreeBSD.org>
 2017-07-30 11:47:08 +01:00
Edward Tomasz Napierala
8bb392a3f4 Hook up capsicum.h and fe-capsicum.h to autotools. 
This hopefully fixes Travis build.

Signed-off-by: Edward Tomasz Napierala <trasz@FreeBSD.org>
 2017-07-30 01:27:33 +01:00
Edward Tomasz Napierala
8c04c2be14 Fix build without Capsicum. 
Signed-off-by: Edward Tomasz Napierala <trasz@FreeBSD.org>
 2017-07-29 23:52:23 +01:00
Edward Tomasz Napierala
12e2c46d6a Add wrappers to reduce #ifdefs. 
Signed-off-by: Edward Tomasz Napierala <trasz@FreeBSD.org>
 2017-07-29 23:52:23 +01:00
Edward Tomasz Napierala
e777ae986d Working autolog. 
Signed-off-by: Edward Tomasz Napierala <trasz@FreeBSD.org>
 2017-07-29 23:52:23 +01:00
Edward Tomasz Napierala
d5d45c29b8 Add capability mode error/success messages. 
Signed-off-by: Edward Tomasz Napierala <trasz@FreeBSD.org>
 2017-07-29 23:52:23 +01:00
Edward Tomasz Napierala
e08e2bd87a Don't compute log_dir_create_mode in three different places. 
Signed-off-by: Edward Tomasz Napierala <trasz@FreeBSD.org>
 2017-07-28 03:56:02 +01:00
ailin-nemui
437fbef6eb Merge pull request #719 from LemonBoy/sasl-disable-none 
Setting sasl_mechanism to '' disables the auth
 2017-07-26 10:57:05 +02:00
LemonBoy
d971c02920 Allow the user to clear the sasl-related fields 
There was no easy way for the user to disable the SASL authentication or
to clear the username/password once the network was created.
Closes #718
 2017-07-25 22:53:33 +02:00
ailin-nemui
1656dc1e54 Merge pull request #653 from ailin-nemui/regexex 
Enable UTF8 in GRegex
 2017-07-03 09:53:09 +02:00
ailin-nemui
28d82c8f63 Merge pull request #709 from osm/master 
Escape nicks during nick completion when expand_escapes is enabled
 2017-06-23 18:00:04 +02:00
ailin-nemui
9d32636ebe Merge pull request #703 from vague666/server_modify_port 
Allow -port <num> or irc.host.tld <num> in /server add
 2017-06-23 17:59:02 +02:00
ailin-nemui
bbf8b86074 remove const 2017-06-22 09:33:33 +02:00
Oscar Linderholm
12d671a056 Escape nicks during nick completion when expand_escapes is enabled 
Fixes #693
 2017-06-21 10:40:47 +02:00
ailin-nemui
02a5d1a00b fix weird n-fold unescaping 2017-06-19 14:09:02 +02:00
ailin-nemui
1fc170ee11 Merge branch 'master' into regexex 2017-06-19 11:06:24 +02:00
dequis
52bb06ccd9 fe-dcc-(get|send): Fix some -Wpointer-compare with newer gcc 
The warning itself:

>warning: comparison between pointer and zero character constant [-Wpointer-compare]

Harmless stuff as far as I can tell.

The fix adds a null check that probably isn't needed. The old code that
compared against '\0' worked a lot like a null check so it makes sense
to keep that, while also adding the intended check for empty string.

This was visible with "/dcc close send a" showing an empty filename.
The equivalent for get didn't show the filename in the format string.
 2017-06-05 15:58:43 -03:00
ailin-nemui
4edfccfce7 get rid of new_text 2017-06-05 13:46:43 +02:00
Jari Matilainen
f28c64a3dc Make backward compatible with ssl flags 2017-06-04 19:47:30 +02:00
Jari Matilainen
e84adeca15 change ternary operator to if/else statements, add default ssl port support 2017-06-04 17:41:38 +02:00
ailin-nemui
79bbca4644 Refactor regex and implement UTF8 mode for GRegex 
- with non-unicode byte to Private Use Area A mapping
- move all ifdefs to iregex.h file only
 2017-06-04 00:52:53 +02:00
dequis
632b0ce5e6 Add parse_uint function to improve integer overflow handling 
Originally found by oss-fuzz (issue 525) in get_ansi_color using ubsan.
After a lot of analysis I'm 99% sure this isn't security relevant so
it's fine to handle this publicly.

The fix is mainly adding a function that does it right and use it
everywhere. This is harder than it seems because the strtol() family of
functions doesn't have the friendliest of interfaces.

Aside from get_ansi_color(), there were other pieces of code that used
the same (out*10+(*in-'0')) pattern, like the parse_size() and
parse_time_interval() functions, which are mostly used for settings.
Those are interesting cases, since they multiply the parsed number
(resulting in more overflows) and they write to a signed integer
parameter (which can accidentally make the uints negative without UB)

Thanks to Pascal Cuoq for enlightening me about the undefined behavior
of parse_size (and, in particular, the implementation-defined behavior
of one of the WIP versions of this commit, where something like signed
integer overflow happened, but it was legal). Also for writing
tis-interpreter, which is better than ubsan to verify these things.
 2017-05-18 00:21:11 -03:00
Jari Matilainen
0c26aeb9fc Make sure port is only set on /server modify if specified 2017-05-15 23:07:01 +02:00
ailin-nemui
81cf8d8813 Update fe-server.c 2017-05-14 09:43:38 +02:00
Jari Matilainen
4a6fbdbe78 Spaces to tabs 2017-05-14 03:01:01 +02:00
Jari Matilainen
783458e9ba Added code comments 2017-05-11 14:08:45 +02:00
Jari Matilainen
25f9c71f69 Allow -port <num> or irc.host.tld <port num> in /server add and /server modify 2017-05-11 14:02:23 +02:00
Jari Matilainen
f060292a9c Added braces 2017-05-11 11:17:14 +02:00
Jari Matilainen
dbde9f0fe3 Added support for -notls and -notls_verify 2017-05-11 10:57:24 +02:00
LemonBoy
c890ecafa0 Merge pull request #686 from josephbisch/remove-history-wrap 
Don't allow command history to wrap around
 2017-04-11 15:19:19 +02:00
Joseph Bisch
3297fafcd9
Add syntax info for completion 
Allows syntax info to be picked up and displayed by help command.

Fixes #687
 2017-04-07 12:56:46 -04:00
Joseph Bisch
405136440c
Remove over_counter 
We are no longer using over_counter for any functional purpose, so
remove it.
 2017-04-07 08:20:28 -04:00
Joseph Bisch
7c86575b02
Don't allow command history to wrap around 
This changes the behavior of the command history to avoid wrapping back
to the bottom once the top of the history is reached.
 2017-04-06 20:27:39 -04:00
Joseph Bisch
41776d71f7
Fix strange history behavior when history is empty 
If text is being entered and then the user presses the up arrow
followed by the down arrow, the expected behavior is to return to the
text being entered. Prior to this commit that was not the case.

Fixes #462
 2017-04-05 11:00:25 -04:00
ailin-nemui
e2e02160cd Merge pull request #645 from LemonBoy/keyboard-misc 
Timeout feature for keys
 2017-03-11 23:11:43 +01:00
Ailin Nemui
77b2631c78 Merge branch 'netjoin-timeout' into 'master' 
fe-netjoin: remove irc servers on "server disconnected" signal

Closes #7

See merge request !10
 2017-03-10 17:18:18 +01:00
ailin-nemui
ddba68ad77 Merge pull request #659 from ailin-nemui/foreach_dontspam 
make foreach send commands
 2017-03-07 23:37:23 +01:00
ailin-nemui
62fd3ac180 Revert "Quote the filename when dcc requests are auto accepted." 2017-03-06 11:27:55 +01:00
ailin-nemui
29f27cfb39 Merge pull request #658 from LemonBoy/dcc-autoaccept 
Quote the filename when dcc requests are auto accepted.
 2017-03-04 21:43:21 +01:00
Nei
7ef22687f9 Merge branch 'd-minor' into 'master' 
Prevent some potential null-pointer deferences.

See merge request !9
 2017-03-04 20:35:17 +00:00
dequis
7c09b72848 fe-netjoin: remove irc servers on "server disconnected" signal 2017-02-27 23:43:37 -03:00
ailin-nemui
9aaa6449a0 make foreach send commands 2017-02-27 13:43:58 +01:00
LemonBoy
027acffb42 Handle file names with quotes. 
Let's repurpose escape_string and make it more flexible by letting us
choose the characters to escape.
 2017-02-22 11:49:09 +01:00
LemonBoy
9cae98e642 Execute what's left in the input queue when the timeout expires. 
Similar to how vim behaves.
 2017-02-18 15:57:55 +01:00
LemonBoy
98ead50b4e Prevent some potential null-pointer deferences. 
Spotted by our friend scan-build.
 2017-02-14 14:46:14 +01:00
ailin-nemui
1ee25d2286 Merge pull request #590 from LemonBoy/hi-minor 
Minor cleanup in the highlighting signal.
 2017-01-31 14:18:48 +01:00
Joseph Bisch
c8dafe2a76
Add SUPPRESS_PRINTF_FALLBACK 
There are some cases (such as fuzzing with fe-fuzz) where suppressing
printf output may be desirable.
 2017-01-16 12:56:33 -05:00
ailin-nemui
17fc77565e fix regression in completion 
fixes #609
 2017-01-09 13:19:37 +01:00
Nei
7a112e0217 Merge branch 'master' into 'security' 
Sync to master

See merge request !6
 2017-01-03 13:30:39 +01:00
ailin-nemui
01163710e7 Merge pull request #585 from ailin-nemui/win_seq 
g_sequence backing for window list
 2017-01-03 12:45:50 +01:00
Ailin Nemui
f5cbbebc2e switch for gregex and regex.h 2017-01-03 12:29:11 +01:00
Nei
1b99299ed2 Merge branch 'percent_flag' into 'security' 
fix %[

See merge request !5
 2017-01-02 17:01:47 +00:00
LemonBoy
5dcf291f21 Use the RAW flag when building the regexps. 
Also, plugged a memory leak when retrieving the match position.
 2017-01-02 17:50:14 +01:00
LemonBoy
3fcd3cd2b9 Remove the regexp_compiled field. 
It was made redundant by the introduction of the pointer to the GRegex
structure.
Silence the compiler warning in textbuffer.c about preg being
initialized by setting it to NULL.
 2017-01-02 17:50:14 +01:00
LemonBoy
8e5db471e4 Use GLib's regexp interface (backed by PCRE) 2017-01-02 17:50:14 +01:00
ailin-nemui
91f48c6f0e Merge pull request #586 from LemonBoy/fix-580 
Process the nick changes in queries before the PRIVMSG is handled.
 2017-01-02 14:44:07 +01:00
LemonBoy
7e22d051ae Make sure SASL was actually requested before failing. 2017-01-01 23:08:38 +01:00
ailin-nemui
9151f87145 remove some for loops 2016-12-20 21:40:18 +01:00
ailin-nemui
9a018a782c sort windows_seq helpers to top 2016-12-20 21:36:56 +01:00
ailin-nemui
03f5dc63fe nits 2016-12-20 21:33:51 +01:00
ailin-nemui
9004265e54 clean up window_refnum_{prev,next} 2016-12-20 21:01:16 +01:00
ailin-nemui
7dc2f832c1 fix %[ 2016-12-20 16:41:57 +01:00
ailin-nemui
2f59fe2062 add some sequence helper functions 2016-12-19 22:03:46 +01:00
LemonBoy
a39e210ea8 Minor cleanup in the highlighting signal. 2016-12-18 15:46:48 +01:00
LemonBoy
7a7f6abc16 Prevent a UaF by calling server_disconnect in a signal handler. 2016-12-15 22:41:57 +01:00
LemonBoy
0d6add02cf Process the nick changes in queries before the PRIVMSG is handled. 
Otherwise we end up with the message in the status window since the
frontend knows jack shit about the casemapping option when it tries to
find the associated window for the query.
 2016-12-15 19:36:44 +01:00
ailin-nemui
7b856d628b check for end of string in ansi 48 2016-12-15 18:01:26 +01:00
ailin-nemui
560283ba4e g_sequence backing for window list 2016-12-13 01:04:26 +01:00
LemonBoy
4ccffd85ff Expose 'sasl_success' to the perl side. 2016-12-12 21:41:07 +01:00
LemonBoy
91c9e871c7 Add an option to stop the connection when SASL fails. 2016-12-12 21:41:06 +01:00
LemonBoy
5efb3077d5 Merge pull request #565 from ahf/bug/524 
Kill bell_beeps.
 2016-11-29 22:13:53 +01:00
LemonBoy
5f0e755a00 Don't shadow the 'channel' variable when printing the netjoins. 
This is the root cause of #567
 2016-11-23 22:22:37 +01:00
LemonBoy
7574bed26c Minor corrections to the netsplit code. 2016-11-23 16:11:38 +01:00
Lauri Tirkkonen
4cbf279d88 add completion_empty_line setting 2016-11-08 16:27:38 +02:00
Alexander Færøy
6a6196eebe
Kill bell_beeps. 
Fixes #524
 2016-10-23 21:24:12 +02:00
Alexander Færøy
bc4e2c9ade
Shorten the certificate chain output. 2016-10-23 02:51:08 +02:00
Alexander Færøy
322625b548
Only do checks for SSL_get_server_tmp_key in network-openssl.c. 2016-10-22 22:04:33 +02:00
Alexander Færøy
4e170c5233
Declare variables in the beginning of the function. 2016-10-22 22:04:32 +02:00
Alexander Færøy
5146ce9631
Add x509 certificate and public key pinning support. 
This patch adds two new options to /CONNECT and /SERVER to let the user
pin either an x509 certificate and/or the public key of a given server.

It is possible to fetch the certificate outside of Irssi itself to
verify the checksum. To fetch the certificate call:

    $ openssl s_client -connect chat.freenode.net:6697 < /dev/null 2>/dev/null | \
      openssl x509 > freenode.cert

This will download chat.freenode.net:6697's TLS certificate and put it into the
file freenode.cert.

-tls_pinned_cert
----------------

This option allows you to specify the SHA-256 hash of the x509
certificate. When succesfully connected to the server, irssi will verify
that the given server certificate matches the pin set by the user.

The SHA-256 hash of a given certificate can be verified outside of irssi
using the OpenSSL command line tool:

    $ openssl x509 -in freenode.cert -fingerprint -sha256 -noout

-tls_pinned_pubkey
------------------

This option allows you to specify the SHA-256 hash of the subject public key
information section of the server certificate. This section contains both the
cryptographic parameters for the public key, but also information about the
algorithm used together with the public key parameters.

When succesfully connected to the server, irssi will verify that the
given public key matches the pin set by the user.

The SHA-256 hash of a public key can be verified outside of irssi using
the OpenSSL command line tool:

    $ openssl x509 -in freenode.cert -pubkey -noout | \
      openssl pkey -pubin -outform der | \
      openssl dgst -sha256 -c | \
      tr a-z A-Z

It is possible to specify both -tls_pinned_cert and -tls_pinned_pubkey
together.
 2016-10-22 22:01:50 +02:00
Alexander Færøy
c6c2e79537
Display TLS connection information when connected to a TLS enabled server. 2016-10-22 21:58:50 +02:00
Alexander Færøy
2be7289085
Rename SSL to TLS. 
This patch changes the internal name of SSL to TLS. We also add -tls_*
options to /CONNECT and /SERVER, but make sure that the -ssl_* versions
of the commands continue to work like before.
 2016-10-22 20:36:50 +02:00
ailin-nemui
61590f31df Merge pull request #465 from LemonBoy/netsplit-print 
Some small adjustments to the netsplit code.
 2016-10-11 16:12:35 +02:00
ailin-nemui
295a4b77f0 Patches for heap corruption and missing bounds check 
By Gabriel Campana and Adrien Guinet from Quarkslab.
 2016-09-20 19:56:06 +02:00
ailin-nemui
b58be939d2 Merge pull request #516 from LemonBoy/comp-file 
Fix the tab completion for paths starting with ./
 2016-09-13 23:29:09 +02:00
LemonBoy
e4f8abc973 Merge pull request #533 from dequis/statusmess 
Set the default STATUSMSG to @ instead of @+ if it's missing
 2016-09-04 12:11:02 +02:00
dequis
3429c1a0a0 Set the default STATUSMSG to @ instead of @+ if it's missing 
This fixes two issues:

- IRCNet doesn't have STATUSMSG, but it supports +channels, and
  including + in the default value meant processing those incorrectly

- The "bahamut hack", for old servers that support but don't advertise
  STATUSMSG, didn't work since ischannel_func doesn't use the default.

The choice of @ intentionally leaves out support for other STATUSMSG
(for example, AzzurraNet's bahamut 1.4 fork seemed to support + and % in
any order, contradicting the comment in the code).

I think this is a decent tradeoff, given how those servers are uncommon
and relying on +# or %# is even less common than @#.

Fixes #531
 2016-08-24 19:56:23 -03:00
ailin-nemui
681caf2b58 fix nick->host == NULL crash 2016-08-22 12:27:10 +02:00
LemonBoy
bd4189907e Minor cosmetic fix in /unignore error message. 
Reported here:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=577202
 2016-07-12 17:38:05 +02:00
LemonBoy
dab3246db9 Fix the tab completion for paths starting with ./ 2016-07-12 16:35:43 +02:00
LemonBoy
c0f66c95ff Such draft. Very wow. 2016-06-26 21:45:03 +02:00
LemonBoy
8f5e200551 Avoid entering an endless loop while traversing the channel list 2016-06-26 21:45:03 +02:00
LemonBoy
ed06e43ec8 Some small adjustments to the netsplit code. 
By making the signal handler hooked to the "print starting" event
smarter we can avoid dumping the whole netsplit stats for every
server/channel when a message arrives.

Issue #420
 2016-06-26 21:45:03 +02:00
ailin-nemui
f264a78947 Merge pull request #496 from ailin-nemui/comp 
completion fixes
 2016-06-24 10:05:15 +02:00
LemonBoy
798ce006c2 Merge pull request #498 from vague666/add_modify_functions 
Add modify to /channel, /server and /network
 2016-06-21 22:46:52 +02:00
Jari Matilainen
a4223a3b2e use TRUE/FALSE in if statements for gboolean 2016-06-21 22:05:21 +02:00
Jari Matilainen
2bb913f0c1 Fix minor nits 2016-06-19 16:35:13 +02:00
Jari Matilainen
4292dbd202 Add command_set_options for modify commands to allow completion 2016-06-18 18:47:11 +02:00
Jari Matilainen
79e30405e6 Let ADD still work as modify 2016-06-18 18:02:04 +02:00
Jari Matilainen
1d2113a638 Add /server modify SYNTAX 2016-06-18 17:53:35 +02:00
Jari Matilainen
421288cf50 Add /network modify 2016-06-18 17:52:47 +02:00
Jari Matilainen
1dd1dde1d4 Add /server modify 2016-06-18 17:52:26 +02:00
Jari Matilainen
92a2384ab0 Add /channel modify 2016-06-18 17:51:58 +02:00
ailin-nemui
77ad62fadb completion fixes 2016-06-16 21:30:46 +02:00
ailin-nemui
fd371cc345 Merge pull request #422 from LemonBoy/misc-cleanup 
Clean up misc.c
 2016-06-14 12:35:30 +02:00
LemonBoy
862729d7a3 Add a completion_match_case setting. 2016-06-13 22:13:43 +02:00
LemonBoy
78c1c1518a Be smart about case-matching the nicks. 
If the prefix contains an uppercase letter then don't use the
case-insensitive search functions.
 2016-06-13 21:55:20 +02:00
LemonBoy
5c8423a08c Add a space after the comma when listing the options. 2016-06-13 20:27:37 +02:00
LemonBoy
9a30ab53df Move the validation of the CHOICE setting value 
Also, use a FORMAT to show the error message.
 2016-06-13 14:03:00 +02:00
LemonBoy
6f795f020d Strip the surrounding whitespace. 2016-06-12 23:39:22 +02:00
LemonBoy
7307b48bd6 Sort the completion results 
Make sure the current option is shown first.
 2016-06-12 22:58:35 +02:00
LemonBoy
bf9d9494db Add a CHOICE type to the settings system. 
This is useful to let the user choose an option between a finite set of
valid alternatives.
 2016-06-12 16:18:33 +02:00
LemonBoy
0060f682c2 Factor out some redundant code and remove hashtable_get_keys 2016-06-05 17:24:27 +02:00
LemonBoy
7a3c6fe86c Replace strarray_length with g_strv_length 2016-06-05 16:24:55 +02:00
LemonBoy
bb190be0bf Replace mkpath with g_mkdir_with_parents 2016-06-05 16:24:55 +02:00
ailin-nemui
74d38683bf Merge pull request #480 from xavierog/handle-utf8-nicks-with-mk_wcwidth 
Handle utf8 nicks with mk_wcwidth()
 2016-05-18 09:18:21 +02:00
Xavier G
29beafcf6f Improve UTF-8 handling in display_sorted_nicks(). 2016-05-13 04:08:15 +02:00
Xavier G
09ca3ad48f Fix indentation of display_sorted_nicks(). 
This was done assuming an "indent with tab, align with spaces" approach.
get_alignment also benefited from a minor indentation fix.
 2016-05-13 03:31:23 +02:00
Xavier G
21c07c0060 Leverage string_policy(). 2016-05-13 02:27:19 +02:00
Xavier G
b0afcc96db Rename advance() into string_advance(). 2016-05-13 01:52:37 +02:00
Xavier G
5c74a3bb88 Move advance() from fe-common/core to core. 2016-05-13 01:39:14 +02:00
Xavier G
5538578820 Move utf8.{h,c} from fe-common/core to core. 2016-05-13 01:26:33 +02:00
pisculichi
47e792da05 Fix some ANSI C issues. 2016-05-03 15:28:20 +00:00
isundil
b63339af89 Increased ABI version 2016-04-30 18:26:26 +00:00
isundil
e7a18759ec Added case-sensitive regexp matching for hilights 2016-04-29 22:17:51 +00:00
B Thibault
ddd5416430 changed command-line -case to -matchcase 2016-04-29 11:00:34 +02:00
B Thibault
d8a6e66699 Ref #421 (Add an option to make /hilight case sensitive) 
Allow use of /hilight -case exAMPle (compatible with other options)
Added matchcase to hilight config file (exemple: { text = exAMPle; matchcase = yes; } )
 2016-04-29 01:01:34 +02:00
B Thibault
9fa3869a97 retab 2016-04-29 00:12:28 +02:00
ailin-nemui
9cb0419435 Merge pull request #443 from LemonBoy/chatnet 
Throw an error when a chatnet has no available url
 2016-03-22 23:00:01 +01:00
ailin-nemui
195c44a76e Merge pull request #446 from ailin-nemui/fix_445 
strip less whitespace from commands
 2016-03-22 15:23:37 +01:00
ailin-nemui
132d3c49f3 strip less whitespace from commands 
fixes #445
 2016-03-20 22:39:06 +01:00
LemonBoy
6745dd6159 Throw an error when a chatnet has no available url 
If you type /connect <CN> and the chatnet <CN> has no url available
let's just throw an error instead of trying to process <CN> as a url.
 2016-03-19 14:04:53 +01:00
Jari Matilainen
857e27aef6 Don't use glob matching, just regular string comparisons 2016-03-17 23:58:46 +01:00
Jari Matilainen
94b823c3cd Use glob matching for activity_hide_targets 
spaces vs tabs!

strarray_find* needs to return -1 if no index found
 2016-03-14 22:29:36 +01:00
dequis
7674fd5936 completion: Fix crash when the complist provided by a script has nulls 
Can be reproduced with aspell_complete.pl 1.00 by setting an invalid
dictionary with "/set spell_dict a"
 2016-01-29 10:40:18 -03:00
LemonBoy
d964950e5d Serialize the 'name' attribute of the CHANNEL_REC. 
This way the code doing the serialization in 'sig_layout_save_item' is
now symmetric with the loading code loading the data in
'sig_layout_restore'.
 2016-01-25 20:48:13 +01:00
ailin-nemui
62cab9d662 Merge pull request #393 from ailin-nemui/moduleversion-perl 
forward ABI to perl modules
 2016-01-11 21:19:35 +01:00
ailin-nemui
bd2c549064 Merge pull request #394 from ailin-nemui/reset-history 
option to clear the history
 2016-01-11 21:04:48 +01:00
ailin-nemui
8f37095969 Merge pull request #389 from ailin-nemui/hilight2-up 
keep track of address in text_dest for hilight purposes
 2016-01-11 21:04:43 +01:00
ailin-nemui
ad842ea8a6 reorder history add and fixes 2016-01-08 15:42:59 +01:00
ailin-nemui
4659cea65a option to clear the history 2016-01-08 15:19:13 +01:00
LemonBoy
dbee606c60 Don't break the API. 
Have a ignore_find_full method that is the one that all the new code
should be using and provide some working stubs for ignore_find and
ignore_find_noact.
 2016-01-03 21:26:57 +01:00
LemonBoy
609f3ba6c2 Clean up the ignore_find API to make it more powerful. 
This way we prevent the creation of duplicate ignores since the old code
skipped the ignore_find call when a pattern was specified.
It should also cover all the cases where the ignores would be wrongly
overwritten, such as the case outlined in #78.
 2016-01-03 19:49:18 +01:00
ailin-nemui
7cc85b9427 keep track of address in text_dest for hilight purposes 2015-12-28 01:08:35 +01:00
ailin-nemui
5fbad764df clean up after #303 2015-12-15 00:08:44 +01:00
ailin-nemui
074af68578 Merge pull request #303 from vague666/fs275 
Applied patch from fs#275 to make /hilight -mask -line work properly
 2015-12-15 00:07:18 +01:00
ailin-nemui
ff8ccaf08b module check irssi version 
Add explicit checks into every module to match the ABI version defined
in common.h
 2015-12-10 00:52:33 +01:00
dequis
96766b7f05 Remove all WIN32 ifdefs (unifdef -UWIN32) 
Just use cygwin.

This looks like it wasn't enough to do anything useful, and I don't
think anyone cares about supporting win32 the hard way.
 2015-12-09 15:20:59 -03:00
ailin-nemui
20fe5d0c7f add missing file to Makefile 2015-12-09 14:23:15 +01:00
ailin-nemui
229c600e99 Merge pull request #174 from ailin-nemui/entry-prompt-colours 
reimplement format and length logic for the entry prompt
 2015-12-09 12:01:00 +01:00
LemonBoy
0171b1a634 Use the expanded filename when picking the awaylog 
This fixes a long-standing bug where 'fname' was being feed to cat
instead of 'real_fname', causing it to quit with a 'No such file or directory'
error.

FS#377
 2015-11-22 21:59:28 +01:00
ailin-nemui
fbb838b3b0 Merge pull request #350 from LemonBoy/fix-99 
Strip trailing whitespace from commands
 2015-11-18 22:01:29 +01:00
ailin-nemui
ac04fa7413 Merge pull request #351 from vague666/hilight_default_behaviour 
Fix /hilight list output behaviour depending on enabled flags
 2015-11-10 11:07:16 +01:00
Jari Matilainen
b333d10364 /hilight list print output with enabled flags, except when -word and -nick are used 2015-11-09 23:06:56 +01:00
LemonBoy
d4676c9855 Use the PARAM_FLAG_STRIP_TRAILING_WS flag wherever possible. 2015-11-09 23:02:41 +01:00
LemonBoy
3d9b9d473f Strip the trailing whitespace from /join commands. 
Fixes #99 for great good.
 2015-11-09 18:42:49 +01:00
ailin-nemui
6d6e672e8e Merge pull request #313 from isundil/master 
Fix #45 Make it easy to delete default channels, servers and networks
 2015-11-09 16:45:19 +01:00
Alexander Færøy
685d8fe5b0
Add SETTING_TYPE_ANY and replace -1 with it. 2015-10-03 19:01:16 +02:00
dx
c3e4664870 Merge pull request #294 from dequis/key-states-rescan-recursion-limit 
Limit recursion depth of key/combo expansion in key_states_scan()
 2015-10-02 07:22:48 -03:00
isundil
6ca7dc6847 Updated server removal 
Removing network will also remove attached channels
 2015-10-01 22:36:02 +02:00
isundil
2ad6bb1295 Fix #45 Make it easy to delete default channels, servers and networks 
Removing network will now also remove all attached servers
 2015-10-01 21:14:30 +02:00
Jari Matilainen
b04b5f0f1d Make sure sasl settings are defined before printing them out 2015-09-29 11:44:11 +02:00
Jari Matilainen
cff536ab70 Add sasl info to /network list output if available 2015-09-29 10:39:49 +02:00
ailin-nemui
18989e76db Merge pull request #304 from LemonBoy/sasl_user_options 
Allow the user to set and modify the SASL parameters
 2015-09-26 19:07:54 +02:00
LemonBoy
1a2c479bc0 Allow the user to set and modify the SASL parameters 
The /NETWORK ADD command now is able to modify the SASL mechanism, the
username and the password on a chatnet basis.
 2015-09-26 18:53:10 +02:00