aniani/irssi
1
0
Fork 0
mirror of https://github.com/irssi/irssi.git synced 2024-06-16 06:25:24 +00:00
Code
6,064 Commits 7 Branches 77 Tags 13 MiB
664c38afba
Commit Graph

178 Commits

Author SHA1 Message Date
dequis
664c38afba Fix some glib deprecation warnings 
Most of these have been deprecated since forever (2.2), but they didn't
raise warnings. Now they do, and the warnings are not the most verbose
warnings you could ask for, but, they point in the right direction.

This doesn't handle the GTimeVal deprecation warnings. Those seem
trickier since they cover API, will look into those right after this.
 2019-10-31 23:49:40 +01:00
Zero King
dde5fff4a5 Fix memory leaks 2019-07-27 18:34:03 +00:00
Ailin Nemui
00a7efc69f modularise irc component 2019-07-17 13:37:19 +02:00
Ailin Nemui
db16a0a853 meson build support 2019-07-10 09:25:26 +02:00
ailin-nemui
37f7c7f374 update include guard names 2019-05-01 22:22:22 +02:00
ailin-nemui
7e6e1f2e10 Use full paths to includes 2019-05-01 22:08:45 +02:00
Will Storey
c25d24220f Remove unused functions 2019-02-18 11:53:46 -08:00
Jaroslav Škarvada
4f26ad74f5
Fixed problem found by Coverity Scan 
Fixes #981

Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
 2018-12-04 21:07:06 +01:00
dequis
ade2f87fe5 Fix use after free introduced by the use after free patch 2018-08-24 02:19:42 -03:00
coypu@sdf.org
610ab2dafa Use-after-frees 
Hi folks!

I tried clang-static-analyzer on irssi 1.1.1, it seems like it
finds some things. Here's a diff, but there might be more that you would
want to check, or choose to work differently.

(in special-vars.c, ret is commands->data sometime)

I hope it's not too much trouble if reported as a confidential bug.
Thanks.
 2018-08-23 14:13:48 +02:00
Staron, Martin
3cbcb4fe85 dcc get shouldn't fail when file attrs can't be changed 2018-02-13 08:15:39 +01:00
ailin-nemui
9f0dc4766c fix dcc issue 2017-10-20 15:14:10 +02:00
Nei
200eb5922e Merge branch 'fix-gl9' into 'security' 
Fix dcc_request where addr is NULL

See merge request !13
 2017-05-30 19:39:06 +00:00
Joseph Bisch
528f51bfbe
Fix dcc_request where addr is NULL 2017-05-29 14:53:26 -04:00
Joseph Bisch
30a92754bb
Fix oob read of one byte in get_file_params_count{,_resume} 
We can use continue to handle cases such as:
"ab<space><space>c"
 2017-05-29 14:43:24 -04:00
ailin-nemui
7bd1b80687 fix dcc get 
fixes #656
 2017-03-07 23:27:08 +01:00
ailin-nemui
62fd3ac180 Revert "Quote the filename when dcc requests are auto accepted." 2017-03-06 11:27:55 +01:00
LemonBoy
027acffb42 Handle file names with quotes. 
Let's repurpose escape_string and make it more flexible by letting us
choose the characters to escape.
 2017-02-22 11:49:09 +01:00
LemonBoy
db85ab7c90 Quote the filename when dcc requests are auto accepted. 
PR #453 forces the user to quote the filenames given to /DCC commands
when they contain spaces but the autoget functionality didn't get
updated so the filename was always passed without quotes.

Closes #656.
 2017-02-21 15:17:37 +01:00
ailin-nemui
dcffa98d46 add a static buffer for dcc received data 
increased buffersize might make irssi freeze less / #159
 2016-11-23 17:02:29 +01:00
LemonBoy
7a3c6fe86c Replace strarray_length with g_strv_length 2016-06-05 16:24:55 +02:00
LemonBoy
72712a0c62 Replace strocpy with g_strlcpy 
The only difference was that the former returned 1 if the buffer was
overflown, but the return value was never checked.
 2016-06-05 16:24:55 +02:00
LemonBoy
8b54366d95 Support quoted filenames in some /DCC commands 2016-03-22 16:00:00 +01:00
ailin-nemui
132d3c49f3 strip less whitespace from commands 
fixes #445
 2016-03-20 22:39:06 +01:00
LemonBoy
d4676c9855 Use the PARAM_FLAG_STRIP_TRAILING_WS flag wherever possible. 2015-11-09 23:02:41 +01:00
Robert C Jensen
b984f1fa25 dcc-get: close() the temp fd so we don't get ETXTBSY in ntfs mounts 
Patch from debian bug 696963 [1]

Fixes github bug #220 and flyspray bug 867 [2]

[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=696963
[2]: http://bugs.irssi.org/index.php?do=details&task_id=867
 2015-09-23 23:39:37 -03:00
ailin-nemui
f5f3d7cc98 Revert "Network and IPv{4,6} related changes" 2015-09-22 21:59:17 +02:00
LemonBoy
ffaa890e99 Initial work to make irssi respect the resolved ip order 
Ip's aren't selected using random() anymore, also select the ip version
by using getaddrinfo and some proper hints.
 2015-09-21 14:19:35 +02:00
LemonBoy
16c71cf1fb Implement CHANTYPES support 2015-05-15 17:07:30 +02:00
dequis
f14199d9c1 Change all strcmp() to g_strcmp0() to handle nulls gracefully 
Just a string replacement (but i did check every one of them)

    sed -i 's/strcmp(/g_strcmp0(/g' **/*.c
 2015-04-07 22:41:05 -03:00
Michael Vetter
51239925ec source cleanup: remove trailing whitespaces 2014-09-11 19:10:33 +02:00
Dave Reisner
f0925de16b s/INCLUDES/AM_CPPFLAGS/g 
Silences warnings on recent automake such as:

src/core/Makefile.am:3: warning: 'INCLUDES' is the old name for
'AM_CPPFLAGS' (or '*_CPPFLAGS')
 2014-06-27 09:06:21 -04:00
David Hill
9d6cd87b0f Replace deprecated g_basename with g_path_get_basename. 2014-06-22 20:39:35 -04:00
David Hill
444f9e4836 Do not break strict-aliasing rules. 
dcc-send.c:296:2: warning: dereferencing type-punned pointer
will break strict-aliasing rules
 2014-06-20 12:43:24 -04:00
David Hill
0d4f13d20f Replace deprecated g_str[n]casecmp with g_ascii_str[n]cmp. 2014-06-10 12:06:19 -04:00
Alexander Færøy
8728207191 deprecated glib strup/down fixes from exg. 
git-svn-id: file:///var/www/svn.irssi.org/SVN/irssi/trunk@5138 dbcabf3a-b0e7-0310-adc4-f8d773084564
 2010-04-03 20:09:37 +00:00
Wouter Coekaerts
4b751d9df6 Use servertag from the active DCC chat when not connected anymore to the IRC server that started it. This fixes a crash with handling the DCC queue. Reported by Aurelien Delaitre (SATE 2009) 
git-svn-id: file:///var/www/svn.irssi.org/SVN/irssi/trunk@5122 dbcabf3a-b0e7-0310-adc4-f8d773084564
 2010-02-27 18:52:41 +00:00
Alexander Færøy
2fffcf5a77 Code Cleanup: 
Use g_string_printf() instead of g_string_sprintf() (which is considered deprecated.)



git-svn-id: file:///var/www/svn.irssi.org/SVN/irssi/trunk@5004 dbcabf3a-b0e7-0310-adc4-f8d773084564
 2009-02-08 17:57:19 +00:00
Emanuele Giaquinta
f053542dcf Extend net_sendbuffer by adding a LINEBUF_REC member and a net_sendbuffer_receive_line 
function to read linewise from the associated io channel.
Rewrite irc/dcc/proxy read logic on top of it.


git-svn-id: file:///var/www/svn.irssi.org/SVN/irssi/trunk@4841 dbcabf3a-b0e7-0310-adc4-f8d773084564
 2008-05-22 22:38:29 +00:00
Emanuele Giaquinta
ba80576b1e Remove some global variables used to store settings values, instead get the 
values when needed.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@4836 dbcabf3a-b0e7-0310-adc4-f8d773084564
 2008-05-19 21:55:04 +00:00
Emanuele Giaquinta
72930e0be3 Use g_ascii_str{,n}casecmp for case insensitive comparison with 
ascii only strings.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@4739 dbcabf3a-b0e7-0310-adc4-f8d773084564
 2008-03-09 12:17:55 +00:00
Emanuele Giaquinta
2b0ebef911 Remove unneeded includes. 
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@4735 dbcabf3a-b0e7-0310-adc4-f8d773084564
 2008-03-07 19:33:23 +00:00
Emanuele Giaquinta
af3b0b2b93 Replace g_strdup+g_str{up,down} with g_ascii_str{up,down}. 
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@4721 dbcabf3a-b0e7-0310-adc4-f8d773084564
 2008-03-04 10:42:23 +00:00
Emanuele Giaquinta
e79829b6a5 Remove unneeded includes. 
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@4709 dbcabf3a-b0e7-0310-adc4-f8d773084564
 2008-02-05 15:03:33 +00:00
Emanuele Giaquinta
3c7c3941d7 Remove .cvsignore files. 
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@4672 dbcabf3a-b0e7-0310-adc4-f8d773084564
 2008-01-21 11:49:10 +00:00
Emanuele Giaquinta
d9782fab84 Fallback on rename also when errno is ENOSYS/EOPNOTSUPP because 
FUSE/BSD sets this value when link is not available.
Based on a patch by Juuso Tähkäpää, bug 536.


git-svn-id: http://svn.irssi.org/repos/irssi/trunk@4631 dbcabf3a-b0e7-0310-adc4-f8d773084564
 2007-10-29 15:37:31 +00:00
Emanuele Giaquinta
022b6f183a Fix typo. 
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@4585 dbcabf3a-b0e7-0310-adc4-f8d773084564
 2007-07-26 14:15:12 +00:00
Wouter Coekaerts
9c2d621cc6 Oops. Update address correctly now. 
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@4490 dbcabf3a-b0e7-0310-adc4-f8d773084564
 2007-05-08 18:41:10 +00:00
Wouter Coekaerts
023026e12b Update FSF address 
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@4489 dbcabf3a-b0e7-0310-adc4-f8d773084564
 2007-05-08 18:16:58 +00:00
Emanuele Giaquinta
a42b4202f2 Fix DCC get when file size is 0, bug #494. 
git-svn-id: http://svn.irssi.org/repos/irssi/trunk@4462 dbcabf3a-b0e7-0310-adc4-f8d773084564
 2007-04-25 19:22:39 +00:00