mirror of
https://github.com/irssi/irssi.git
synced 2024-08-25 04:04:18 -04:00
Merge pull request #525 from ailin-nemui/issue522
fix use after free in expando error
This commit is contained in:
commit
c284309d36
@ -74,15 +74,18 @@ static char *perl_expando_event(PerlExpando *rec, SERVER_REC *server,
|
||||
|
||||
ret = NULL;
|
||||
if (SvTRUE(ERRSV)) {
|
||||
PERL_SCRIPT_REC *script = rec->script;
|
||||
|
||||
(void) POPs;
|
||||
/* call putback before emitting script error signal as that
|
||||
* could manipulate the perl stack. */
|
||||
PUTBACK;
|
||||
/* make sure we don't get back here */
|
||||
if (rec->script != NULL)
|
||||
script_unregister_expandos(rec->script);
|
||||
if (script != NULL)
|
||||
script_unregister_expandos(script);
|
||||
/* rec has been freed now */
|
||||
|
||||
signal_emit("script error", 2, rec->script, SvPV_nolen(ERRSV));
|
||||
signal_emit("script error", 2, script, SvPV_nolen(ERRSV));
|
||||
} else if (retcount > 0) {
|
||||
ret = g_strdup(POPp);
|
||||
*free_ret = TRUE;
|
||||
|
Loading…
Reference in New Issue
Block a user