aniani/icecast-server
1
0
Fork 0
mirror of https://gitlab.xiph.org/xiph/icecast-server.git synced 2025-02-02 15:07:36 -05:00
Code

Bugfix: Cluster test could have read past the end of the input buffer.

Browse Source 
Move the cluster test inside the space-to-read check with the other tests.
This commit is contained in:
Joseph Wallace 2015-11-21 15:41:30 -05:00
parent 9de8fe483d
commit d394a244f0
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/format_ebml.c
View File

@ -588,7 +588,11 @@ static int ebml_wrote(ebml_t *ebml, int len)
/* Recognize tags of interest */
if (tag_length > 4) {
if (!memcmp(ebml->input_buffer + cursor, segment_id, 4)) {
if (!memcmp(ebml->input_buffer + cursor, cluster_id, 4)) {
/* Found a Cluster */
ebml->parse_state = EBML_STATE_START_CLUSTER;
break;
} else if (!memcmp(ebml->input_buffer + cursor, segment_id, 4)) {
/* Parse all Segment children */
payload_length = 0;
@ -678,16 +682,11 @@ static int ebml_wrote(ebml_t *ebml, int len)
}
}
/* Take appropriate next action */
if (!memcmp(ebml->input_buffer + cursor, cluster_id, 4)) {
/* Found a cluster */
ebml->parse_state = EBML_STATE_START_CLUSTER;
} else if (processing) {
/* Copy any data we don't need to probe any more */
if (processing) {
/* Non-cluster tag, copy it & children into buffer */
ebml->copy_len = tag_length + payload_length;
ebml->parse_state = copy_state;
}
} else if (tag_length == 0) {