aniani/icecast-server
1
0
Fork 0
mirror of https://gitlab.xiph.org/xiph/icecast-server.git synced 2024-11-03 04:17:17 -05:00
Code

allow for shoutcast metadata updates to auth with admin/per-mount/global

Browse Source 
source password

svn path=/icecast/trunk/icecast/; revision=8232
This commit is contained in:
Karl Heyes 2004-11-19 15:05:36 +00:00
parent 731f24d050
commit 889e260490
2 changed files with 16 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/admin.c
View File

@ -301,10 +301,18 @@ void admin_handle_request(client_t *client, char *uri)
if (command == COMMAND_SHOUTCAST_METADATA_UPDATE) { if (command == COMMAND_SHOUTCAST_METADATA_UPDATE) {
ice_config_t *config = config_get_config (); ice_config_t *config;
char *pass = httpp_get_query_param (client->parser, "pass");
if (pass == NULL)
{
client_send_400 (client, "missing pass parameter");
return;
}
config = config_get_config ();
httpp_set_query_param (client->parser, "mount", config->shoutcast_mount); httpp_set_query_param (client->parser, "mount", config->shoutcast_mount);
httpp_setvar (client->parser, HTTPP_VAR_PROTOCOL, "ICY");
httpp_setvar (client->parser, HTTPP_VAR_ICYPASSWORD, pass);
config_release_config (); config_release_config ();
noauth = 1;
} }
mount = httpp_get_query_param(client->parser, "mount"); mount = httpp_get_query_param(client->parser, "mount");
@ -849,20 +857,12 @@ static void command_shoutcast_metadata(client_t *client, source_t *source)
{ {
char *action; char *action;
char *value; char *value;
char *source_pass;
char *config_source_pass;
ice_config_t *config;
mp3_state *state; mp3_state *state;
DEBUG0("Got shoutcast metadata update request"); DEBUG0("Got shoutcast metadata update request");
COMMAND_REQUIRE(client, "mode", action); COMMAND_REQUIRE(client, "mode", action);
COMMAND_REQUIRE(client, "song", value); COMMAND_REQUIRE(client, "song", value);
COMMAND_REQUIRE(client, "pass", source_pass);
config = config_get_config();
config_source_pass = strdup(config->source_password);
config_release_config();
if (source->format->type == FORMAT_TYPE_VORBIS) { if (source->format->type == FORMAT_TYPE_VORBIS) {
client_send_400 (client, "Cannot update metadata on vorbis streams"); client_send_400 (client, "Cannot update metadata on vorbis streams");
@ -875,17 +875,6 @@ static void command_shoutcast_metadata(client_t *client, source_t *source)
return; return;
} }
if (strcmp(source_pass, config_source_pass) != 0)
{
ERROR0("Invalid source password specified, metadata not updated");
client_send_400 (client, "Invalid source password");
return;
}
if (config_source_pass) {
free(config_source_pass);
}
state = source->format->_state; state = source->format->_state;
mp3_set_tag (source->format, "title", value); mp3_set_tag (source->format, "title", value);

5
src/connection.c
View File

@ -603,12 +603,17 @@ int connection_check_admin_pass(http_parser_t *parser)
ice_config_t *config = config_get_config(); ice_config_t *config = config_get_config();
char *pass = config->admin_password; char *pass = config->admin_password;
char *user = config->admin_username; char *user = config->admin_username;
char *protocol;
if(!pass || !user) { if(!pass || !user) {
config_release_config(); config_release_config();
return 0; return 0;
} }
protocol = httpp_getvar (parser, HTTPP_VAR_PROTOCOL);
if (protocol && strcmp (protocol, "ICY") == 0)
ret = _check_pass_icy (parser, pass);
else
ret = _check_pass_http (parser, user, pass); ret = _check_pass_http (parser, user, pass);
config_release_config(); config_release_config();
return ret; return ret;