mirror of
https://gitlab.xiph.org/xiph/icecast-server.git
synced 2024-12-04 14:46:30 -05:00
Cleanup: Use client_set_queue() and only use it once in client_destroy()
This commit is contained in:
parent
b98aebe388
commit
212ef5bb8f
@ -493,11 +493,6 @@ int auth_release_client (client_t *client) {
|
||||
if (!client->acl)
|
||||
return 0;
|
||||
|
||||
|
||||
/* drop any queue reference here, we do not want a race between the source thread
|
||||
* and the auth/fserve thread */
|
||||
client_set_queue (client, NULL);
|
||||
|
||||
if (client->auth && client->auth->release_client) {
|
||||
auth_client *auth_user = auth_client_setup(client);
|
||||
auth_user->process = auth_remove_client;
|
||||
|
@ -222,10 +222,7 @@ void client_destroy(client_t *client)
|
||||
|
||||
/* release the buffer now, as the buffer could be on the source queue
|
||||
* and may of disappeared after auth completes */
|
||||
if (client->refbuf) {
|
||||
refbuf_release (client->refbuf);
|
||||
client->refbuf = NULL;
|
||||
}
|
||||
client_set_queue(client, NULL);
|
||||
|
||||
if (auth_release_client(client))
|
||||
return;
|
||||
|
Loading…
Reference in New Issue
Block a user