1
0
mirror of https://gitlab.xiph.org/xiph/icecast-server.git synced 2024-09-22 04:15:54 -04:00

Cleanup: Use client_set_queue() and only use it once in client_destroy()

This commit is contained in:
Philipp Schafft 2018-09-19 14:39:19 +00:00
parent b98aebe388
commit 212ef5bb8f
2 changed files with 1 additions and 9 deletions

View File

@ -493,11 +493,6 @@ int auth_release_client (client_t *client) {
if (!client->acl)
return 0;
/* drop any queue reference here, we do not want a race between the source thread
* and the auth/fserve thread */
client_set_queue (client, NULL);
if (client->auth && client->auth->release_client) {
auth_client *auth_user = auth_client_setup(client);
auth_user->process = auth_remove_client;

View File

@ -222,10 +222,7 @@ void client_destroy(client_t *client)
/* release the buffer now, as the buffer could be on the source queue
* and may of disappeared after auth completes */
if (client->refbuf) {
refbuf_release (client->refbuf);
client->refbuf = NULL;
}
client_set_queue(client, NULL);
if (auth_release_client(client))
return;