1
0
mirror of https://github.com/gophernicus/gophernicus.git synced 2024-06-16 06:25:23 +00:00
Commit Graph

10 Commits

Author SHA1 Message Date
Zachary Lee Andrews
6206c24b7e
Update menu.c: Fix JPEG detection.
The existing JPEG detection logic is too restrictive because it checks for the file header "FF D8 FF E0", which only matches JFIF-type JPEG images... Meanwhile EXIF JPEG images are more common these days.

For reference:
FF D8 = JPEG SOI (Start of Image) header
FF-D8-FF-E0 = JFIF
FF-D8-FF-E1 = EXIF
FF-D8-FF-E2 = CIFF
FF-D8-FF-E8 = SPIFF

As you can see checking for the SOI and then FF matches all extent types of JPEG images. \o/
2024-02-27 12:23:16 -05:00
Augustin Fabre
9c0b6a66a4
Rework logging logic
This commit fixes issue #42 [0].

Debug level messages are masked unless option `-d' (debug) is used. In this
case, all messages are also printed to stderr.

syslog.h is included in the base POSIX only since issue 6 (POSIX:2001) [1].

`LOG_UPTO' is an extension, not defined by POSIX; an implementation is provided
here for platforms where it is missing.

This code is inspired by OpenBSD's httpd(8) logging functions [2].

[0] https://github.com/gophernicus/gophernicus/issues/42
[1] https://pubs.opengroup.org/onlinepubs/9699919799/functions/setlogmask.html
[2] https://cvsweb.openbsd.org/src/usr.sbin/httpd/log.c?rev=1.14&content-type=text/x-cvsweb-markup
2020-10-12 20:21:06 +02:00
Augustin Fabre
c5910d5340
Replace spurious tabs in menu with dashes (#81) 2020-08-13 23:46:20 +02:00
Augustin Fabre
647d9c762d
Declare function prototypes explicitly
This make it easier to manage separate compilation units (static functions and
global variables, local type definitions, etc.)

The generated header file `functions.h' caused a circular dependency problem;
it wasn't updated automatically when changes were made to the sources (e.g.
new function definition). The sources can't be in the dependency list of
`functions.h' in the Makefile, because `functions.h' is in the dependency list
of each source file. GNU make is able to ignore the circular dependency but not
BSD make.

At any rate, keeping the prototype list up-to-date is easy, because the
compiler will complain if a function is used in a compilation unit but defined
in an other one.

It also makes static analysis easier out of the box.
2020-06-08 13:10:06 +10:00
fosslinux
c1c7ffe721
Tabs->spaces borked userlist on most clients 2020-04-30 20:19:44 +10:00
fosslinux
ca3b8a8ce4
Sort the ~ selector by date modified
When a gopherer comes in contact with a user listing, the current
order is pretty much useless (by UID). It makes much more sense
to sort by the date modified.

Closes #62
2020-04-28 15:46:49 +10:00
Augustin Fabre
326c15c474
Remove trailing whitespace 2020-04-23 21:18:23 +02:00
Augustin Fabre
5acd7854cc
Fix memory leak in gophermap parsing
FILE pointer `fp' was not closed when the gophermap parsing returned
early.
2020-04-04 12:40:15 +02:00
fosslinux
37ac8823b0
Spaces to Tabs as per consensus in #56 2020-02-05 19:19:42 +11:00
Emil Engler
8949d78794
refactor: New hierarchy and refactored Makefile 2020-01-11 20:41:11 +01:00