1
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-11-04 08:17:24 -05:00
gitea/models
yp05327 e61e9a36b7
Fix PullRequestList.GetIssueIDs's logic (#31352)
fix a bug from #30490

`prs.GetIssueIDs()` will also be used in other places, e.g.
`InvalidateCodeComments`
so we should not add `if pr.Issue == nil` in it, or if `pr.Issue` is
already loaded, you will not get the issueID in the results list and
this is not an expected result.

So this will caused a bug:
before calling `InvalidateCodeComments`, all `pr.Issues` in `prs` are
loaded, so `issueIDs` in this function will always be `[]`.

![image](https://github.com/go-gitea/gitea/assets/18380374/ef94d9d2-0bf9-455a-abd6-4d5e6497db7c)
2024-06-13 09:42:07 +00:00
..
actions Drop IDOrderDesc for listing Actions task and always order by id DESC (#31150) 2024-05-31 02:30:02 +00:00
activities Rename project board -> column to make the UI less confusing (#30170) 2024-05-27 08:59:54 +00:00
admin
asymkey Enable more revive linter rules (#30608) 2024-04-22 11:48:42 +00:00
auth Fix wrong table name (#30557) 2024-04-23 03:00:57 +00:00
avatars
db [Refactor] Unify repo search order by logic (#30876) 2024-06-13 09:13:11 +00:00
dbfs Enable unparam linter (#31277) 2024-06-11 18:47:45 +00:00
fixtures Fix wrong display of recently pushed notification (#25812) 2024-05-21 17:00:35 +00:00
git Fix branch order (#31174) 2024-05-31 09:58:41 +08:00
issues Fix PullRequestList.GetIssueIDs's logic (#31352) 2024-06-13 09:42:07 +00:00
migrations Fix the possible migration failure on 286 with postgres 16 (#31209) 2024-06-02 03:01:08 +00:00
organization Fix wrong display of recently pushed notification (#25812) 2024-05-21 17:00:35 +00:00
packages
perm
project Rename project board -> column to make the UI less confusing (#30170) 2024-05-27 08:59:54 +00:00
pull
repo [Refactor] Unify repo search order by logic (#30876) 2024-06-13 09:13:11 +00:00
secret
shared/types
system
unit Rename project board -> column to make the UI less confusing (#30170) 2024-05-27 08:59:54 +00:00
unittest Add some tests to clarify the "must-change-password" behavior (#30693) 2024-04-27 12:23:37 +00:00
user Performance improvements for pull request list API (#30490) 2024-05-31 12:10:11 +00:00
webhook
error.go
fixture_generation.go
fixture_test.go
main_test.go
org_team_test.go
org_team.go
org_test.go
org.go
repo_test.go
repo_transfer.go chore: use errors.New to replace fmt.Errorf with no parameters will much better (#30621) 2024-04-21 19:44:03 +00:00
repo.go