mirror of
https://github.com/go-gitea/gitea.git
synced 2024-08-27 22:04:28 -04:00
* Add Content-Length header to HEAD requests This change adds the header Content-Length to HEAD HTTP requests. The previous behaviour was blocking some Windows executables (i.e bitsadmin.exe) from downloading files hosted in Gitea. This along with PR #14541, makes the web server compliant with HTTP RFC 2616 which states "The methods GET and HEAD MUST be supported by all general-purpose servers" and "The HEAD method is identical to GET except that the server MUST NOT return a message-body in the response." This should also respond to issues #8030 and #14532. * This change adds the header Content-Length to HEAD HTTP requests Pass the Size of the content as a parameter to ServeData() instead of calculating it using ioutil.ReadAll(reader) --> this call is dangerous and can result in a denial of service. * Add Content-Length header to HEAD requests Quick fix for imported dependency not used. * Check if size is positiv int ... Co-authored-by: zeripath <art27@cantab.net>
182 lines
4.9 KiB
Go
182 lines
4.9 KiB
Go
// Copyright 2014 The Gogs Authors. All rights reserved.
|
|
// Copyright 2018 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package repo
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
"path"
|
|
"strings"
|
|
|
|
"code.gitea.io/gitea/modules/base"
|
|
"code.gitea.io/gitea/modules/charset"
|
|
"code.gitea.io/gitea/modules/context"
|
|
"code.gitea.io/gitea/modules/git"
|
|
"code.gitea.io/gitea/modules/lfs"
|
|
"code.gitea.io/gitea/modules/log"
|
|
)
|
|
|
|
// ServeData download file from io.Reader
|
|
func ServeData(ctx *context.Context, name string, size int64, reader io.Reader) error {
|
|
buf := make([]byte, 1024)
|
|
n, err := reader.Read(buf)
|
|
if err != nil && err != io.EOF {
|
|
return err
|
|
}
|
|
if n >= 0 {
|
|
buf = buf[:n]
|
|
}
|
|
|
|
ctx.Resp.Header().Set("Cache-Control", "public,max-age=86400")
|
|
if size >= 0 {
|
|
ctx.Resp.Header().Set("Content-Length", fmt.Sprintf("%d", size))
|
|
} else {
|
|
log.Error("ServeData called to serve data: %s with size < 0: %d", name, size)
|
|
}
|
|
name = path.Base(name)
|
|
|
|
// Google Chrome dislike commas in filenames, so let's change it to a space
|
|
name = strings.ReplaceAll(name, ",", " ")
|
|
|
|
if base.IsTextFile(buf) || ctx.QueryBool("render") {
|
|
cs, err := charset.DetectEncoding(buf)
|
|
if err != nil {
|
|
log.Error("Detect raw file %s charset failed: %v, using by default utf-8", name, err)
|
|
cs = "utf-8"
|
|
}
|
|
ctx.Resp.Header().Set("Content-Type", "text/plain; charset="+strings.ToLower(cs))
|
|
} else if base.IsImageFile(buf) || base.IsPDFFile(buf) {
|
|
ctx.Resp.Header().Set("Content-Disposition", fmt.Sprintf(`inline; filename="%s"`, name))
|
|
ctx.Resp.Header().Set("Access-Control-Expose-Headers", "Content-Disposition")
|
|
if base.IsSVGImageFile(buf) {
|
|
ctx.Resp.Header().Set("Content-Security-Policy", "default-src 'none'; style-src 'unsafe-inline'; sandbox")
|
|
ctx.Resp.Header().Set("X-Content-Type-Options", "nosniff")
|
|
ctx.Resp.Header().Set("Content-Type", base.SVGMimeType)
|
|
}
|
|
} else {
|
|
ctx.Resp.Header().Set("Content-Disposition", fmt.Sprintf(`attachment; filename="%s"`, name))
|
|
ctx.Resp.Header().Set("Access-Control-Expose-Headers", "Content-Disposition")
|
|
}
|
|
|
|
_, err = ctx.Resp.Write(buf)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
_, err = io.Copy(ctx.Resp, reader)
|
|
return err
|
|
}
|
|
|
|
// ServeBlob download a git.Blob
|
|
func ServeBlob(ctx *context.Context, blob *git.Blob) error {
|
|
dataRc, err := blob.DataAsync()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer func() {
|
|
if err = dataRc.Close(); err != nil {
|
|
log.Error("ServeBlob: Close: %v", err)
|
|
}
|
|
}()
|
|
|
|
return ServeData(ctx, ctx.Repo.TreePath, blob.Size(), dataRc)
|
|
}
|
|
|
|
// ServeBlobOrLFS download a git.Blob redirecting to LFS if necessary
|
|
func ServeBlobOrLFS(ctx *context.Context, blob *git.Blob) error {
|
|
dataRc, err := blob.DataAsync()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer func() {
|
|
if err = dataRc.Close(); err != nil {
|
|
log.Error("ServeBlobOrLFS: Close: %v", err)
|
|
}
|
|
}()
|
|
|
|
if meta, _ := lfs.ReadPointerFile(dataRc); meta != nil {
|
|
meta, _ = ctx.Repo.Repository.GetLFSMetaObjectByOid(meta.Oid)
|
|
if meta == nil {
|
|
return ServeBlob(ctx, blob)
|
|
}
|
|
lfsDataRc, err := lfs.ReadMetaObject(meta)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer func() {
|
|
if err = lfsDataRc.Close(); err != nil {
|
|
log.Error("ServeBlobOrLFS: Close: %v", err)
|
|
}
|
|
}()
|
|
return ServeData(ctx, ctx.Repo.TreePath, meta.Size, lfsDataRc)
|
|
}
|
|
|
|
return ServeBlob(ctx, blob)
|
|
}
|
|
|
|
// SingleDownload download a file by repos path
|
|
func SingleDownload(ctx *context.Context) {
|
|
blob, err := ctx.Repo.Commit.GetBlobByPath(ctx.Repo.TreePath)
|
|
if err != nil {
|
|
if git.IsErrNotExist(err) {
|
|
ctx.NotFound("GetBlobByPath", nil)
|
|
} else {
|
|
ctx.ServerError("GetBlobByPath", err)
|
|
}
|
|
return
|
|
}
|
|
if err = ServeBlob(ctx, blob); err != nil {
|
|
ctx.ServerError("ServeBlob", err)
|
|
}
|
|
}
|
|
|
|
// SingleDownloadOrLFS download a file by repos path redirecting to LFS if necessary
|
|
func SingleDownloadOrLFS(ctx *context.Context) {
|
|
blob, err := ctx.Repo.Commit.GetBlobByPath(ctx.Repo.TreePath)
|
|
if err != nil {
|
|
if git.IsErrNotExist(err) {
|
|
ctx.NotFound("GetBlobByPath", nil)
|
|
} else {
|
|
ctx.ServerError("GetBlobByPath", err)
|
|
}
|
|
return
|
|
}
|
|
if err = ServeBlobOrLFS(ctx, blob); err != nil {
|
|
ctx.ServerError("ServeBlobOrLFS", err)
|
|
}
|
|
}
|
|
|
|
// DownloadByID download a file by sha1 ID
|
|
func DownloadByID(ctx *context.Context) {
|
|
blob, err := ctx.Repo.GitRepo.GetBlob(ctx.Params("sha"))
|
|
if err != nil {
|
|
if git.IsErrNotExist(err) {
|
|
ctx.NotFound("GetBlob", nil)
|
|
} else {
|
|
ctx.ServerError("GetBlob", err)
|
|
}
|
|
return
|
|
}
|
|
if err = ServeBlob(ctx, blob); err != nil {
|
|
ctx.ServerError("ServeBlob", err)
|
|
}
|
|
}
|
|
|
|
// DownloadByIDOrLFS download a file by sha1 ID taking account of LFS
|
|
func DownloadByIDOrLFS(ctx *context.Context) {
|
|
blob, err := ctx.Repo.GitRepo.GetBlob(ctx.Params("sha"))
|
|
if err != nil {
|
|
if git.IsErrNotExist(err) {
|
|
ctx.NotFound("GetBlob", nil)
|
|
} else {
|
|
ctx.ServerError("GetBlob", err)
|
|
}
|
|
return
|
|
}
|
|
if err = ServeBlobOrLFS(ctx, blob); err != nil {
|
|
ctx.ServerError("ServeBlob", err)
|
|
}
|
|
}
|