1
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-11-04 08:17:24 -05:00
gitea/web_src/js/features
wxiaoguang affdd40296
Make issue title edit buttons focusable and fix incorrect ajax requests (#22807)
Replace #19922 , which is stale since my last review:
https://github.com/go-gitea/gitea/pull/19922#pullrequestreview-1003546506
and https://github.com/go-gitea/gitea/pull/19922#issuecomment-1153181546

Close #19769

Changes:
1. Use `<button>` instead of `<div>` for buttons
2. Prevent default event handler in `initGlobalButtonClickOnEnter`
3. Fix the incorrect call to `pullrequest_targetbranch_change`
4. Add a slight margin-left to the input element to make UI look better

The logic in repo-issue.js is not ideal, but this PR isn't going to
touch the logic.

This is also an example for future developers to understand how to make
buttons work properly.

### Before


![image](https://user-images.githubusercontent.com/2114189/217262515-ec0462f7-7051-46a5-bfa2-2f6c6a807b7d.png)

### After

* Add a slight margin-left.
* The `Cancel` button is focused.


![image](https://user-images.githubusercontent.com/2114189/217264891-934c9c8d-d190-4866-98b5-666cea57e28d.png)

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2023-02-09 12:11:16 -05:00
..
admin Improve AppUrl/ROOT_URL checking (#22836) 2023-02-09 11:14:45 -05:00
comp JS refactors (#22227) 2022-12-24 00:03:11 +08:00
aria.js Add ARIA support for Fomantic UI checkboxes (#22599) 2023-01-25 17:52:10 +02:00
aria.md Remove customized (unmaintained) dropdown, improve aria a11y for dropdown (#19861) 2022-06-03 17:38:26 -04:00
captcha.js Add new captcha: cloudflare turnstile (#22369) 2023-02-05 15:29:03 +08:00
citation.js fix webpackChunkName for citation-js-csl (#21806) 2022-11-13 15:10:58 -05:00
clipboard.js Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 2023-02-06 12:09:18 -06:00
codeeditor.js Quick fixes monaco-editor error: "vs.editor.nullLanguage" (#21734) 2022-11-09 18:02:19 +08:00
colorpicker.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
common-global.js Make issue title edit buttons focusable and fix incorrect ajax requests (#22807) 2023-02-09 12:11:16 -05:00
common-issue.js Add a checkbox to select all issues/PRs (#20177) 2022-07-28 18:25:18 +08:00
common-organization.js Use explicit jQuery import, remove unused eslint globals (#18435) 2022-01-28 21:00:11 +00:00
contextpopup.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
copycontent.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
dropzone.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
emoji.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
eventsource.sharedworker.js Fix the JS error "EventSource is not defined" caused by some non-standard browsers (#20584) 2022-08-03 22:58:27 +03:00
file-fold.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
formatting.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
heatmap.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
imagediff.js Add missing close bracket in imagediff (#22710) 2023-02-01 19:48:35 +08:00
install.js Use explicit jQuery import, remove unused eslint globals (#18435) 2022-01-28 21:00:11 +00:00
notification.js Enable contenthash in filename for dynamic assets (#20813) 2022-08-23 20:58:04 +08:00
org-team.js Never use /api/v1 from Gitea UI Pages (#19318) 2022-04-07 20:59:56 +02:00
pull-view-file.js Replace unstyled meter with progress (#19968) 2022-06-15 12:28:24 +08:00
repo-branch.js Add apply-patch, basic revert and cherry-pick functionality (#17902) 2022-02-09 20:28:55 +00:00
repo-code.js Fix links for the menus in the view file page (#22795) 2023-02-08 00:08:44 +08:00
repo-code.test.js Ignore line anchor links with leading zeroes (#21728) 2022-11-11 18:22:36 +08:00
repo-commit.js Improve commit status icons (#21124) 2022-09-09 17:03:18 -04:00
repo-common.js Rework repo buttons (#20602) 2022-08-08 02:15:11 +03:00
repo-diff-filetree.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
repo-diff.js Restore function to "Show more" buttons (#22399) 2023-01-13 13:50:32 +08:00
repo-editor.js Use explicit jQuery import, remove unused eslint globals (#18435) 2022-01-28 21:00:11 +00:00
repo-findfile.js Escape path for the file list (#22741) 2023-02-04 10:30:55 +00:00
repo-findfile.test.js Escape path for the file list (#22741) 2023-02-04 10:30:55 +00:00
repo-graph.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
repo-home.js A minimal change to replace data calls with attr as per guidelines (#19900) 2022-06-06 12:58:53 +08:00
repo-issue-content.js Multiple improvements for comment edit diff (#21990) 2022-12-02 11:42:34 +02:00
repo-issue-pr-form.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
repo-issue.js Make issue title edit buttons focusable and fix incorrect ajax requests (#22807) 2023-02-09 12:11:16 -05:00
repo-legacy.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
repo-migrate.js Update JS dependencies (#21881) 2022-11-22 08:58:55 +08:00
repo-migration.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
repo-projects.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
repo-release.js Enable @<user>- completion popup on the release description textarea (#22359) 2023-02-01 13:14:40 -06:00
repo-settings.js Remove customized (unmaintained) dropdown, improve aria a11y for dropdown (#19861) 2022-06-03 17:38:26 -04:00
repo-template.js Never use /api/v1 from Gitea UI Pages (#19318) 2022-04-07 20:59:56 +02:00
repo-unicode-escape.js Use explicit jQuery import, remove unused eslint globals (#18435) 2022-01-28 21:00:11 +00:00
repo-wiki.js Enable spellcheck for EasyMDE, use contenteditable mode (#19776) 2022-06-29 01:52:58 +08:00
serviceworker.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
sshkey-helper.js Use explicit jQuery import, remove unused eslint globals (#18435) 2022-01-28 21:00:11 +00:00
stopwatch.js Don't display stop watch top bar icon when disabled and hidden when click other place (#22374) 2023-01-09 21:53:11 -05:00
tablesort.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
tribute.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
user-auth-webauthn.js Fix bugs with WebAuthn preventing sign in and registration. (#22651) 2023-02-01 07:24:10 +00:00
user-auth.js Use explicit jQuery import, remove unused eslint globals (#18435) 2022-01-28 21:00:11 +00:00
user-settings.js Use explicit jQuery import, remove unused eslint globals (#18435) 2022-01-28 21:00:11 +00:00