aniani/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2024-06-28 01:35:29 +00:00
Code
c0b97d0485
gitea/tests
History
KN4CK3R c0b97d0485
Prevent double use of git cat-file session. (#29298) (#29301) 
Backport #29298
Fixes the reason why #29101 is hard to replicate.
Related #29297

Create a repo with a file with minimum size 4097 bytes (I use 10000) and
execute the following code:
```go
gitRepo, err := gitrepo.OpenRepository(db.DefaultContext, <repo>)
assert.NoError(t, err)

commit, err := gitRepo.GetCommit(<sha>)
assert.NoError(t, err)

entry, err := commit.GetTreeEntryByPath(<file>)
assert.NoError(t, err)

b := entry.Blob()

// Create a reader
r, err := b.DataAsync()
assert.NoError(t, err)
defer r.Close()

// Create a second reader
r2, err := b.DataAsync()
assert.NoError(t, err) // Should be no error but is ErrNotExist
defer r2.Close()
```

The problem is the check in `CatFileBatch`:


79217ea63c/modules/git/repo_base_nogogit.go (L81-L87)
`Buffered() > 0` is used to check if there is a "operation" in progress
at the moment. This is a problem because we can't control the internal
buffer in the `bufio.Reader`. The code above demonstrates a sequence
which initiates an operation for which the code thinks there is no
active processing. The second call to `DataAsync()` therefore reuses the
existing instances instead of creating a new batch reader.
2024-02-22 03:20:20 +00:00
..
e2e Change green buttons to primary color (#27099) 2023-09-18 22:05:31 +00:00
fuzz Rework markup link rendering (#26745) (#28803) 2024-01-16 02:13:29 +00:00
gitea-lfs-meta Test views of LFS files (#22196) 2022-12-23 07:41:56 +08:00
gitea-repositories-meta Fix reverting a merge commit failing (#28794) (#28825) 2024-01-21 14:18:37 +00:00
integration Prevent double use of git cat-file session. (#29298) (#29301) 2024-02-22 03:20:20 +00:00
testdata/data/attachments/a/0 Allow get release download files and lfs files with oauth2 token format (#26430) (#27379) 2023-10-01 19:54:11 +08:00
mssql.ini.tmpl Remove duplicated notify mail configuration on tests (#26912) 2023-09-05 12:34:36 +02:00
mysql.ini.tmpl Remove duplicated notify mail configuration on tests (#26912) 2023-09-05 12:34:36 +02:00
mysql8.ini.tmpl Do not use deprecated log config options by default (#26592) 2023-08-20 01:05:29 +00:00
pgsql.ini.tmpl Remove duplicated notify mail configuration on tests (#26912) 2023-09-05 12:34:36 +02:00
sqlite.ini.tmpl Do not use deprecated log config options by default (#26592) 2023-08-20 01:05:29 +00:00
test_utils.go Allow get release download files and lfs files with oauth2 token format (#26430) (#27379) 2023-10-01 19:54:11 +08:00