mirror of
https://github.com/go-gitea/gitea.git
synced 2024-11-04 08:17:24 -05:00
beb71f5ef6
It will fix #28268 .
<img width="1313" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/cb1e07d5-7a12-4691-a054-8278ba255bfc">
<img width="1318" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/4fd60820-97f1-4c2c-a233-d3671a5039e9">
## ⚠️ BREAKING ⚠️
But need to give up some features:
<img width="1312" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/281c0d51-0e7d-473f-bbed-216e2f645610">
However, such abandonment may fix #28055 .
## Backgroud
When the user switches the dashboard context to an org, it means they
want to search issues in the repos that belong to the org. However, when
they switch to themselves, it means all repos they can access because
they may have created an issue in a public repo that they don't own.
<img width="286" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/182dcd5b-1c20-4725-93af-96e8dfae5b97">
It's a confusing design. Think about this: What does "In your
repositories" mean when the user switches to an org? Repos belong to the
user or the org?
Whatever, it has been broken by #26012 and its following PRs. After the
PR, it searches for issues in repos that the dashboard context user owns
or has been explicitly granted access to, so it causes #28268.
## How to fix it
It's not really difficult to fix it. Just extend the repo scope to
search issues when the dashboard context user is the doer. Since the
user may create issues or be mentioned in any public repo, we can just
set `AllPublic` to true, which is already supported by indexers. The DB
condition will also support it in this PR.
But the real difficulty is how to count the search results grouped by
repos. It's something like "search issues with this keyword and those
filters, and return the total number and the top results. **Then, group
all of them by repo and return the counts of each group.**"
<img width="314" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/5206eb20-f8f5-49b9-b45a-1be2fcf679f4">
Before #26012, it was being done in the DB, but it caused the results to
be incomplete (see the description of #26012).
And to keep this, #26012 implement it in an inefficient way, just count
the issues by repo one by one, so it cannot work when `AllPublic` is
true because it's almost impossible to do this for all public repos.
|
||
|---|---|---|
| .. | ||
| assignees_test.go | ||
| assignees.go | ||
| comment_code.go | ||
| comment_list.go | ||
| comment_test.go | ||
| comment.go | ||
| content_history_test.go | ||
| content_history.go | ||
| dependency_test.go | ||
| dependency.go | ||
| issue_index.go | ||
| issue_label_test.go | ||
| issue_label.go | ||
| issue_list_test.go | ||
| issue_list.go | ||
| issue_lock.go | ||
| issue_project.go | ||
| issue_search.go | ||
| issue_stats.go | ||
| issue_test.go | ||
| issue_update.go | ||
| issue_user_test.go | ||
| issue_user.go | ||
| issue_watch_test.go | ||
| issue_watch.go | ||
| issue_xref_test.go | ||
| issue_xref.go | ||
| issue.go | ||
| label_test.go | ||
| label.go | ||
| main_test.go | ||
| milestone_list.go | ||
| milestone_test.go | ||
| milestone.go | ||
| pull_list.go | ||
| pull_test.go | ||
| pull.go | ||
| reaction_test.go | ||
| reaction.go | ||
| review_list.go | ||
| review_test.go | ||
| review.go | ||
| stopwatch_test.go | ||
| stopwatch.go | ||
| tracked_time_test.go | ||
| tracked_time.go | ||