1
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-10-30 08:27:32 -04:00
gitea/routers/web/admin
zeripath d6fa138e7c
Only send webhook events to active system webhooks and only deliver to active hooks (#19234)
There is a bug in the system webhooks whereby the active state is not checked when
webhooks are prepared and there is a bug that deactivating webhooks do not prevent
queued deliveries.

* Only add SystemWebhooks to the prepareWebhooks list if they are active
* At the time of delivery if the underlying webhook is not active mark it
as "delivered" but with a failed delivery so it does not get delivered.

Fix #19220

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2022-03-28 11:17:21 +08:00
..
admin_test.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
admin.go Update HTTP status codes to modern codes (#18063) 2022-03-23 12:54:07 +08:00
auths.go Renamed ctx.User to ctx.Doer. (#19161) 2022-03-22 15:03:22 +08:00
emails.go Renamed ctx.User to ctx.Doer. (#19161) 2022-03-22 15:03:22 +08:00
hooks.go Only send webhook events to active system webhooks and only deliver to active hooks (#19234) 2022-03-28 11:17:21 +08:00
main_test.go Decouple unit test code from business code (#17623) 2021-11-12 22:36:47 +08:00
notice.go Update HTTP status codes to modern codes (#18063) 2022-03-23 12:54:07 +08:00
orgs.go Renamed ctx.User to ctx.Doer. (#19161) 2022-03-22 15:03:22 +08:00
repos.go Renamed ctx.User to ctx.Doer. (#19161) 2022-03-22 15:03:22 +08:00
users_test.go Renamed ctx.User to ctx.Doer. (#19161) 2022-03-22 15:03:22 +08:00
users.go Renamed ctx.User to ctx.Doer. (#19161) 2022-03-22 15:03:22 +08:00