1
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-12-04 14:46:57 -05:00
gitea/services
Jimmy Praet 5d3fdd1212
Add branch protection setting for ignoring stale approvals (#28498)
Fixes #27114.

* In Gitea 1.12 (#9532), a "dismiss stale approvals" branch protection
setting was introduced, for ignoring stale reviews when verifying the
approval count of a pull request.
* In Gitea 1.14 (#12674), the "dismiss review" feature was added.
* This caused confusion with users (#25858), as "dismiss" now means 2
different things.
* In Gitea 1.20 (#25882), the behavior of the "dismiss stale approvals"
branch protection was modified to actually dismiss the stale review.

For some users this new behavior of dismissing the stale reviews is not
desirable.

So this PR reintroduces the old behavior as a new "ignore stale
approvals" branch protection setting.

---------

Co-authored-by: delvh <dev.lh@web.de>
2024-01-15 07:20:01 +00:00
..
actions Fix schedule tasks bugs (#28691) 2024-01-12 21:50:38 +00:00
agit Adjust object format interface (#28469) 2023-12-17 11:56:08 +00:00
asymkey Move more functions to db.Find (#28419) 2024-01-15 02:19:25 +00:00
attachment Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
auth Refactor timeutil package (#28623) 2023-12-28 10:09:57 +00:00
automerge Improve queue and logger context (#24924) 2023-05-26 07:31:55 +00:00
context Another round of db.DefaultContext refactor (#27103) 2023-09-25 13:17:37 +00:00
convert Add branch protection setting for ignoring stale approvals (#28498) 2024-01-15 07:20:01 +00:00
cron Update go dependencies (#28518) 2023-12-19 09:18:42 +08:00
externalaccount Final round of db.DefaultContext refactor (#27587) 2023-10-14 08:37:24 +00:00
feed More db.DefaultContext refactor (#27265) 2023-09-29 12:12:54 +00:00
forms Add branch protection setting for ignoring stale approvals (#28498) 2024-01-15 07:20:01 +00:00
gitdiff Add option to disable ambiguous unicode characters detection (#28454) 2023-12-17 14:38:54 +00:00
indexer Fix missing issue search index update when changing status (#28325) 2023-12-03 12:22:44 +01:00
issue Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
lfs Remove GetByBean method because sometimes it's danger when query condition parameter is zero and also introduce new generic methods (#28220) 2023-12-07 15:27:36 +08:00
mailer Fix missing mail reply address (#27997) 2023-11-13 03:20:34 +00:00
markup make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
migrations Move more functions to db.Find (#28419) 2024-01-15 02:19:25 +00:00
mirror Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
notify Update status and code index after changing the default branch (#27018) 2023-09-13 04:43:31 +00:00
org Delete repos of org when purge delete user (#27273) 2023-10-19 13:16:11 +00:00
packages Support for grouping RPMs using paths (#26984) 2024-01-12 03:16:05 +00:00
pull Concatenate error in checkIfPRContentChanged (#28731) 2024-01-09 10:32:14 +08:00
release Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
repository Move more functions to db.Find (#28419) 2024-01-15 02:19:25 +00:00
secrets Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
task Fix incorrect ctx usage in defer function (#27740) 2023-10-22 14:12:27 +00:00
uinotification Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
user Forbid removing the last admin user (#28337) 2024-01-15 06:51:43 +00:00
webhook Abstract hash function usage (#28138) 2023-12-13 21:02:00 +00:00
wiki Fix schedule tasks bugs (#28691) 2024-01-12 21:50:38 +00:00