1
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-12-04 14:46:57 -05:00
gitea/modules/markup
Giteabot 5123ed3191
Fixes #27605: inline math blocks can't be preceeded/followed by alphanumerical characters (#30175) (#30250)
Backport #30175 by @jmlt2002

- Inline math blocks couldn't be preceeded or succeeded by
alphanumerical characters due to changes introduced in PR #21171.
Removed the condition that caused this (precedingCharacter condition)
and added a new exit condition of the for-loop that checks if a specific
'$' was escaped using '\' so that the math expression can be rendered as
intended.
- Additionally this PR fixes another bug where math blocks of the type
'$xyz$abc$' where the dollar sign was not escaped by the user, generated
an error (shown in the screenshots below)
- Altered the tests to accomodate for the changes

Former behaviour (from try.gitea.io):

![image](https://github.com/go-gitea/gitea/assets/114936010/8f0cbb21-321d-451c-b871-c67a8e1e9235)

Fixed behaviour (from my local build):

![image](https://github.com/go-gitea/gitea/assets/114936010/5c22687c-6f11-4407-b5e7-c14b838bc20d)

(Edit) Source code for the README.md file:
```
$x$ -$x$ $x$-

a$xa$ $xa$a 1$xb$ $xb$1

$a a$b b$

a$b $a a$b b$

$a a\$b b$
```

Signed-off-by: João Tiago <joao.leal.tintas@tecnico.ulisboa.pt>
Co-authored-by: João Tiago <114936010+jmlt2002@users.noreply.github.com>
2024-04-03 06:06:39 +00:00
..
asciicast Support asciicast files as new markup (#22448) 2023-01-18 08:46:58 +08:00
common Make user-content-* consistent with github (#26388) 2023-08-09 09:30:31 +00:00
console Add context when rendering labels or emojis (#23281) 2023-03-05 22:59:05 +01:00
csv Fix incorrect rendering csv file when file size is larger than UI.CSV.MaxFileSize (#29653) (#29663) 2024-03-08 09:13:58 +00:00
external Rework markup link rendering (#26745) (#28803) 2024-01-16 02:13:29 +00:00
markdown Fixes #27605: inline math blocks can't be preceeded/followed by alphanumerical characters (#30175) (#30250) 2024-04-03 06:06:39 +00:00
mdstripper Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
orgmode fix: rendering internal file links in org (#29669) (#29705) 2024-03-10 18:29:17 +01:00
camo_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
camo.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
html_internal_test.go Rework markup link rendering (#26745) (#28803) 2024-01-16 02:13:29 +00:00
html_test.go Rework markup link rendering (#26745) (#28803) 2024-01-16 02:13:29 +00:00
html.go Rework markup link rendering (#26745) (#28803) 2024-01-16 02:13:29 +00:00
renderer_test.go Move IsReadmeFile* from modules/markup/ to modules/util (#22877) 2023-02-13 15:01:09 -05:00
renderer.go Rework markup link rendering (#26745) (#28803) 2024-01-16 02:13:29 +00:00
sanitizer_test.go Render plaintext task list items for markdown files (#26186) 2023-07-27 14:15:31 +00:00
sanitizer.go Render plaintext task list items for markdown files (#26186) 2023-07-27 14:15:31 +00:00