1
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-10-18 06:33:44 -04:00
gitea/models/issues
yp05327 e61e9a36b7
Fix PullRequestList.GetIssueIDs's logic (#31352)
fix a bug from #30490

`prs.GetIssueIDs()` will also be used in other places, e.g.
`InvalidateCodeComments`
so we should not add `if pr.Issue == nil` in it, or if `pr.Issue` is
already loaded, you will not get the issueID in the results list and
this is not an expected result.

So this will caused a bug:
before calling `InvalidateCodeComments`, all `pr.Issues` in `prs` are
loaded, so `issueIDs` in this function will always be `[]`.

![image](https://github.com/go-gitea/gitea/assets/18380374/ef94d9d2-0bf9-455a-abd6-4d5e6497db7c)
2024-06-13 09:42:07 +00:00
..
assignees_test.go
assignees.go Performance improvements for pull request list API (#30490) 2024-05-31 12:10:11 +00:00
comment_code.go Use repo as of renderctx's member rather than a repoPath on metas (#29222) 2024-05-30 07:04:01 +00:00
comment_list.go Only update poster in issue/comment list if it has been loaded (#31216) 2024-06-02 10:32:20 +08:00
comment_test.go
comment.go Prevent simultaneous editing of comments and issues (#31053) 2024-05-27 15:34:18 +00:00
content_history_test.go
content_history.go
dependency_test.go
dependency.go
issue_index.go
issue_label_test.go
issue_label.go Performance improvements for pull request list API (#30490) 2024-05-31 12:10:11 +00:00
issue_list_test.go
issue_list.go Only update poster in issue/comment list if it has been loaded (#31216) 2024-06-02 10:32:20 +08:00
issue_lock.go
issue_project.go
issue_search.go Enable unparam linter (#31277) 2024-06-11 18:47:45 +00:00
issue_stats.go
issue_test.go
issue_update.go Prevent simultaneous editing of comments and issues (#31053) 2024-05-27 15:34:18 +00:00
issue_user_test.go
issue_user.go
issue_watch_test.go
issue_watch.go
issue_xref_test.go
issue_xref.go
issue.go Performance improvements for pull request list API (#30490) 2024-05-31 12:10:11 +00:00
label_test.go
label.go
main_test.go
milestone_list.go
milestone_test.go
milestone.go
pull_list.go Fix PullRequestList.GetIssueIDs's logic (#31352) 2024-06-13 09:42:07 +00:00
pull_test.go
pull.go Performance improvements for pull request list API (#30490) 2024-05-31 12:10:11 +00:00
reaction.go
review_list.go
review_test.go
review.go
stopwatch_test.go
stopwatch.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
tracked_time_test.go
tracked_time.go Update misspell to 0.5.1 and add misspellings.csv (#30573) 2024-04-27 08:03:49 +00:00