mirror of
https://github.com/go-gitea/gitea.git
synced 2024-08-26 21:54:19 -04:00
Fix https://github.com/go-gitea/gitea/issues/23715 Other related PRs: * #23717 * #23716 * #23719 This PR is different from others, it tries to resolve the problem fundamentally (and brings more benefits) Although it looks like some more lines are added, actually many new lines are for tests. ---- Before, the code was just "guessing" the file type and try to parse them. <details> ![image](https://user-images.githubusercontent.com/2114189/228002245-57d58e27-1078-4da9-bf42-5bc0b264c6ce.png) </details> This PR: * Always remember the original option file names, and always use correct parser for them. * Another benefit is that we can sort the Label Templates now (before there was a map, its key order is undefined) ![image](https://user-images.githubusercontent.com/2114189/228002432-931b9f18-3908-484b-a36b-04760c9ad132.png)
171 lines
4.9 KiB
Go
171 lines
4.9 KiB
Go
// Copyright 2017 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package repo
|
|
|
|
import (
|
|
"net/http"
|
|
"strconv"
|
|
"testing"
|
|
|
|
issues_model "code.gitea.io/gitea/models/issues"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
"code.gitea.io/gitea/modules/repository"
|
|
"code.gitea.io/gitea/modules/test"
|
|
"code.gitea.io/gitea/modules/web"
|
|
"code.gitea.io/gitea/services/forms"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func int64SliceToCommaSeparated(a []int64) string {
|
|
s := ""
|
|
for i, n := range a {
|
|
if i > 0 {
|
|
s += ","
|
|
}
|
|
s += strconv.Itoa(int(n))
|
|
}
|
|
return s
|
|
}
|
|
|
|
func TestInitializeLabels(t *testing.T) {
|
|
unittest.PrepareTestEnv(t)
|
|
assert.NoError(t, repository.LoadRepoConfig())
|
|
ctx := test.MockContext(t, "user2/repo1/labels/initialize")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 2)
|
|
web.SetForm(ctx, &forms.InitializeLabelsForm{TemplateName: "Default"})
|
|
InitializeLabels(ctx)
|
|
assert.EqualValues(t, http.StatusSeeOther, ctx.Resp.Status())
|
|
unittest.AssertExistsAndLoadBean(t, &issues_model.Label{
|
|
RepoID: 2,
|
|
Name: "enhancement",
|
|
Color: "#84b6eb",
|
|
})
|
|
assert.Equal(t, "/user2/repo2/labels", test.RedirectURL(ctx.Resp))
|
|
}
|
|
|
|
func TestRetrieveLabels(t *testing.T) {
|
|
unittest.PrepareTestEnv(t)
|
|
for _, testCase := range []struct {
|
|
RepoID int64
|
|
Sort string
|
|
ExpectedLabelIDs []int64
|
|
}{
|
|
{1, "", []int64{1, 2}},
|
|
{1, "leastissues", []int64{2, 1}},
|
|
{2, "", []int64{}},
|
|
} {
|
|
ctx := test.MockContext(t, "user/repo/issues")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, testCase.RepoID)
|
|
ctx.Req.Form.Set("sort", testCase.Sort)
|
|
RetrieveLabels(ctx)
|
|
assert.False(t, ctx.Written())
|
|
labels, ok := ctx.Data["Labels"].([]*issues_model.Label)
|
|
assert.True(t, ok)
|
|
if assert.Len(t, labels, len(testCase.ExpectedLabelIDs)) {
|
|
for i, label := range labels {
|
|
assert.EqualValues(t, testCase.ExpectedLabelIDs[i], label.ID)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestNewLabel(t *testing.T) {
|
|
unittest.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1/labels/edit")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 1)
|
|
web.SetForm(ctx, &forms.CreateLabelForm{
|
|
Title: "newlabel",
|
|
Color: "#abcdef",
|
|
})
|
|
NewLabel(ctx)
|
|
assert.EqualValues(t, http.StatusSeeOther, ctx.Resp.Status())
|
|
unittest.AssertExistsAndLoadBean(t, &issues_model.Label{
|
|
Name: "newlabel",
|
|
Color: "#abcdef",
|
|
})
|
|
assert.Equal(t, "/user2/repo1/labels", test.RedirectURL(ctx.Resp))
|
|
}
|
|
|
|
func TestUpdateLabel(t *testing.T) {
|
|
unittest.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1/labels/edit")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 1)
|
|
web.SetForm(ctx, &forms.CreateLabelForm{
|
|
ID: 2,
|
|
Title: "newnameforlabel",
|
|
Color: "#abcdef",
|
|
})
|
|
UpdateLabel(ctx)
|
|
assert.EqualValues(t, http.StatusSeeOther, ctx.Resp.Status())
|
|
unittest.AssertExistsAndLoadBean(t, &issues_model.Label{
|
|
ID: 2,
|
|
Name: "newnameforlabel",
|
|
Color: "#abcdef",
|
|
})
|
|
assert.Equal(t, "/user2/repo1/labels", test.RedirectURL(ctx.Resp))
|
|
}
|
|
|
|
func TestDeleteLabel(t *testing.T) {
|
|
unittest.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1/labels/delete")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 1)
|
|
ctx.Req.Form.Set("id", "2")
|
|
DeleteLabel(ctx)
|
|
assert.EqualValues(t, http.StatusOK, ctx.Resp.Status())
|
|
unittest.AssertNotExistsBean(t, &issues_model.Label{ID: 2})
|
|
unittest.AssertNotExistsBean(t, &issues_model.IssueLabel{LabelID: 2})
|
|
assert.Equal(t, ctx.Tr("repo.issues.label_deletion_success"), ctx.Flash.SuccessMsg)
|
|
}
|
|
|
|
func TestUpdateIssueLabel_Clear(t *testing.T) {
|
|
unittest.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1/issues/labels")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 1)
|
|
ctx.Req.Form.Set("issue_ids", "1,3")
|
|
ctx.Req.Form.Set("action", "clear")
|
|
UpdateIssueLabel(ctx)
|
|
assert.EqualValues(t, http.StatusOK, ctx.Resp.Status())
|
|
unittest.AssertNotExistsBean(t, &issues_model.IssueLabel{IssueID: 1})
|
|
unittest.AssertNotExistsBean(t, &issues_model.IssueLabel{IssueID: 3})
|
|
unittest.CheckConsistencyFor(t, &issues_model.Label{})
|
|
}
|
|
|
|
func TestUpdateIssueLabel_Toggle(t *testing.T) {
|
|
for _, testCase := range []struct {
|
|
Action string
|
|
IssueIDs []int64
|
|
LabelID int64
|
|
ExpectedAdd bool // whether we expect the label to be added to the issues
|
|
}{
|
|
{"attach", []int64{1, 3}, 1, true},
|
|
{"detach", []int64{1, 3}, 1, false},
|
|
{"toggle", []int64{1, 3}, 1, false},
|
|
{"toggle", []int64{1, 2}, 2, true},
|
|
} {
|
|
unittest.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1/issues/labels")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 1)
|
|
ctx.Req.Form.Set("issue_ids", int64SliceToCommaSeparated(testCase.IssueIDs))
|
|
ctx.Req.Form.Set("action", testCase.Action)
|
|
ctx.Req.Form.Set("id", strconv.Itoa(int(testCase.LabelID)))
|
|
UpdateIssueLabel(ctx)
|
|
assert.EqualValues(t, http.StatusOK, ctx.Resp.Status())
|
|
for _, issueID := range testCase.IssueIDs {
|
|
unittest.AssertExistsIf(t, testCase.ExpectedAdd, &issues_model.IssueLabel{
|
|
IssueID: issueID,
|
|
LabelID: testCase.LabelID,
|
|
})
|
|
}
|
|
unittest.CheckConsistencyFor(t, &issues_model.Label{})
|
|
}
|
|
}
|