mirror of
https://github.com/go-gitea/gitea.git
synced 2024-08-26 21:54:19 -04:00
The rollback functionality in services/repository/repository.go:ForkRepository is incorrect and could lead to a deadlock as it uses DeleteRepository to delete the rolled-back repository - a function which creates its own transaction. This PR adjusts the rollback function to only use RemoveAll as any database changes will be automatically rolled-back. It also handles panics and adjusts the Close within WithTx to ensure that if there is a panic the session will always be closed. Signed-off-by: Andrew Thornton <art27@cantab.net>
135 lines
3.7 KiB
Go
135 lines
3.7 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package repository
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
"time"
|
|
|
|
"code.gitea.io/gitea/models"
|
|
"code.gitea.io/gitea/modules/git"
|
|
"code.gitea.io/gitea/modules/log"
|
|
"code.gitea.io/gitea/modules/structs"
|
|
"code.gitea.io/gitea/modules/util"
|
|
)
|
|
|
|
// ForkRepository forks a repository
|
|
func ForkRepository(doer, owner *models.User, opts models.ForkRepoOptions) (_ *models.Repository, err error) {
|
|
forkedRepo, err := opts.BaseRepo.GetUserFork(owner.ID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if forkedRepo != nil {
|
|
return nil, models.ErrForkAlreadyExist{
|
|
Uname: owner.Name,
|
|
RepoName: opts.BaseRepo.FullName(),
|
|
ForkName: forkedRepo.FullName(),
|
|
}
|
|
}
|
|
|
|
repo := &models.Repository{
|
|
OwnerID: owner.ID,
|
|
Owner: owner,
|
|
OwnerName: owner.Name,
|
|
Name: opts.Name,
|
|
LowerName: strings.ToLower(opts.Name),
|
|
Description: opts.Description,
|
|
DefaultBranch: opts.BaseRepo.DefaultBranch,
|
|
IsPrivate: opts.BaseRepo.IsPrivate || opts.BaseRepo.Owner.Visibility == structs.VisibleTypePrivate,
|
|
IsEmpty: opts.BaseRepo.IsEmpty,
|
|
IsFork: true,
|
|
ForkID: opts.BaseRepo.ID,
|
|
}
|
|
|
|
oldRepoPath := opts.BaseRepo.RepoPath()
|
|
|
|
needsRollback := false
|
|
rollbackFn := func() {
|
|
if !needsRollback {
|
|
return
|
|
}
|
|
|
|
repoPath := models.RepoPath(owner.Name, repo.Name)
|
|
|
|
if exists, _ := util.IsExist(repoPath); !exists {
|
|
return
|
|
}
|
|
|
|
// As the transaction will be failed and hence database changes will be destroyed we only need
|
|
// to delete the related repository on the filesystem
|
|
if errDelete := util.RemoveAll(repoPath); errDelete != nil {
|
|
log.Error("Failed to remove fork repo")
|
|
}
|
|
}
|
|
|
|
needsRollbackInPanic := true
|
|
defer func() {
|
|
panicErr := recover()
|
|
if panicErr == nil {
|
|
return
|
|
}
|
|
|
|
if needsRollbackInPanic {
|
|
rollbackFn()
|
|
}
|
|
panic(panicErr)
|
|
}()
|
|
|
|
err = models.WithTx(func(ctx models.DBContext) error {
|
|
if err = models.CreateRepository(ctx, doer, owner, repo, false); err != nil {
|
|
return err
|
|
}
|
|
|
|
if err = models.IncrementRepoForkNum(ctx, opts.BaseRepo.ID); err != nil {
|
|
return err
|
|
}
|
|
|
|
// copy lfs files failure should not be ignored
|
|
if err = models.CopyLFS(ctx, repo, opts.BaseRepo); err != nil {
|
|
return err
|
|
}
|
|
|
|
needsRollback = true
|
|
|
|
repoPath := models.RepoPath(owner.Name, repo.Name)
|
|
if stdout, err := git.NewCommand(
|
|
"clone", "--bare", oldRepoPath, repoPath).
|
|
SetDescription(fmt.Sprintf("ForkRepository(git clone): %s to %s", opts.BaseRepo.FullName(), repo.FullName())).
|
|
RunInDirTimeout(10*time.Minute, ""); err != nil {
|
|
log.Error("Fork Repository (git clone) Failed for %v (from %v):\nStdout: %s\nError: %v", repo, opts.BaseRepo, stdout, err)
|
|
return fmt.Errorf("git clone: %v", err)
|
|
}
|
|
|
|
if stdout, err := git.NewCommand("update-server-info").
|
|
SetDescription(fmt.Sprintf("ForkRepository(git update-server-info): %s", repo.FullName())).
|
|
RunInDir(repoPath); err != nil {
|
|
log.Error("Fork Repository (git update-server-info) failed for %v:\nStdout: %s\nError: %v", repo, stdout, err)
|
|
return fmt.Errorf("git update-server-info: %v", err)
|
|
}
|
|
|
|
if err = createDelegateHooks(repoPath); err != nil {
|
|
return fmt.Errorf("createDelegateHooks: %v", err)
|
|
}
|
|
return nil
|
|
})
|
|
needsRollbackInPanic = false
|
|
if err != nil {
|
|
rollbackFn()
|
|
return nil, err
|
|
}
|
|
|
|
// even if below operations failed, it could be ignored. And they will be retried
|
|
ctx := models.DefaultDBContext()
|
|
if err := repo.UpdateSize(ctx); err != nil {
|
|
log.Error("Failed to update size for repository: %v", err)
|
|
}
|
|
if err := models.CopyLanguageStat(opts.BaseRepo, repo); err != nil {
|
|
log.Error("Copy language stat from oldRepo failed")
|
|
}
|
|
|
|
return repo, nil
|
|
}
|